-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake/build output with invalid encoding when the cmake geneartor are Ninja #1615
Comments
Does setting |
It's not work as you expect,
"cmake.outputLogEncoding": "utf8" cause encoding problem The ninja is output with windows codepage. does cmake treat ninja output always to be utf8? |
Unfortunately, I don't know the answer to that. Does the output look correct when you run the cmake command in the VS Code Terminal, or a PowerShell/CMD prompt? |
Valid in PowerShell/CMD prompt, VS Code Terminal not working because the MSVC bat env not setup properly |
@taoyouh, @lygstate, if you would like, you can try this vsix (https://github.com/microsoft/vscode-cmake-tools/actions/runs/811030625) to get unblocked with a fix for this issue before we release 1.7.2. |
* Fix typo in CMakePresets.json schema (#1809) MinSizRel => MinSizeRel * update version to 1.7.2 * Localize an error message * Added counts for presets (#1819) * override the locale when querying compiler versions (#1824) * Adopt new localization process (#1831) * Fix Operator Precedence when Getting Code Page (#1808) The replacing should happen after the "??" operator. Fixes #1615 Co-authored-by: Andreea Isac <[email protected]> * If we have both "-DCMAKE_GENERATOR:STRING=" and the generator from (#1753) toolchain, prefre using "-DCMAKE_GENERATOR:STRING=", as "-DCMAKE_GENERATOR:STRING=" can be defined by different cmake-variants.yaml Signed-off-by: Yonggang Luo <[email protected]> Co-authored-by: Andreea Isac <[email protected]> * Use stricter type checks in presets expansion (#1818) * Use stricter type checks in presets expansion * Resolving comments Co-authored-by: Andreea Isac <[email protected]> * Fix paths of target sources outside the workspace (#1816) * Fix paths of target sources outside the workspace For more details, see: #1504 * Add test for source files outside of workspace root Co-Authored-By: Elson Wei <[email protected]> Co-authored-by: Elson Wei <[email protected]> Co-authored-by: Bob Brown <[email protected]> * CHANGELOG updates for 1.7.2 (#1837) Co-authored-by: BlueC0re <[email protected]> Co-authored-by: Bob Brown <[email protected]> Co-authored-by: Bob Brown (DEVDIV) <[email protected]> Co-authored-by: xisui-MSFT <[email protected]> Co-authored-by: Colen Garoutte-Carson <[email protected]> Co-authored-by: Huang, Zhaoquan <[email protected]> Co-authored-by: Yonggang Luo <[email protected]> Co-authored-by: Simon Leiner <[email protected]> Co-authored-by: Elson Wei <[email protected]>
CMake Tools 1.7.2 was released today and it contains a fix for this problem. Upgrade the extension and let us know if you encounter any other issues. |
thanks, works now |
Brief Issue Summary
The outputs
The text was updated successfully, but these errors were encountered: