-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes conflict between -DCMAKE_GENERATOR:STRING=Ninja
and -G "Visual Studio 16 2019" -A x64
#1753
Conversation
toolchain, prefre using "-DCMAKE_GENERATOR:STRING=", as "-DCMAKE_GENERATOR:STRING=" can be defined by different cmake-variants.yaml Signed-off-by: Yonggang Luo <[email protected]>
@bobbrow Hi this fixes a issue , hopt it merged in 1.7.1 |
-DCMAKE_GENERATOR:STRING=Ninja
and -G "Visual Studio 16 2019" -A x64
Thank you for all of the PR's @lygstate. 1.7.1 was primarily a patch for a critical issue and we didn't have time to assess your PR's. I think we will do a 1.7.2 with another patch for CMake Presets next week so we may be able to get some of these open PR's into that. |
@lygstate, your contribution is included in 1.7.2 which will release in a few days. If you would like, you can try this vsix (https://github.com/microsoft/vscode-cmake-tools/actions/runs/811030625) to get this support before we release 1.7.2. |
* Fix typo in CMakePresets.json schema (#1809) MinSizRel => MinSizeRel * update version to 1.7.2 * Localize an error message * Added counts for presets (#1819) * override the locale when querying compiler versions (#1824) * Adopt new localization process (#1831) * Fix Operator Precedence when Getting Code Page (#1808) The replacing should happen after the "??" operator. Fixes #1615 Co-authored-by: Andreea Isac <[email protected]> * If we have both "-DCMAKE_GENERATOR:STRING=" and the generator from (#1753) toolchain, prefre using "-DCMAKE_GENERATOR:STRING=", as "-DCMAKE_GENERATOR:STRING=" can be defined by different cmake-variants.yaml Signed-off-by: Yonggang Luo <[email protected]> Co-authored-by: Andreea Isac <[email protected]> * Use stricter type checks in presets expansion (#1818) * Use stricter type checks in presets expansion * Resolving comments Co-authored-by: Andreea Isac <[email protected]> * Fix paths of target sources outside the workspace (#1816) * Fix paths of target sources outside the workspace For more details, see: #1504 * Add test for source files outside of workspace root Co-Authored-By: Elson Wei <[email protected]> Co-authored-by: Elson Wei <[email protected]> Co-authored-by: Bob Brown <[email protected]> * CHANGELOG updates for 1.7.2 (#1837) Co-authored-by: BlueC0re <[email protected]> Co-authored-by: Bob Brown <[email protected]> Co-authored-by: Bob Brown (DEVDIV) <[email protected]> Co-authored-by: xisui-MSFT <[email protected]> Co-authored-by: Colen Garoutte-Carson <[email protected]> Co-authored-by: Huang, Zhaoquan <[email protected]> Co-authored-by: Yonggang Luo <[email protected]> Co-authored-by: Simon Leiner <[email protected]> Co-authored-by: Elson Wei <[email protected]>
If we have both "-DCMAKE_GENERATOR:STRING=" and the generator from
toolchain, prefre using "-DCMAKE_GENERATOR:STRING=", as
"-DCMAKE_GENERATOR:STRING=" can be defined by different cmake-variants.yaml