-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG updates for 1.7.2 #1837
Conversation
CHANGELOG.md
Outdated
- Solve conflict between -DCMAKE_GENERAOR:STRING=Ninja versus -G "Visual Studio 16 2019" -A x64. [PR #1753](https://github.com/microsoft/vscode-cmake-tools/pull/1753) [@lygstate](https://github.com/lygstate) | ||
- Fix operator precedence when getting code page. [#1615](https://github.com/microsoft/vscode-cmake-tools/issues/1615) [@taoyouh](https://github.com/taoyouh) | ||
- Override the locale when querying compiler versions. [#1821](https://github.com/microsoft/vscode-cmake-tools/issues/1821) | ||
- Fix typo in CMakePresets.json schema. [PR #1809](https://github.com/microsoft/vscode-cmake-tools/pull/1809) [@1809] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is missing the contributor alias.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bluec0re
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still a stray [@1809]
in there. Remove it and then this is good to merge.
* Fix typo in CMakePresets.json schema (#1809) MinSizRel => MinSizeRel * update version to 1.7.2 * Localize an error message * Added counts for presets (#1819) * override the locale when querying compiler versions (#1824) * Adopt new localization process (#1831) * Fix Operator Precedence when Getting Code Page (#1808) The replacing should happen after the "??" operator. Fixes #1615 Co-authored-by: Andreea Isac <[email protected]> * If we have both "-DCMAKE_GENERATOR:STRING=" and the generator from (#1753) toolchain, prefre using "-DCMAKE_GENERATOR:STRING=", as "-DCMAKE_GENERATOR:STRING=" can be defined by different cmake-variants.yaml Signed-off-by: Yonggang Luo <[email protected]> Co-authored-by: Andreea Isac <[email protected]> * Use stricter type checks in presets expansion (#1818) * Use stricter type checks in presets expansion * Resolving comments Co-authored-by: Andreea Isac <[email protected]> * Fix paths of target sources outside the workspace (#1816) * Fix paths of target sources outside the workspace For more details, see: #1504 * Add test for source files outside of workspace root Co-Authored-By: Elson Wei <[email protected]> Co-authored-by: Elson Wei <[email protected]> Co-authored-by: Bob Brown <[email protected]> * CHANGELOG updates for 1.7.2 (#1837) Co-authored-by: BlueC0re <[email protected]> Co-authored-by: Bob Brown <[email protected]> Co-authored-by: Bob Brown (DEVDIV) <[email protected]> Co-authored-by: xisui-MSFT <[email protected]> Co-authored-by: Colen Garoutte-Carson <[email protected]> Co-authored-by: Huang, Zhaoquan <[email protected]> Co-authored-by: Yonggang Luo <[email protected]> Co-authored-by: Simon Leiner <[email protected]> Co-authored-by: Elson Wei <[email protected]>
No description provided.