Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-4121: popover refactor #2520

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

LG-4121: popover refactor #2520

wants to merge 12 commits into from

Commits on Oct 11, 2024

  1. LG-4444: OverlayContext and useOverlay (#2454)

    * OverlayContext, useOverlayContext, and OverlayProvider
    
    * useOverlay to register, remove, and track isTopMostOverlay
    
    * Export overlay context related components and hooks and include provider in LG provider
    
    * README and changeset
    
    * Fix type and lint
    
    * Update registerOverlay logic and use more explicit generic type names
    stephl3 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8e4f620 View commit details
    Browse the repository at this point in the history
  2. LG-4446: refactor PopoverContext and replace PortalContext (#2456)

    * PopoverContext supports additional props and marks isPopoverOpen and setIsPopoverOpen deprecated
    
    * Replace PortalContext with newly extended PopoverContext
    
    * Changesets
    
    * Add todo in select spec and update todos with jira tix
    stephl3 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0220fee View commit details
    Browse the repository at this point in the history
  3. LG-4447: refactor Popover positioning logic and remove unused content…

    …ClassName prop (#2457)
    
    * Refactor popover styles
    
    * Remove redundant contentClassName prop
    
    * Clean up Popover positioning logic
    
    * Changesets
    
    * Reorg code
    
    * useIsomorphicLayoutEffect instead of useMemo
    
    * Update changesets
    
    * Revert changes
    stephl3 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    cdd1470 View commit details
    Browse the repository at this point in the history
  4. LG-4515: replace position utils with @floating-ui/react (#2473)

    * Add @floating-ui/react dependency
    
    * Clean up Popover stories
    
    * Replace position utils and usePopoverPositioning with useFloating
    
    * Remove replaced positioning hook and utils
    
    * Fix adjustOnMutation and stories
    
    * Changeset
    
    * Add useMergeRefs hook
    
    * Address feedback
    stephl3 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    20068ca View commit details
    Browse the repository at this point in the history
  5. Update default value of Popover spacing prop from 10px to 4px (#2479)

    * Update Popover default spacing from 10 to 4
    
    * Changeset
    
    * Update README and stories
    stephl3 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    aef09c4 View commit details
    Browse the repository at this point in the history
  6. LG-4516: deprecate justify="fit" from popover and related components (#…

    …2474)
    
    * Remove justify fit from @leafygreen-ui/popover
    
    * Remove justify fit usage in packages using Popover
    
    * Changeset
    stephl3 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7b57f2e View commit details
    Browse the repository at this point in the history
  7. LG-4445: add renderMode and top layer (#2482)

    * Fix usePortal={false} transition and className order
    
    * Replace usePortal with renderMode and add top layer render mode in Popover
    
    * Replace usePortal with renderMode and add top layer render mode in LG Provider
    
    * Refactor types in Popover-consuming packages
    
    * README
    
    * Address feedback
    stephl3 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3cfece1 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    873e6ec View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. LG-4526: refactor popover-consuming components (#2501)

    * Replace usePortal with renderMode and refactor Popover-consuming components
    
    * Fix tooltip hover delays
    
    * Initial feedback
    
    * Additional feedback
    
    * Fix transition
    
    * Fix stories
    stephl3 authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6c50a53 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. LG-4525: popover-v12 code mod (#2484)

    * Add addJSXAttributes code mod util
    
    * Update consolidateJSXAttributes util to handle edge case
    
    * Add removeJSXAttributes code mod util
    
    * Fix comment utils
    
    * Export utils from utils/transformations
    
    * Add popover-v12 codemod
    
    * Changeset
    
    * Fix build type
    
    * Clean up comments
    
    * Update docs
    
    * Add commentOverride
    
    * Update transform.config.js
    stephl3 authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ba96107 View commit details
    Browse the repository at this point in the history
  2. Fix escape key close in Modal (#2513)

    * Fix Modal escape key close
    
    * Address feedback
    
    * Update ModalPopoverContext docs
    
    * LG-4525: MigrationProvider with forceUseTopLayer flag (#2514)
    
    * Add MigrationContext for global props
    
    * Integrate forceUseTopLayer flag into Popover component
    stephl3 authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f5177a4 View commit details
    Browse the repository at this point in the history
  3. Fix Copyable tooltip spec (#2519)

    * Fix Copyable tooltip spec
    
    * Update test
    stephl3 authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    22b35d3 View commit details
    Browse the repository at this point in the history