Port robot_model submodule of moveit_core to ROS 2 #10
Conversation
moveit_core/robot_model/include/moveit/robot_model/joint_model.h
Outdated
Show resolved
Hide resolved
moveit_core/robot_model/include/moveit/robot_model/joint_model.h
Outdated
Show resolved
Hide resolved
Remove unnecesary commands listed already one level higher
Following guidelines provided at moveit#8 (comment)
moveit_resources hasn't been ported just yet
moveit_core/robot_model/include/moveit/robot_model/joint_model.h
Outdated
Show resolved
Hide resolved
moveit_core/robot_model/include/moveit/robot_model/robot_model.h
Outdated
Show resolved
Hide resolved
with moveit_resources ported moveit/moveit_resources#24 this PR re-enables the testing while allowing the submodule to still compile
|
Note AcutronicRobotics#13 |
Planning scene & trajectory_processing
Follow consensus about logging in moveit_core submodules
|
@davetcoleman and @mlautman, please review again, I think we're good to go Edit: removed leftovers which are not necessary anymore f6700ab |
| * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN | ||
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| *********************************************************************/ |
There was a problem hiding this comment.
For future reference, please avoid changes like this
There was a problem hiding this comment.
Right, makes sense. Frankly that's the result of applying clang-format as indicated by @mlautman. How do you usually handle this? Do you inspect changes and discard those similar to these manually?
There was a problem hiding this comment.
ping @davetcoleman
There was a problem hiding this comment.
As just discussed on call, I don't think this was clang-format. If it was, it was using the wrong clang config file OR there's some difference with OSX we don't know about. More likely, this was from your code editor GUI.
|
Rebased code and fixed conflicts, follows from #53 |
|
Have all the concerns been addressed in this PR? |
| * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN | ||
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| *********************************************************************/ |
There was a problem hiding this comment.
As just discussed on call, I don't think this was clang-format. If it was, it was using the wrong clang config file OR there's some difference with OSX we don't know about. More likely, this was from your code editor GUI.
No description provided.