Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing rdf test, merge #1163 and #1168 #1170

Merged
merged 4 commits into from
Apr 7, 2022

Conversation

vatanaksoytezer
Copy link
Contributor

@vatanaksoytezer vatanaksoytezer commented Apr 6, 2022

I think this is the only way to fix the CI, in one single PR. Just want to get this in and unblock everything here.

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1170 (0804c0d) into main (99939d3) will increase coverage by 1.52%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
+ Coverage   59.76%   61.27%   +1.52%     
==========================================
  Files         274      274              
  Lines       24749    24756       +7     
==========================================
+ Hits        14789    15168     +379     
+ Misses       9960     9588     -372     
Impacted Files Coverage Δ
...lanners/ompl/ompl_interface/src/ompl_interface.cpp 0.00% <0.00%> (ø)
..._core/collision_detection/src/collision_common.cpp 50.00% <0.00%> (-50.00%) ⬇️
...e/collision_detection_fcl/src/collision_common.cpp 73.76% <0.00%> (+0.23%) ⬆️
moveit_core/robot_state/src/robot_state.cpp 47.28% <0.00%> (+0.32%) ⬆️
moveit_core/planning_scene/src/planning_scene.cpp 48.84% <0.00%> (+0.59%) ⬆️
moveit_ros/moveit_servo/src/servo_calcs.cpp 67.40% <0.00%> (+2.53%) ⬆️
...or/src/current_state_monitor_middleware_handle.cpp 88.24% <0.00%> (+5.89%) ⬆️
moveit_ros/moveit_servo/src/collision_check.cpp 86.16% <0.00%> (+6.16%) ⬆️
...nning_scene_monitor/src/planning_scene_monitor.cpp 46.50% <0.00%> (+6.57%) ⬆️
moveit_ros/moveit_servo/src/servo.cpp 75.00% <0.00%> (+12.50%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99939d3...0804c0d. Read the comment docs.

@vatanaksoytezer vatanaksoytezer requested review from DLu, JafarAbdi, henningkayser and AndyZe and removed request for DLu April 6, 2022 23:35
Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you please do an interactive rebase to squash it into about 3 commits? I would think:

  1. rename panda controllers
  2. Revert OMPL parameter loading
  3. Comment failing test

Thanks! I can imagine how much work it was to track this all down.

@vatanaksoytezer
Copy link
Contributor Author

LGTM but can you please do an interactive rebase to squash it into about 3 commits? I would think:

Done! @AndyZe Would you like to squash merge this or merge the commits seperately?

@AndyZe
Copy link
Member

AndyZe commented Apr 7, 2022

Separate commits is better 👍

Copy link
Member

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If you don't mind I'll spend 30mins trying to fix the segfault before we merge this

@vatanaksoytezer
Copy link
Contributor Author

LGTM

If you don't mind I'll spend 30mins trying to fix the segfault before we merge this

Sure, I'm happy with that.

@AndyZe
Copy link
Member

AndyZe commented Apr 7, 2022

@henningkayser do you want to squash and merge this or can you keep the individual commits? It is urgently needed to fix CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants