-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable failing rdf test, merge #1163 and #1168 #1170
Disable failing rdf test, merge #1163 and #1168 #1170
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1170 +/- ##
==========================================
+ Coverage 59.76% 61.27% +1.52%
==========================================
Files 274 274
Lines 24749 24756 +7
==========================================
+ Hits 14789 15168 +379
+ Misses 9960 9588 -372
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but can you please do an interactive rebase to squash it into about 3 commits? I would think:
- rename panda controllers
- Revert OMPL parameter loading
- Comment failing test
Thanks! I can imagine how much work it was to track this all down.
b40a74b
to
7c0b270
Compare
Done! @AndyZe Would you like to squash merge this or merge the commits seperately? |
Separate commits is better 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If you don't mind I'll spend 30mins trying to fix the segfault before we merge this
Sure, I'm happy with that. |
@henningkayser do you want to squash and merge this or can you keep the individual commits? It is urgently needed to fix CI. |
I think this is the only way to fix the CI, in one single PR. Just want to get this in and unblock everything here.