Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

candlestick isn't exported as ESM module #2007

Closed
netil opened this issue Mar 26, 2021 · 2 comments
Closed

candlestick isn't exported as ESM module #2007

netil opened this issue Mar 26, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@netil
Copy link
Member

netil commented Mar 26, 2021

Description

'candlestick' module is not exported in v3 release.

@netil netil added the bug label Mar 26, 2021
@netil netil added this to the Patch milestone Mar 26, 2021
@netil netil self-assigned this Mar 26, 2021
netil added a commit to netil/billboard.js that referenced this issue Mar 26, 2021
@netil netil closed this as completed in 1a9b75b Mar 26, 2021
github-actions bot pushed a commit that referenced this issue Mar 26, 2021
## [3.0.1](3.0.0...3.0.1) (2021-03-26)

### Bug Fixes

* **axis:** calculate x axis height correctly for negative tick rotation settings ([fe42e64](fe42e64)), closes [#1994](#1994) [#1995](#1995)
* **candlestick:** fix exporting candlestick module ([1a9b75b](1a9b75b)), closes [#2007](#2007)
* **deploy:** fix deploying gh-pages ([baec455](baec455))
@Nicolas469
Copy link
Contributor

Hi,
I still can't import candlestick from ESM...
The generated index.d.ts file seems to be:

/**
 * Copyright (c) 2017 ~ present NAVER Corp.
 * billboard.js project is licensed under the MIT license
 */
import {bb} from "./bb";

export default bb;
export as namespace bb;
export {
	bb,

	// shapes modules
	area,
	areaLineRange,
	areaSpline,
	areaSplineRange,
	areaStep,
	bar,
	bubble,
	donut,
	gauge,
	line,
	pie,
	radar,
	scatter,
	spline,
	step,

	// interaction modules
	selection,
	subchart,
	zoom
} from "./bb";
export * from "./axis";
export * from "./chart";
export * from "./options";
export * from "./types";

@netil
Copy link
Member Author

netil commented Apr 16, 2021

Hi @Nicolas469, I see.
I'll release the patch for this. thanks for the report.

@netil netil reopened this Apr 16, 2021
@netil netil closed this as completed in 0169990 Apr 16, 2021
netil added a commit that referenced this issue Apr 16, 2021
Add missing candlestick export to type definition

Fix #2007
github-actions bot pushed a commit that referenced this issue Apr 16, 2021
## [3.0.3](3.0.2...3.0.3) (2021-04-16)

### Bug Fixes

* **axis:** Fix axis.x.padding value setting ([a8ec411](a8ec411)), closes [#2038](#2038)
* **axis:** fix handling x padding value ([0a42768](0a42768)), closes [#2038](#2038)
* **candlestick:** fix to set expand state ([1e6a10d](1e6a10d)), closes [#2036](#2036)
* **types:** fix missing candlestick export ([ab778b2](ab778b2)), closes [#2007](#2007)
* **types:** updated bar/candlestick options types ([0a48fd6](0a48fd6)), closes [#2043](#2043)
netil pushed a commit that referenced this issue Apr 16, 2021
## [3.0.3](3.0.2...3.0.3) (2021-04-16)

### Bug Fixes

* **axis:** Fix axis.x.padding value setting ([a8ec411](a8ec411)), closes [#2038](#2038)
* **axis:** fix handling x padding value ([0a42768](0a42768)), closes [#2038](#2038)
* **candlestick:** fix to set expand state ([1e6a10d](1e6a10d)), closes [#2036](#2036)
* **types:** fix missing candlestick export ([ab778b2](ab778b2)), closes [#2007](#2007)
* **types:** updated bar/candlestick options types ([0a48fd6](0a48fd6)), closes [#2043](#2043)
netil added a commit that referenced this issue Apr 19, 2021
Add missing candlestick export to type definition

Fix #2007
netil pushed a commit that referenced this issue Apr 19, 2021
## [3.0.3](3.0.2...3.0.3) (2021-04-16)

### Bug Fixes

* **axis:** Fix axis.x.padding value setting ([a8ec411](a8ec411)), closes [#2038](#2038)
* **axis:** fix handling x padding value ([0a42768](0a42768)), closes [#2038](#2038)
* **candlestick:** fix to set expand state ([1e6a10d](1e6a10d)), closes [#2036](#2036)
* **types:** fix missing candlestick export ([ab778b2](ab778b2)), closes [#2007](#2007)
* **types:** updated bar/candlestick options types ([0a48fd6](0a48fd6)), closes [#2043](#2043)
github-actions bot pushed a commit that referenced this issue Jun 25, 2021
# [3.1.0](3.0.3...3.1.0) (2021-06-25)

### Bug Fixes

* **axis:** Fix axis.x.padding value setting ([5b4b509](5b4b509)), closes [#2038](#2038)
* **axis:** fix handling x padding value ([489d47a](489d47a)), closes [#2038](#2038)
* **candlestick:** fix to set expand state ([a055b20](a055b20)), closes [#2036](#2036)
* **Chart:** Handle nullish properties from API extendings safely ([6cbf64a](6cbf64a)), closes [#2132](#2132) [#2134](#2134)
* **data:** Fix duplicated data.onclick call  ([b4c5dc2](b4c5dc2)), closes [#2104](#2104)
* **data:** Fix nullish data filtering for grouped data ([af19370](af19370)), closes [#2096](#2096)
* **gauge:** Fix incorrect rendering when gauge.min is given ([31fc981](31fc981)), closes [#2123](#2123)
* **point:** Fix custom point for nullish data ([8c198f2](8c198f2)), closes [#2107](#2107)
* **region:** fix region append position ([2b50443](2b50443)), closes [#2067](#2067)
* **size:** enhance applying height value ([0664a60](0664a60)), closes [#2086](#2086)
* **tooltip:** Correct the type of selectedData ([05b694d](05b694d)), closes [#2056](#2056) [#2058](#2058)
* **types:** fix missing candlestick export ([f218939](f218939)), closes [#2007](#2007)
* **types:** updated bar/candlestick options types ([d89c3f3](d89c3f3)), closes [#2043](#2043)
* **zoom:** Fix incorrect tooltip position ([689bfdf](689bfdf)), closes [#2095](#2095)
* **zoom,grid:** fix grid line pos during zoom ([e84a4f1](e84a4f1)), closes [#2156](#2156)

### Features

* **all:** contain inline css prop setting ([fde6a89](fde6a89)), closes [#2076](#2076)
* **api:** Intent to ship append load ([8076795](8076795)), closes [#2140](#2140)
* **data:** Intent to ship data.onshown/onhidden ([af98eb7](af98eb7)), closes [#2146](#2146)
* **data.labels:** Intent to ship data.labels.backgroundColors ([e0b2fed](e0b2fed)), closes [#1954](#1954)
* **subchart:** Intent to ship subchart.init.range option ([967bf1b](967bf1b)), closes [#2037](#2037)
* **subchart:** Intent to ship subchart.showHandle ([219bff3](219bff3)), closes [#2044](#2044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants