Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not being exapanded for candlestick #2036

Closed
netil opened this issue Apr 12, 2021 · 0 comments
Closed

Not being exapanded for candlestick #2036

netil opened this issue Apr 12, 2021 · 0 comments
Assignees
@netil
Labels
bug

Comments

@netil
Copy link
Member

netil commented Apr 12, 2021

Description

When mouseover(or touch) happens, the correspond candlestick shape
it should be expanded(adding _expanded_ class) to indicate current selection.
@netil netil added the bug label Apr 12, 2021
@netil netil self-assigned this Apr 12, 2021
netil added a commit to netil/billboard.js that referenced this issue Apr 13, 2021
@netil
fix(candlestick): fix to set expand state
9f509bd 
- Add expand/unexpand class name during interaction
- Refactor expand/unexpand codes

Ref naver#2036
@netil netil mentioned this issue Apr 13, 2021
Merged
@netil netil closed this as completed in a055b20 Apr 13, 2021
netil added a commit that referenced this issue Apr 16, 2021
@netil
fix(candlestick): fix to set expand state
1e6a10d 
- Add expand/unexpand class name during interaction
- Refactor expand/unexpand codes

Fix #2036
github-actions bot pushed a commit that referenced this issue Apr 16, 2021
@semantic-release-bot
chore(release): 3.0.3 [skip ci]
dd2eecd 
## [3.0.3](3.0.2...3.0.3) (2021-04-16)

### Bug Fixes

* **axis:** Fix axis.x.padding value setting ([a8ec411](a8ec411)), closes [#2038](#2038)
* **axis:** fix handling x padding value ([0a42768](0a42768)), closes [#2038](#2038)
* **candlestick:** fix to set expand state ([1e6a10d](1e6a10d)), closes [#2036](#2036)
* **types:** fix missing candlestick export ([ab778b2](ab778b2)), closes [#2007](#2007)
* **types:** updated bar/candlestick options types ([0a48fd6](0a48fd6)), closes [#2043](#2043)
netil pushed a commit that referenced this issue Apr 16, 2021
@semantic-release-bot @netil
chore(release): 3.0.3 [skip ci]
505f0c2 
## [3.0.3](3.0.2...3.0.3) (2021-04-16)

### Bug Fixes

* **axis:** Fix axis.x.padding value setting ([a8ec411](a8ec411)), closes [#2038](#2038)
* **axis:** fix handling x padding value ([0a42768](0a42768)), closes [#2038](#2038)
* **candlestick:** fix to set expand state ([1e6a10d](1e6a10d)), closes [#2036](#2036)
* **types:** fix missing candlestick export ([ab778b2](ab778b2)), closes [#2007](#2007)
* **types:** updated bar/candlestick options types ([0a48fd6](0a48fd6)), closes [#2043](#2043)
netil pushed a commit that referenced this issue Apr 19, 2021
@semantic-release-bot @netil
chore(release): 3.0.3 [skip ci]
34ae4f9 
## [3.0.3](3.0.2...3.0.3) (2021-04-16)

### Bug Fixes

* **axis:** Fix axis.x.padding value setting ([a8ec411](a8ec411)), closes [#2038](#2038)
* **axis:** fix handling x padding value ([0a42768](0a42768)), closes [#2038](#2038)
* **candlestick:** fix to set expand state ([1e6a10d](1e6a10d)), closes [#2036](#2036)
* **types:** fix missing candlestick export ([ab778b2](ab778b2)), closes [#2007](#2007)
* **types:** updated bar/candlestick options types ([0a48fd6](0a48fd6)), closes [#2043](#2043)
github-actions bot pushed a commit that referenced this issue Jun 25, 2021
@semantic-release-bot
chore(release): 3.1.0 [skip ci]
5f10c03 
# [3.1.0](3.0.3...3.1.0) (2021-06-25)

### Bug Fixes

* **axis:** Fix axis.x.padding value setting ([5b4b509](5b4b509)), closes [#2038](#2038)
* **axis:** fix handling x padding value ([489d47a](489d47a)), closes [#2038](#2038)
* **candlestick:** fix to set expand state ([a055b20](a055b20)), closes [#2036](#2036)
* **Chart:** Handle nullish properties from API extendings safely ([6cbf64a](6cbf64a)), closes [#2132](#2132) [#2134](#2134)
* **data:** Fix duplicated data.onclick call  ([b4c5dc2](b4c5dc2)), closes [#2104](#2104)
* **data:** Fix nullish data filtering for grouped data ([af19370](af19370)), closes [#2096](#2096)
* **gauge:** Fix incorrect rendering when gauge.min is given ([31fc981](31fc981)), closes [#2123](#2123)
* **point:** Fix custom point for nullish data ([8c198f2](8c198f2)), closes [#2107](#2107)
* **region:** fix region append position ([2b50443](2b50443)), closes [#2067](#2067)
* **size:** enhance applying height value ([0664a60](0664a60)), closes [#2086](#2086)
* **tooltip:** Correct the type of selectedData ([05b694d](05b694d)), closes [#2056](#2056) [#2058](#2058)
* **types:** fix missing candlestick export ([f218939](f218939)), closes [#2007](#2007)
* **types:** updated bar/candlestick options types ([d89c3f3](d89c3f3)), closes [#2043](#2043)
* **zoom:** Fix incorrect tooltip position ([689bfdf](689bfdf)), closes [#2095](#2095)
* **zoom,grid:** fix grid line pos during zoom ([e84a4f1](e84a4f1)), closes [#2156](#2156)

### Features

* **all:** contain inline css prop setting ([fde6a89](fde6a89)), closes [#2076](#2076)
* **api:** Intent to ship append load ([8076795](8076795)), closes [#2140](#2140)
* **data:** Intent to ship data.onshown/onhidden ([af98eb7](af98eb7)), closes [#2146](#2146)
* **data.labels:** Intent to ship data.labels.backgroundColors ([e0b2fed](e0b2fed)), closes [#1954](#1954)
* **subchart:** Intent to ship subchart.init.range option ([967bf1b](967bf1b)), closes [#2037](#2037)
* **subchart:** Intent to ship subchart.showHandle ([219bff3](219bff3)), closes [#2044](#2044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@netil