Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add portal languages preference #135

Conversation

syphax-bouazzouni
Copy link

This PL add tests for this goo pull request ncbo/goo#118

@syphax-bouazzouni syphax-bouazzouni force-pushed the pl/add-mainlang-defaults-refactored branch from aa99cc8 to afd464f Compare April 20, 2022 07:28
@syphax-bouazzouni syphax-bouazzouni changed the title Add portal languages preference Feature: add portal languages preference Sep 14, 2022
@alexskr alexskr requested a review from mdorf March 15, 2024 03:52
@alexskr alexskr changed the base branch from master to develop April 25, 2024 18:34
@alexskr
Copy link
Member

alexskr commented May 2, 2024

this PR is not ready, at least the unit tests for multi-lingual support that were added in this PR are not passing
GOO PR#150 is merged on our end.
@syphax-bouazzouni do you know what is missing?

@syphax-bouazzouni syphax-bouazzouni marked this pull request as draft May 2, 2024 15:50
@syphax-bouazzouni
Copy link
Author

syphax-bouazzouni commented May 2, 2024

this PR is not ready, at least the unit tests for multi-lingual support that were added in this PR are not passing GOO PR#150 is merged on our end. @syphax-bouazzouni do you know what is missing?

This PR is obsolete(two years ago) and needs to be updated to work with ncbo/goo#150. Will be done soon (I hope)

The PR that I need to open, will be related to this one in our side ontoportal-lirmm#96

@syphax-bouazzouni
Copy link
Author

replaced with #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants