forked from ontoportal/ontologies_linked_data
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Multilingual Support - Add search and languages serialization #199
Merged
alexskr
merged 7 commits into
ncbo:feature/multilingual-support-add-search-and-languages-serialization
from
ontoportal-lirmm:pr/sync-agroportal-ncbo
May 8, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #199 +/- ##
===========================================
- Coverage 80.80% 78.10% -2.71%
===========================================
Files 63 74 +11
Lines 4907 5370 +463
===========================================
+ Hits 3965 4194 +229
- Misses 942 1176 +234
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
syphax-bouazzouni
force-pushed
the
pr/sync-agroportal-ncbo
branch
from
May 6, 2024 11:55
f70abe9
to
fc48343
Compare
This was referenced May 6, 2024
syphax-bouazzouni
changed the title
Feature: Multilingual Support
Feature: Multilingual Support - Add search and languages serialization
May 6, 2024
alexskr
changed the base branch from
develop
to
Feature/multilingual_support_add_search_and_languages_serialization
May 8, 2024 01:20
alexskr
changed the base branch from
Feature/multilingual_support_add_search_and_languages_serialization
to
feature/multilingual-support-add-search-and-languages-serialization
May 8, 2024 03:57
alexskr
merged commit May 8, 2024
f6764a8
into
ncbo:feature/multilingual-support-add-search-and-languages-serialization
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require
Context
This PR, implements mostly two things:
requested_lang
, see details and example here: Feature: Support multilingual - Add read multiple language ontoportal-lirmm/goo#32See the added units tests, for examples.
Changes
:all
and some code cleaning (see details in Feature: add the serialize_defaults to the attributes to load if set include = 'all' #145 )(37f74d3)