Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Makefile to build commands #348

Closed
hoangmirs opened this issue Jul 27, 2022 · 1 comment · Fixed by #359
Closed

Add Makefile to build commands #348

hoangmirs opened this issue Jul 27, 2022 · 1 comment · Fixed by #359
Assignees
@tyrro
Labels
type : feature

Comments

@hoangmirs
Copy link
Contributor

Why

  • Makefile helps us to build commands easily. Other templates are using it: gin-templates, elixir-templates
  • With Makefile, we can build some basic commands e.g. install-dependencies, env-setup, dev, test so that we don't need to remember some commands in /bin folder. And it will be consistent with other templates as well.

Who Benefits?

Rails developers
@malparty
Copy link
Member

💯
Can we also update the Getting Started wiki page accordingly, so that we do not need to fix the current issue of "Run bundle install first` — it occurs when following exactly the indicated steps:

image

@tyrro tyrro self-assigned this Aug 1, 2022
tyrro added a commit that referenced this issue Sep 9, 2022
@tyrro
[#348] feature: Add Makefile to build commands
c99fc4b
@tyrro tyrro mentioned this issue Sep 9, 2022
Merged
@malparty malparty added this to the 5.3.0 milestone Sep 9, 2022
tyrro added a commit that referenced this issue Sep 9, 2022
@tyrro
[#348] feature: Add Makefile to build commands
a8a46e6
tyrro added a commit that referenced this issue Sep 9, 2022
@tyrro
[#348] feature: Add Makefile to build commands
ad80f2e
@malparty malparty removed this from the 5.3.0 milestone Feb 2, 2023
tyrro added a commit that referenced this issue Mar 30, 2023
@tyrro
[#348] feature: Add Makefile to build commands
daa0f94
tyrro added a commit that referenced this issue Mar 30, 2023
@tyrro
[#348] feat: Update template according to the addition of Makefile
eb51f41
tyrro added a commit that referenced this issue Mar 30, 2023
@tyrro
[#348] feat: Update template according to the addition of Makefile
dc93d09
tyrro added a commit that referenced this issue Apr 7, 2023
@tyrro
[#348] chore: Remove DB related rake tasks from Makefile
c4aeed2
tyrro added a commit that referenced this issue Apr 11, 2023
@tyrro
[#348] chore: Remove test related make commands
7da2972
tyrro added a commit that referenced this issue Apr 11, 2023
@tyrro
[#348] chore: Update README.md.tt
feb0cbc
malparty added a commit that referenced this issue Apr 24, 2023
@malparty
Merge pull request #359 from nimblehq/feature/gh-348-add-makefile-to-…
b913280 
…build-commands

[#348] Add Makefile to build commands
@malparty malparty mentioned this issue Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyrro tyrro

Labels
type : feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#348] Add Makefile to build commands nimblehq/rails-templates
3 participants
@hoangmirs @tyrro @malparty