Release 5.6.0 #415
Release 5.6.0 #415
Conversation
…build-commands [#348] Add Makefile to build commands
[#404] Fix: Loaderror: cannot load such file -- sassc when generating the project from the template
Co-authored-by: Xavier MALPARTY <[email protected]>
[gh384] Add PostCSS autoprefixer
[gh385] Minify the CSS and JS for production build
…15.2 [#409] Upgrate Postges to 15.2
malparty
requested review from
bterone,
byhbt,
carryall,
hoangmirs,
longnd,
tyrro and
sanG-github
as code owners
|
The PR title should be |
| @@ -9,6 +9,7 @@ gem 'mini_magick' # A ruby wrapper for ImageMagick or GraphicsMagick command lin | |||
| gem 'pagy' # A pagination gem that is very light and fast | |||
| gem 'discard' # Soft deletes for ActiveRecord | |||
| gem 'sidekiq' # background processing for Ruby | |||
| gem 'sassc' # bootsnap dependency | |||
There was a problem hiding this comment.
I'm sorry about this comment, which is a bit late but I'm not sure about this gem, it's an old gem (last update was 2020) and I remember SASS in C was deprecated, the SASS team moved to the DartSass already, and we don't use this gem in the generated project at all....
Maybe this gem is needed during generating the new project, but later on we don't use it, should we remove it at the end? with a post setup callback? cc @sanG-github
There was a problem hiding this comment.
I agree with the above statement, but it would be best to move this concern into an issue to address it in the next release.
There was a problem hiding this comment.
That's appropriate, but as far as I remember, we still need it to run the project, not only generating it.
In that case, I think we need to use another alternative. (Note that this one was caused by the bootsnap gem)
There was a problem hiding this comment.
Maybe a solution is just creating a new issue to remove this gem :D so all good with this release cc @malparty
There was a problem hiding this comment.
This is the actual bug fix that prevented to use the Template :harold:
yes, I'll create an issue 🙇
@5.6.0
Features
Bugs
Loaderror: cannot load such file -- sasscwhen generating the project from the template #404] Fix: Loaderror: cannot load such file -- sassc when generating the project from the template by @sanG-github in [#404] Fix: Loaderror: cannot load such file -- sassc when generating the project from the template #406New Contributors
Full Changelog: 5.5.0...5.6.0