Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#348] Add Makefile to build commands #359

Merged
merged 6 commits into from
Apr 24, 2023
Merged

[#348] Add Makefile to build commands #359

merged 6 commits into from
Apr 24, 2023

Conversation

tyrro
Copy link
Contributor

@tyrro tyrro commented Sep 9, 2022 •
edited
Loading

What happened 👀

  • A Makefile is added to simplify app setup and runs.
  • Rubocop MaxLineLength is updated from 120 to 130 to comply with the Compass convention

Insight 📝

The following commands can be run through the Makefile:

  • make env/setup
  • make env/teardown
  • make dev
  • make install_dependencies
  • make codebase
  • make codebase/fix

Proof Of Work 📹

  • A new template is created from this branch:
rails new test-rails-template -m /Users/nimble/Documents/Office/Nimble/rails-templates/template.rb
resulting in a new `Makefile` in the created project: Screen Shot 2023-04-07 at 5 24 00 PM
  • make dev running smoothly
Output of `make dev` command: Screen Shot 2023-04-07 at 5 20 57 PM

@tyrro tyrro force-pushed the feature/gh-348-add-makefile-to-build-commands branch 2 times, most recently from a8a46e6 to ad80f2e Compare September 9, 2022 09:14
@malparty
Copy link
Member

malparty commented Oct 4, 2022

@tyrro do you have plan to complete this PR? If yes, may you let me know when? :) Thanks!

@malparty malparty added this to the 5.4.0 milestone Feb 2, 2023
@malparty malparty removed this from the 5.4.0 milestone Mar 14, 2023
@tyrro tyrro force-pushed the feature/gh-348-add-makefile-to-build-commands branch 2 times, most recently from 84d2c64 to 05d6c2f Compare March 30, 2023 10:47
@tyrro tyrro force-pushed the feature/gh-348-add-makefile-to-build-commands branch from f51cf89 to dc93d09 Compare March 30, 2023 10:57
@tyrro
Copy link
Contributor Author

tyrro commented Mar 30, 2023

@tyrro do you have plan to complete this PR? If yes, may you let me know when? :) Thanks!

It's a bit late but it's ready for review now, Thanks 😅

@tyrro tyrro marked this pull request as ready for review March 30, 2023 11:01
malparty
malparty reviewed Apr 4, 2023
View reviewed changes
Makefile.tt Outdated Show resolved Hide resolved
malparty
malparty reviewed Apr 4, 2023
View reviewed changes
Makefile.tt Outdated Show resolved Hide resolved
malparty
malparty requested changes Apr 4, 2023
View reviewed changes
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an open question :)
I tested this branch of the template locally and it is working as expected 🚀

@malparty malparty added this to the 5.5.0 milestone Apr 7, 2023
andyduong1920
andyduong1920 reviewed Apr 7, 2023
View reviewed changes
Makefile.tt Outdated Show resolved Hide resolved
@tyrro tyrro force-pushed the feature/gh-348-add-makefile-to-build-commands branch from 6f115c5 to c4aeed2 Compare April 7, 2023 10:11
@tyrro tyrro requested a review from malparty April 7, 2023 10:49
@malparty malparty modified the milestones: 5.5.0, 5.6.0 Apr 13, 2023
@malparty malparty merged commit b913280 into develop Apr 24, 2023
@malparty malparty deleted the feature/gh-348-add-makefile-to-build-commands branch April 24, 2023 08:36
@malparty malparty mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malparty malparty malparty approved these changes

@andyduong1920 andyduong1920 andyduong1920 approved these changes

@rosle rosle Awaiting requested review from rosle

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@carryall carryall Awaiting requested review from carryall carryall is a code owner

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs is a code owner

@longnd longnd Awaiting requested review from longnd longnd is a code owner

@sanG-github sanG-github Awaiting requested review from sanG-github sanG-github is a code owner

Assignees

@tyrro tyrro

Labels
type : feature
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.

Add Makefile to build commands
3 participants
@tyrro @malparty @andyduong1920