Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v22.4.0 release proposal #53583

Merged
merged 102 commits into from
Jul 2, 2024
Merged

v22.4.0 release proposal #53583

merged 102 commits into from
Jul 2, 2024

Commits on Jun 20, 2024

  1. doc: remove IRC from man page

    PR-URL: #53344
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    tniessen authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    6e12d9f View commit details
    Browse the repository at this point in the history
  2. doc: mark --cpu-prof and related flags stable

    PR-URL: #53343
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Ruy Adorno <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    joyeecheung authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    0160745 View commit details
    Browse the repository at this point in the history
  3. doc: mark --heap-prof and related flags stable

    PR-URL: #53343
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Ruy Adorno <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    joyeecheung authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    cf375e7 View commit details
    Browse the repository at this point in the history
  4. lib: fix timer leak

    PR-URL: #53337
    Fixes: #53335
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Feng Yu <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    theanarkh authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    515dd24 View commit details
    Browse the repository at this point in the history
  5. doc: doc-only deprecate OpenSSL engine-based APIs

    OpenSSL 3 deprecated support for custom engines with a recommendation
    to switch to its new provider model.
    
    PR-URL: #53329
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    richardlau authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    df47627 View commit details
    Browse the repository at this point in the history
  6. doc: mark WebSocket as stable

    PR-URL: #53352
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    KhafraDev authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    16c0884 View commit details
    Browse the repository at this point in the history
  7. tools: add stream label on PR when related files being changed in lib

    PR-URL: #53269
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    jakecastelli authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    855eb25 View commit details
    Browse the repository at this point in the history
  8. doc: fix mistakes in the module load hook api

    PR-URL: #53349
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    isti115 authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    48f78cd View commit details
    Browse the repository at this point in the history
  9. doc: remove mentions of policy model from security info

    PR-URL: #53249
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    RedYetiDev authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    923d24b View commit details
    Browse the repository at this point in the history
  10. build: fix spacing before NINJA_ARGS

    PR-URL: #53181
    Fixes: #53176
    Refs: #53176
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    jakecastelli authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    36aad8b View commit details
    Browse the repository at this point in the history
  11. stream: prevent stream unexpected pause when highWaterMark set to 0

    Co-authored-by: Robert Nagy <[email protected]>
    PR-URL: #53261
    Fixes: #51930
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    2 people authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7dde375 View commit details
    Browse the repository at this point in the history
  12. doc: define more cases for stream event emissions

    PR-URL: #53317
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    RedYetiDev authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    d9182d0 View commit details
    Browse the repository at this point in the history
  13. doc, meta: use markdown rather than HTML in CONTRIBUTING.md

    PR-URL: #53235
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    RedYetiDev authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    cf5a973 View commit details
    Browse the repository at this point in the history
  14. meta: bump step-security/harden-runner from 2.7.1 to 2.8.0

    Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.7.1 to 2.8.0.
    - [Release notes](https://github.com/step-security/harden-runner/releases)
    - [Commits](step-security/harden-runner@a4aa98b...f086349)
    
    ---
    updated-dependencies:
    - dependency-name: step-security/harden-runner
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #53245
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    dependabot[bot] authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    0b9191d View commit details
    Browse the repository at this point in the history
  15. test: update TLS tests for OpenSSL 3.2

    Update the following TLS tests to account for error code changes
    in OpenSSL 3.2 and later.
    - `parallel/test-tls-empty-sni-context`
    - `parallel/test-tls-psk-circuit`
    
    PR-URL: #53384
    Refs: #53382
    Refs: openssl/openssl#19950
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    richardlau authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7349edb View commit details
    Browse the repository at this point in the history
  16. tools: use Ubuntu 24.04 and Clang on GitHub actions

    This puts us closer to what V8 actively supports.
    GCC is still covered a lot by Jenkins CI.
    
    Co-authored-by: Moshe Atlow <[email protected]>
    PR-URL: #53212
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    targos and MoLow committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    78a9037 View commit details
    Browse the repository at this point in the history
  17. test: fix test-http-server-keepalive-req-gc

    This changes adds a second explicit gc call in the test. Without this
    call, the test relies on gc eventually happening based, since the
    first call doesn't free the object.
    Relying on gc to eventually happen prevents changing GC heuristics
    unrelated to this test.
    The gc call is async; otherwise doing multiple sync GCs doesn't free
    the object.
    
    PR-URL: #53292
    Reviewed-By: Luigi Pinca <[email protected]>
    Etienne Pierre-doray authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    4a3525b View commit details
    Browse the repository at this point in the history
  18. stream: make sure _destroy is called

    PR-URL: #53213
    Fixes: #51987
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    jakecastelli authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    f4efb7f View commit details
    Browse the repository at this point in the history
  19. lib: fix naming convention of Symbol

    `node.js` prefix is used for global symbol(`Symbol.for`).
    So remove `node.js` prefix from `Symbol` usage.
    
    Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
    PR-URL: #53387
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    deokjinkim authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    45b59e5 View commit details
    Browse the repository at this point in the history
  20. test: update tests for OpenSSL 3.0.14

    Starting from OpenSSL 3.0.14, 3.1.6, 3.2.2, and 3.3.1, OpenSSL was fixed
    to return an error reason string for bad/unknown application protocols.
    
    Update tests to handle both the old `ECONNRESET` error on older versions
    of OpenSSL and the new `ERR_SSL_TLSV1_ALERT_NO_APPLICATION_PROTOCOL` on
    newer versions of OpenSSL.
    
    Refs: openssl/openssl#24338
    PR-URL: #53373
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    richardlau authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    602b9d6 View commit details
    Browse the repository at this point in the history
  21. src: fix permission inspector crash

    PR-URL: #53389
    Fixes: #53385
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Kohei Ueno <[email protected]>
    theanarkh authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    63f62d7 View commit details
    Browse the repository at this point in the history
  22. crypto: improve GetECGroupBits signature

    Remove the unused ECPointer argument and rename the function since the
    current name is misleading.
    
    PR-URL: #53364
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    tniessen authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    82092cd View commit details
    Browse the repository at this point in the history
  23. doc: fix typo

    PR-URL: #53397
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    ehsankhfr authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    fa113b8 View commit details
    Browse the repository at this point in the history
  24. tools: move ESLint tools to tools/eslint

    With ESLint flat config, we don't need a hack with `node_modules`
    anymore to load ESLint plugins.
    This commit moves the node-core plugin out of `tools/node_modules` and
    creates a new `tools/eslint` directory to store ESLint tools.
    
    PR-URL: #53393
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    ab20214 View commit details
    Browse the repository at this point in the history
  25. doc, http: add rejectNonStandardBodyWrites option, clear its behaviour

    PR-URL: #53396
    Fixes: #53035
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    jakecastelli authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    24c7a94 View commit details
    Browse the repository at this point in the history
  26. build: find version of Clang installed on Windows

    PR-URL: #53228
    Refs: #52809
    Reviewed-By: Michaël Zasso <[email protected]>
    StefanStojanovic authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    c7d44ba View commit details
    Browse the repository at this point in the history
  27. tools: do not run Corepack code before it's reviewed

    Also enable running `make corepack-update` when `node`/`npm` is not
    available globally.
    
    PR-URL: #53405
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    9ece63d View commit details
    Browse the repository at this point in the history
  28. src: fix IsIPAddress for IPv6

    Fix the bug when copying IPv6 host to a variable to remove brackets.
    
    Fixes: #47427
    PR-URL: #53400
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    huseyinacacak-janea authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    4704270 View commit details
    Browse the repository at this point in the history
  29. src: print v8::OOMDetails::detail when it's available

    This provides a bit more information when V8 runs out of memory.
    
    PR-URL: #53360
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    joyeecheung authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    f9075ff View commit details
    Browse the repository at this point in the history
  30. deps: V8: cherry-pick 6ea594ff7132

    Original commit message:
    
        [riscv] Skip check sv57 when enable pointer compress
    
        Change-Id: I4332d3849d113af105630c0e20cd2b5e3deb9392
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5430889
        Commit-Queue: Ji Qiu <[email protected]>
        Reviewed-by: Ji Qiu <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#93244}
    
    Refs: v8/v8@6ea594f
    PR-URL: #53412
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    kxxt authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2defaaf View commit details
    Browse the repository at this point in the history
  31. deps: V8: cherry-pick a3cc8522a4c8

    Original commit message:
    
        [riscv] avoid cpu probing in li_ptr
    
        CPU probing is an expensive thing to do and we should avoid doing it upon every li_ptr call.
    
        Fixes performance regresion bisected in riscv-forks/electron#1
    
        Change-Id: Ib5ff89b2a730e08de6735123ae60adeffe811ed8
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5612950
        Commit-Queue: Yahan Lu <[email protected]>
        Reviewed-by: Yahan Lu <[email protected]>
        Reviewed-by: Michael Lippautz <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#94349}
    
    Refs: v8/v8@a3cc852
    PR-URL: #53412
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    kxxt authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    bd68888 View commit details
    Browse the repository at this point in the history
  32. tools: update lint-md-dependencies

    - @rollup/[email protected]
    - [email protected]
    
    PR-URL: #53158
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8eb7bdf View commit details
    Browse the repository at this point in the history
  33. tools: fix c-ares update script

    PR-URL: #53414
    Fixes: #53407
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    marco-ippolito authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    fe85e05 View commit details
    Browse the repository at this point in the history
  34. deps: update c-ares to v1.30.0

    PR-URL: #53416
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    nodejs-github-bot authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    bf891bf View commit details
    Browse the repository at this point in the history
  35. src: remove ArrayBufferAllocator::Reallocate override

    It's being deprecated and removed in V8.
    
    PR-URL: #52910
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    syg authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    599e7c3 View commit details
    Browse the repository at this point in the history
  36. doc: add initial text for ambassadors program

    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #52857
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    mhdawson authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    ec5364f View commit details
    Browse the repository at this point in the history
  37. tls: use SSL_get_peer_tmp_key

    Both OpenSSL 1.1.1 and 3.x support SSL_get_peer_tmp_key as a replacement
    for SSL_get_server_tmp_key. While the old function name still exists as
    an alias, it does not accurately reflect the function's behavior
    (anymore). Hence, use the new function name here.
    
    PR-URL: #53366
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Tim Perry <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    tniessen authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    ac8adeb View commit details
    Browse the repository at this point in the history
  38. src: avoid strcmp in favor of operator==

    PR-URL: #53439
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    tniessen authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7d87877 View commit details
    Browse the repository at this point in the history
  39. lib: reduce amount of caught URL errors

    PR-URL: #52658
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Daniel Lemire <[email protected]>
    anonrig authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    710cf77 View commit details
    Browse the repository at this point in the history
  40. deps: update zlib to 1.3.0.1-motley-209717d

    PR-URL: #53156
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    nodejs-github-bot authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7a7f438 View commit details
    Browse the repository at this point in the history
  41. src: fix typo in env.cc

    PR-URL: #53418
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Kohei Ueno <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    ehsankhfr authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    955454b View commit details
    Browse the repository at this point in the history
  42. src: return non-empty data in context data serializer

    For pointer values in the context data, we need to return
    non-empty data in the serializer so that V8 does not
    serialize them verbatim, making the snapshot unreproducible.
    
    PR-URL: #50983
    Refs: nodejs/build#3043
    Reviewed-By: Daniel Lemire <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    joyeecheung authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    bfc5236 View commit details
    Browse the repository at this point in the history
  43. src: make sure that memcpy-ed structs in snapshot have no padding

    To make the snapshots reproducible, this patch updates the size
    of a few types and adds some static assertions to ensure that
    there are no padding in the memcpy-ed structs.
    
    PR-URL: #50983
    Refs: nodejs/build#3043
    Reviewed-By: Daniel Lemire <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    joyeecheung authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    004b9ea View commit details
    Browse the repository at this point in the history
  44. src: add utilities to help debugging reproducibility of snapshots

    - Print offsets in blob serializer
    - Add a special node:generate_default_snapshot ID to generate
      the built-in snapshot.
    - Improve logging
    - Add a test to check the reproducibilty of the snapshot
    
    PR-URL: #50983
    Refs: nodejs/build#3043
    Reviewed-By: Daniel Lemire <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    joyeecheung authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    f077afa View commit details
    Browse the repository at this point in the history
  45. doc: add Buffer.from(string) to functions that use buffer pool

    Buffer.from(string) is one of the functions that may use the
    pre-allocated buffer. It's mentioned in the description of
    Buffer.from(array), but not in Buffer.from(string), or in the two other
    places where functions that behave this way are listed, so this commit
    adds those references.
    
    PR-URL: #52801
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Whitecx authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    46a7681 View commit details
    Browse the repository at this point in the history
  46. doc: move node --run stability to rc

    PR-URL: #53433
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Xuguang Mei <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    anonrig authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2012667 View commit details
    Browse the repository at this point in the history
  47. tls: avoid taking ownership of OpenSSL objects

    It is often unnecessary to obtain (shared) ownership of OpenSSL objects
    in this code, and it generally is more costly to do so as opposed to
    just obtaining a pointer to the respective OpenSSL object. Therefore,
    this patch replaces various OpenSSL function calls that take ownership
    with ones that do not.
    
    PR-URL: #53436
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    tniessen authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    4b47f89 View commit details
    Browse the repository at this point in the history
  48. stream: callback should be called when pendingcb is 0

    Fixes: #46170
    PR-URL: #53438
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    jakecastelli authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    b3372a8 View commit details
    Browse the repository at this point in the history
  49. src: simplify size() == 0 checks

    PR-URL: #53440
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    anonrig authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    0c7e69a View commit details
    Browse the repository at this point in the history
  50. src: remove SetEncoding from StringEncoder

    PR-URL: #53441
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Daniel Lemire <[email protected]>
    anonrig authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    11dd15c View commit details
    Browse the repository at this point in the history
  51. src: remove base64 from process.versions

    The `base64` dependency was previously removed along with the update
    script (`tools/dep_updaters/update-base64.sh`) but the generated header,
    `src/base64_version.h` was left behind and `process.versions` was still
    listing the last version of `base64` that was included in Node.js before
    it was removed
    
    Refs: #52714
    PR-URL: #53442
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    richardlau authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    5961253 View commit details
    Browse the repository at this point in the history
  52. stream: support dispose in writable

    Add support to Symbol.asyncDispose in writable streams.
    Additionally add a test for writable, transform and duplex streams
    who inherit from readable/writable to avoid breakage.
    
    Co-authored-by: Robert Nagy <[email protected]>
    Co-authored-by: atlowChemi <[email protected]>
    PR-URL: #48547
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    3 people authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    eded1e9 View commit details
    Browse the repository at this point in the history
  53. lib: speed up MessageEvent creation internally

    PR-URL: #52951
    Refs: nodejs/undici#3170
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    KhafraDev authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    452011b View commit details
    Browse the repository at this point in the history
  54. fs: add fast api for InternalModuleStat

    PR-URL: #51344
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Franziska Hinkelmann <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    anonrig authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    fad1793 View commit details
    Browse the repository at this point in the history
  55. buffer: make indexOf(byte) faster

    Add a V8 fast API implementation for indexOfNumber, which significantly
    improves the performance of finding a single byte within a buffer.
    
    Refs: #52993
    PR-URL: #53455
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    tniessen authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    dfdc062 View commit details
    Browse the repository at this point in the history
  56. tls: check result of SSL_CTX_set_*_proto_version

    These functions generally should not fail, but we also shouldn't ignore
    potential failures entirely since security properties of the application
    might depend on successful configuration.
    
    This also is consistent with the existing CHECKs in SetMinProto() and
    SetMaxProto().
    
    PR-URL: #53459
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    tniessen authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    a11a057 View commit details
    Browse the repository at this point in the history
  57. doc: remove first timer badge

    PR-URL: #53338
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Qingyu Deng <[email protected]>
    RedYetiDev authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    5ed1a03 View commit details
    Browse the repository at this point in the history
  58. assert,util: correct comparison when both contain same reference

    Co-authored-by: Chris Harvey <[email protected]>
    PR-URL: #53431
    Refs: #53423
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    2 people authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    9f32002 View commit details
    Browse the repository at this point in the history
  59. fs: do not crash if the watched file is removed while setting up watch

    Signed-off-by: Matteo Collina <[email protected]>
    PR-URL: #53452
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    mcollina authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    568377f View commit details
    Browse the repository at this point in the history
  60. lib: remove the unused code

    PR-URL: #53463
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    theanarkh authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    123910f View commit details
    Browse the repository at this point in the history
  61. deps: update acorn-walk to 8.3.3

    PR-URL: #53466
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    6acadeb View commit details
    Browse the repository at this point in the history
  62. deps: patch V8 to 12.4.254.21

    Refs: v8/v8@12.4.254.20...12.4.254.21
    PR-URL: #53470
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    1b84964 View commit details
    Browse the repository at this point in the history
  63. deps: update simdjson to 3.9.4

    PR-URL: #53467
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    nodejs-github-bot authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    1877f22 View commit details
    Browse the repository at this point in the history
  64. src: fix dynamically linked OpenSSL version

    Report the version of OpenSSL that Node.js is running with instead
    of the version of OpenSSL that Node.js was compiled against.
    
    PR-URL: #53456
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    richardlau authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    e16a04e View commit details
    Browse the repository at this point in the history
  65. test: check against run-time OpenSSL version

    Update `common.hasOpenSSL3*` to check against the run-time version of
    OpenSSL instead of the version of OpenSSL that Node.js was compiled
    against.
    
    Add a generalized `common.hasOpenSSL()` so we do not need to keep adding
    new checks for each new major/minor of OpenSSL.
    
    PR-URL: #53456
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    richardlau authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    513e6aa View commit details
    Browse the repository at this point in the history
  66. meta: fix typo in dependency updates

    PR-URL: #53471
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Akhil Marsonya <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tierney Cyren <[email protected]>
    RedYetiDev authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    a502638 View commit details
    Browse the repository at this point in the history
  67. test: update url web-platform tests

    PR-URL: #53472
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    anonrig authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    d2c169a View commit details
    Browse the repository at this point in the history
  68. inspector: fix disable async hooks on Debugger.setAsyncCallStackDepth

    This was previously calling the enable function by mistake. As a
    result, when profiling using Chrome DevTools, the async hooks won't
    be turned off properly after receiving Debugger.setAsyncCallStackDepth
    with depth 0.
    
    PR-URL: #53473
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    joyeecheung authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    ad5282e View commit details
    Browse the repository at this point in the history
  69. test: update encoding web-platform tests

    PR-URL: #53477
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    anonrig authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    b8f436c View commit details
    Browse the repository at this point in the history
  70. test: update compression web-platform tests

    PR-URL: #53478
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Tierney Cyren <[email protected]>
    anonrig authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    bcad560 View commit details
    Browse the repository at this point in the history
  71. deps: update undici to 6.19.0

    PR-URL: #53468
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    nodejs-github-bot authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    0b40bfa View commit details
    Browse the repository at this point in the history
  72. deps: update undici to 6.19.1

    PR-URL: #53468
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    nodejs-github-bot authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    fa34f8f View commit details
    Browse the repository at this point in the history
  73. deps: update undici to 6.19.1

    PR-URL: #53468
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    nodejs-github-bot authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    c4a7e05 View commit details
    Browse the repository at this point in the history
  74. deps: update undici to 6.19.2

    PR-URL: #53468
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    nodejs-github-bot authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    e69b8d2 View commit details
    Browse the repository at this point in the history
  75. meta: move one or more collaborators to emeritus

    PR-URL: #53480
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    d1c10fe View commit details
    Browse the repository at this point in the history
  76. doc: update the description of the return type for options.filter

    PR-URL: #52742
    Refs: #52461
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    kylo5aby authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    befabe5 View commit details
    Browse the repository at this point in the history
  77. util: support --no- for argument with boolean type for parseArgs

    PR-URL: #53107
    Refs: #53095
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    kylo5aby authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    50733a1 View commit details
    Browse the repository at this point in the history
  78. doc: only apply content-visibility on all.html

    Refs: #40099
    PR-URL: #53510
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Claudio Wunder <[email protected]>
    panva authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    a5852cc View commit details
    Browse the repository at this point in the history
  79. tools: move ESLint to tools/eslint

    Greatly simplify how ESLint and its plugins are installed.
    
    PR-URL: #53413
    Reviewed-By: Antoine du Hamel <[email protected]>
    targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    30fdd48 View commit details
    Browse the repository at this point in the history
  80. fs: move ToNamespacedPath to c++

    Co-Authored-By: Daniel Lemire <[email protected]>
    PR-URL: #52135
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Daniel Lemire <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    2 people authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    105b006 View commit details
    Browse the repository at this point in the history
  81. stream: update outdated highwatermark doc

    PR-URL: #53494
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    jsk95 authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8b87709 View commit details
    Browse the repository at this point in the history
  82. deps,lib,src: add experimental web storage

    This commit introduces an experimental implementation of the Web
    Storage API using SQLite as the backing data store.
    
    PR-URL: #52435
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Ethan Arrowood <[email protected]>
    cjihrig authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    9e30724 View commit details
    Browse the repository at this point in the history
  83. deps: sqlite: fix Windows compilation

    This is equivalent to the following upstream change:
    https://sqlite.org/src/info/6c103aee6f146869
    
    Original commit message:
    
        Change constant expressions to pre-computed constants, because apparently
        MSVC on ARM requires that.
        [forum:/forumpost/4feb1685cced0a8e|Forum thread 4feb1685cced0a8e].
    
        FossilOrigin-Name: 6c103aee6f146869a3e0c48694592f2e4c6b57ecdb4450f46e762c38b4e686f1
    
    PR-URL: #52435
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Ethan Arrowood <[email protected]>
    cjihrig authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    977beab View commit details
    Browse the repository at this point in the history
  84. src: use args.This() instead of Holder

    The latter is deprecated in V8.
    
    Refs: http://crbug.com/333672197
    PR-URL: #53474
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    15df4ed View commit details
    Browse the repository at this point in the history
  85. http2: reject failed http2.connect when used with promisify

    PR-URL: #53475
    Reviewed-By: Tim Perry <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    ehsankhfr authored and targos committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    41100b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. meta: use correct source for workflow in PR

    PR-URL: #53490
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    RedYetiDev authored and targos committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7716613 View commit details
    Browse the repository at this point in the history
  2. doc: add additional guidance for PRs to deps

    - add additional guidance based in discussion related
      to recent PR to dependency and discussion within the
      security-wg slack channel.
    
    Refs: nodejs/security-wg#1329
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #53499
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    mhdawson authored and targos committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    30858ec View commit details
    Browse the repository at this point in the history
  3. src: reset process.versions during pre-execution

    Reset `process.versions` during pre-execution so that it reflects
    the versions at run-time rather than when the snapshot was taken.
    
    PR-URL: #53444
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    richardlau authored and targos committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    49cfb9d View commit details
    Browse the repository at this point in the history
  4. lib: add diagnostics_channel events to module loading

    This commit adds a tracing channel for module loading
    through `import()` and `require()`.
    
    Co-Authored-By: Stephen Belanger <[email protected]>
    PR-URL: #44340
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Santiago Gimeno <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Gerhard Stöbich <[email protected]>
    2 people authored and targos committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    e95af74 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. src, deps: add nbytes library

    Projects that seek to implement Node.js compatible APIs end up
    needed to reproduce various bits of functionality internally in
    order to faithfully replicate the Node.js behaviors. This is
    particularly true for things like byte manipulation, base64 and
    hex encoding, and other low-level operations. This change
    proposes moving much of this low-level byte manipulation code
    out of nodejs/src and into a new `nbytes` library. Initially this
    new library will exist in the `deps` directory but the intent is
    to spin out a new separate repository to be its home in the future.
    Doing so will allow other projects to use the nbytes library with
    exactly the same implementation as Node.js.
    
    This commit moves only the byte swapping and legacy base64 handling
    code. Additional commits will move additional byte manipulation
    logic into the library.
    
    PR-URL: #53507
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    jasnell authored and targos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    70bbc02 View commit details
    Browse the repository at this point in the history
  2. tools: update eslint to 9.5.0

    PR-URL: #53515
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    nodejs-github-bot authored and targos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ca198f4 View commit details
    Browse the repository at this point in the history
  3. lib: fix typo in comment

    Small update in a realm.js documentation comment to correct `js2c.py`
    which was ported to `js2c.cc` and removed.
    
    PR-URL: #53543
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Ethan Arrowood <[email protected]>
    codediverdev authored and targos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b5fc227 View commit details
    Browse the repository at this point in the history
  4. doc, meta: organize contributing to Node-API guide

    PR-URL: #53243
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    RedYetiDev authored and targos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ec38f3d View commit details
    Browse the repository at this point in the history
  5. build: configure with shared sqlite3

    PR-URL: #53519
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    legendecas authored and targos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1de4375 View commit details
    Browse the repository at this point in the history
  6. test: extend env for test-node-output-errors

    Extend, rather than replace, `env` for `test-node-output-errors` so
    that `node` binaries that need `LD_LIBRARY_PATH`, `LIBPATH` or
    `DYLD_LIBRARY_PATH` can run.
    
    PR-URL: #53535
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    richardlau authored and targos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    91b2850 View commit details
    Browse the repository at this point in the history
  7. tools: fix skip detection of test runner output

    Fix the Python test harness so that it no longer treats the `# skipped`
    part of the summary at the end of the built-in test runner output as
    marking the test as skipped.
    
    PR-URL: #53545
    Fixes: #50346
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    richardlau authored and targos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    71321bb View commit details
    Browse the repository at this point in the history
  8. tools: lock versions of irrelevant DB deps

    `caniuse-lite` and `electron-to-chromium` are "database dependencies"
    that we don't care about and are often updated, increasing the size of
    the repository each time. Lock their versions to the currently
    installed one so it doesn't happen in the future.
    
    PR-URL: #53546
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    targos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d5c380b View commit details
    Browse the repository at this point in the history
  9. doc: recommend not using libuv node-api function

    - update documentation recommend not using the
      napi_get_uv_event_loop  function. It should not be
      need for most if not all uses cases now that the
      API is more complete.
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #53521
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    mhdawson authored and targos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    608cc05 View commit details
    Browse the repository at this point in the history
  10. deps: update c-ares to v1.31.0

    PR-URL: #53554
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    073c231 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. test: skip reproducible snapshot test on 32-bit

    Refs: #53583 (comment)
    PR-URL: #53592
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    targos committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1eebcbf View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. test: mark test-benchmark-crypto as flaky

    PR-URL: #52955
    Refs: #52690
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and targos committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    6e66d97 View commit details
    Browse the repository at this point in the history
  2. 2024-07-02, Version 22.4.0 (Current)

    Notable changes:
    
    deps,lib,src:
      * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435
    doc:
      * move `node --run` stability to rc (Yagiz Nizipli) #53433
      * mark WebSocket as stable (Matthew Aitken) #53352
      * mark --heap-prof and related flags stable (Joyee Cheung) #53343
      * mark --cpu-prof and related flags stable (Joyee Cheung) #53343
      * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329
    inspector:
      * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473
    lib:
      * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340
    util:
      * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107
    
    PR-URL: #53583
    targos committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    7e13cc5 View commit details
    Browse the repository at this point in the history