Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more Type and UnresolvedType methods #5994

Merged
merged 12 commits into from
Oct 7, 2024
Merged

feat: add more Type and UnresolvedType methods #5994

merged 12 commits into from
Oct 7, 2024

Conversation

asterite
Copy link
Collaborator

Description

Problem

Part of #5668

Summary

Work in progress.... (I'll add a bunch of methods in one go)

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

🚀 Deployed on https://6703c5db2e1e5fa28c409575--noir-docs.netlify.app

@asterite asterite marked this pull request as ready for review September 10, 2024 19:07
@asterite asterite requested a review from a team September 10, 2024 19:08
michaeljklein
michaeljklein requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@michaeljklein michaeljklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the note r.e. is_T functions

compiler/noirc_frontend/src/hir/comptime/interpreter/builtin.rs Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

FYI @noir-lang/developerrelations on Noir doc changes.

@TomAFrench TomAFrench added this pull request to the merge queue Oct 7, 2024
Merged via the queue into master with commit 8236cbd Oct 7, 2024
47 checks passed
@TomAFrench TomAFrench deleted the ab/comptime-more-type-methods branch October 7, 2024 11:46
@noirwhal noirwhal mentioned this pull request Oct 7, 2024
Open
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 7, 2024
@AztecBot
[1 changes] feat: add more Type and UnresolvedType methods (noir-…
33140b3 
…lang/noir#5994)

fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 7, 2024
@AztecBot
feat: add more Type and UnresolvedType methods (noir-lang/noir#5994)
a256d70 
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
@AztecBot AztecBot mentioned this pull request Oct 7, 2024
Merged
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 7, 2024
@AztecBot
[1 changes] fix: handle nested arrays in calldata (noir-lang/noir#6232)
c17bc36 
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994)
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 7, 2024
@AztecBot
fix: handle nested arrays in calldata (noir-lang/noir#6232)
4ce6453 
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994)
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 7, 2024
@AztecBot
[1 changes] feat: handwritten parser (noir-lang/noir#6180)
104725a 
feat(test): Fuzz test stdlib hash functions (noir-lang/noir#6233)
fix: handle nested arrays in calldata (noir-lang/noir#6232)
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994)
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 7, 2024
@AztecBot
feat: handwritten parser (noir-lang/noir#6180)
a8b414c 
feat(test): Fuzz test stdlib hash functions (noir-lang/noir#6233)
fix: handle nested arrays in calldata (noir-lang/noir#6232)
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994)
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 8, 2024
@AztecBot
[1 changes] feat: handwritten parser (noir-lang/noir#6180)
898b6a1 
feat(test): Fuzz test stdlib hash functions (noir-lang/noir#6233)
fix: handle nested arrays in calldata (noir-lang/noir#6232)
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994)
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 8, 2024
@AztecBot
feat: handwritten parser (noir-lang/noir#6180)
cc51963 
feat(test): Fuzz test stdlib hash functions (noir-lang/noir#6233)
fix: handle nested arrays in calldata (noir-lang/noir#6232)
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994)
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
sirasistant added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 8, 2024
@AztecBot @sirasistant
feat: Sync from noir (#9034)
26185f0 
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: handwritten parser (noir-lang/noir#6180)
feat(test): Fuzz test stdlib hash functions
(noir-lang/noir#6233)
fix: handle nested arrays in calldata
(noir-lang/noir#6232)
feat: add more `Type` and `UnresolvedType` methods
(noir-lang/noir#5994)
fix: Panic on composite types within databus
(noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get
optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature
(noir-lang/noir#6226)
END_COMMIT_OVERRIDE

---------

Co-authored-by: sirasistant <[email protected]>
@AztecBot AztecBot mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench left review comments

@vezenovm vezenovm vezenovm left review comments

@michaeljklein michaeljklein michaeljklein approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asterite @michaeljklein @TomAFrench @vezenovm