Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Panic on composite types within databus #6225

Merged
merged 3 commits into from
Oct 7, 2024
Merged

fix: Panic on composite types within databus #6225

merged 3 commits into from
Oct 7, 2024

Conversation

sirasistant
Copy link
Contributor

Description

Problem*

Allows initializing databus with composite types

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench added this pull request to the merge queue Oct 7, 2024
Merged via the queue into master with commit 29bd125 Oct 7, 2024
47 checks passed
@TomAFrench TomAFrench deleted the arv/fix_panic_composite_types_databus branch October 7, 2024 11:20
@noirwhal noirwhal mentioned this pull request Oct 7, 2024
Open
@guipublic guipublic mentioned this pull request Oct 7, 2024
Merged
5 tasks
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 7, 2024
@AztecBot
[1 changes] feat: add more Type and UnresolvedType methods (noir-…
33140b3 
…lang/noir#5994)

fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 7, 2024
@AztecBot
feat: add more Type and UnresolvedType methods (noir-lang/noir#5994)
a256d70 
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
@AztecBot AztecBot mentioned this pull request Oct 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 7, 2024
@guipublic
fix: handle nested arrays in calldata (#6232)
0ab8f5e 
# Description

## Problem\*

This PR builds on #6225 and adds support for nested arrays in calldata

## Summary\*
Reconstruct the acir array when reading a nested structure from
calldata.


## Additional Context



## Documentation\*

Check one:
- [X] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [X] I have tested the changes locally.
- [X] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 7, 2024
@AztecBot
[1 changes] fix: handle nested arrays in calldata (noir-lang/noir#6232)
c17bc36 
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994)
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 7, 2024
@AztecBot
fix: handle nested arrays in calldata (noir-lang/noir#6232)
4ce6453 
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994)
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 7, 2024
@AztecBot
[1 changes] feat: handwritten parser (noir-lang/noir#6180)
104725a 
feat(test): Fuzz test stdlib hash functions (noir-lang/noir#6233)
fix: handle nested arrays in calldata (noir-lang/noir#6232)
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994)
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 7, 2024
@AztecBot
feat: handwritten parser (noir-lang/noir#6180)
a8b414c 
feat(test): Fuzz test stdlib hash functions (noir-lang/noir#6233)
fix: handle nested arrays in calldata (noir-lang/noir#6232)
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994)
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 8, 2024
@AztecBot
[1 changes] feat: handwritten parser (noir-lang/noir#6180)
898b6a1 
feat(test): Fuzz test stdlib hash functions (noir-lang/noir#6233)
fix: handle nested arrays in calldata (noir-lang/noir#6232)
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994)
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 8, 2024
@AztecBot
feat: handwritten parser (noir-lang/noir#6180)
cc51963 
feat(test): Fuzz test stdlib hash functions (noir-lang/noir#6233)
fix: handle nested arrays in calldata (noir-lang/noir#6232)
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994)
fix: Panic on composite types within databus (noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature (noir-lang/noir#6226)
sirasistant added a commit to AztecProtocol/aztec-packages that referenced this pull request Oct 8, 2024
@AztecBot @sirasistant
feat: Sync from noir (#9034)
26185f0 
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: handwritten parser (noir-lang/noir#6180)
feat(test): Fuzz test stdlib hash functions
(noir-lang/noir#6233)
fix: handle nested arrays in calldata
(noir-lang/noir#6232)
feat: add more `Type` and `UnresolvedType` methods
(noir-lang/noir#5994)
fix: Panic on composite types within databus
(noir-lang/noir#6225)
feat(perf): Follow array sets backwards in array set from get
optimization (noir-lang/noir#6208)
fix: check for Schnorr null signature
(noir-lang/noir#6226)
END_COMMIT_OVERRIDE

---------

Co-authored-by: sirasistant <[email protected]>
@AztecBot AztecBot mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

@guipublic guipublic Awaiting requested review from guipublic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirasistant @TomAFrench