-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perf): Follow array sets backwards in array set from get optimization #6208
Conversation
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Note that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to have some more documentation within the function about our reasoning about what we're doing at particular steps.
Co-authored-by: Tom French <[email protected]>
Co-authored-by: Tom French <[email protected]>
… get optimization (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226)
… get optimization (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226)
…ation (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226)
… get optimization (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226)
…ation (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226)
…lang/noir#5994) fix: Panic on composite types within databus (noir-lang/noir#6225) feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226)
fix: Panic on composite types within databus (noir-lang/noir#6225) feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226)
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994) fix: Panic on composite types within databus (noir-lang/noir#6225) feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226)
feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994) fix: Panic on composite types within databus (noir-lang/noir#6225) feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226)
feat(test): Fuzz test stdlib hash functions (noir-lang/noir#6233) fix: handle nested arrays in calldata (noir-lang/noir#6232) feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994) fix: Panic on composite types within databus (noir-lang/noir#6225) feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226)
feat(test): Fuzz test stdlib hash functions (noir-lang/noir#6233) fix: handle nested arrays in calldata (noir-lang/noir#6232) feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994) fix: Panic on composite types within databus (noir-lang/noir#6225) feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226)
feat(test): Fuzz test stdlib hash functions (noir-lang/noir#6233) fix: handle nested arrays in calldata (noir-lang/noir#6232) feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994) fix: Panic on composite types within databus (noir-lang/noir#6225) feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226)
feat(test): Fuzz test stdlib hash functions (noir-lang/noir#6233) fix: handle nested arrays in calldata (noir-lang/noir#6232) feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994) fix: Panic on composite types within databus (noir-lang/noir#6225) feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226)
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: handwritten parser (noir-lang/noir#6180) feat(test): Fuzz test stdlib hash functions (noir-lang/noir#6233) fix: handle nested arrays in calldata (noir-lang/noir#6232) feat: add more `Type` and `UnresolvedType` methods (noir-lang/noir#5994) fix: Panic on composite types within databus (noir-lang/noir#6225) feat(perf): Follow array sets backwards in array set from get optimization (noir-lang/noir#6208) fix: check for Schnorr null signature (noir-lang/noir#6226) END_COMMIT_OVERRIDE --------- Co-authored-by: sirasistant <[email protected]>
Description
Problem*
Part of general effort reduce Brillig bytecode sizes
Summary*
Follow-up to #6207
From comments inside the PR:
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.