Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch upstream| Flutter 2.2.0 #7

Draft
wants to merge 507 commits into
base: master
Choose a base branch
from
Draft

Fetch upstream| Flutter 2.2.0 #7

wants to merge 507 commits into from

Conversation

miguelslemos
Copy link

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

rahulraj64 and others added 30 commits February 24, 2021 21:15
* Stable null safety release camera_platform_interface

* Update minimum plugin_platform_interface version

* Update version of cross_file to 0.3.1
Migrates the app-facing package to null safety. Includes replacing Mockito with a custom fake/mock.

Fixes an issue where the example didn't handle dialogs being canceled, which was highlighted by the NNBD migration. (Previously, they would cause null assertions at runtime, which wasn't noticed during development. NNBD for the win!)

Fixes flutter/flutter#75235
`io.flutter.embedded_views_preview` is not required since version `1.0.0`, so doesn't need to be in the example.
The action won't work on the simulator works on physical iOS device which was not mentioned here so it was added

Co-authored-by: Michael Klimushyn <[email protected]>
Co-authored-by: Stuart Morgan <[email protected]>
…lutter#3642)

Migrates to NNBD.
Replaces Mockito-based fakes with test's Fake.
To avoid intra-repo plugin conflicts during the NNBD stable migration,
`plugin_platform_interface` allowed either 1.x or 2.0. However, 1.0.x
isn't null-safe so this can cause apps that don't have all their
packages fully updated can fail to run in strong mode (due to having an
old local `plugin_platform_interface`.

Now that everything has been updated, we can bump all the minimums so
that people updating their plugins will get new versions of the
dependency.
Stable NNBD release for the camera package.

With this PR I also migrated the example App to sound null safe.
Replaces the problematic Mockito mock with a manual mock that handles
null and non-null types correctly.

Removes the unit test of the example app, since it's not adding any
actual coverage.
Removes the opt-out now that the underlying issue is fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment