Register finder

[sunjon]

Not super happy with the user experience so far.
Need nicer ways for editing, and more control over how you paste.

Putting the finder specific actions in actions/init.lua also feels strange, when everything else there is relatively generic.

Suggestions welcome

[sunjon]

[Conni2461]

You should use actions.goto_file_selection_edit:replace(actions.insert_value). That is a cool new api done by tj. In that way we respect user mappings. Take a look at what other builtins do with replace

[sunjon]

I'll look into this and update tomrrow.

[sunjon]

To be honest, that mapping wasn't used and I'm not sure how :replace fits in with the other mappings. If it's still applicable, let me know.

[Conni2461]

The thing about actions.goto_file_selection_edit:replace is that we basically replacing the users main action.
So if a user doesn't like <CR> as mapping and likes to use idk <space> he will hit <space> and we would call actions.goto_.... With that replace we basically just follow what the user expects for all individual pickers, even though they do something differently like checking out a branch or stuff. Does that makes sense.

[Conni2461]

@sunjon Great to see you working on another PR 👍. Looks really good. I just left some nitpicking comments but besides that i am exited for that picker 😄

[sunjon]

Perhaps not for this itteration, but I think a new sorter would suit these results better.
Currently, if my query is A, the fixed order of the list remains, but the "A" entry jumps to the top. What I think would be better, is if the results "rotated" to the match, ie. If "3" is the top entry, "4", "5","6", etc would follow.

[sunjon]

Remaining issues (not necessarily blocking merge):

1. Default action. Should the default action be put()?

2. Hide registers with no content?
   I'd have done this, but if this issue is resolved, then a user might want to use the edit functionality to put something into an empty register.

3. Custom ordering.
   It may be that a user is only interested in the [0-9] registers. Perhaps configration to apply a "hidden_registers = { ...}` filter.

[Conni2461]

1. Default action. Should the default action be put()?

Yes i think the default should be pasting the content inside the file at the current cursor pos.

3\. It may be that a user is only interested in the `[0-9]` registers.  Perhaps configration to apply a "hidden_registers = { ...}` filter.

We can also just say, that a user can define a table of registers in which he is interested.

Besides my remaining comments. I think this LGTM and when you done i think you can squash and merge.
Oh and could you also add the new builtin to the readme builtin table. That everyone sees that we have that cool new picker. Thanks

[kkharji]

well done @sunjon awesome work