Use noremap when mapping. #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjdevries
reviewed
Nov 24, 2020
lua/telescope/mappings.lua
Outdated
Comment on lines
97
to
98
| opts = opts or { | ||
| silent = true | ||
| } | ||
| if opts.noremap == nil then opts.noremap = true end |
There was a problem hiding this comment.
we should do this check for both:
opts = opts or {}
if opts.silent == nil then opts.silent = true end
if opts.noremap == nil then opts.noremap = true endSomething like that.
Then we can merge, looks like you were right about that!
Previously, if e.g. : was remapped, Telescope would be unclosable with its mappings (<Esc>). (Do the same for ensuring we :silent)
Julian
force-pushed
the
fix-mapping-noremap
branch
from
781b7a4
to
a935fe4
Compare
|
Cool, thanks for the fix. Good call. |
kkharji
pushed a commit
that referenced
this pull request
Nov 27, 2020
…o builtin_runner_insert_issue * 'master' of github.com:nvim-telescope/telescope.nvim: Refactor builtin (#287) fix: Use noremap when mapping. (#286) Fix the bug report template to suggest -u Add gitter tag feat: highlighter only Filter the completion of the command (#279) feat: Buffers rework (indicators and sorting) (#208) feat: v0.1 of extensions (#278) Register finder (#275) Various previewer fixes (#260) docs: fix builtin table formatting (#272) feat: Add highlights builtin (#267) Fixed minor typos (#271) Feat: Add filetypes builtin (#263) Fix: cwd detection of builtin.git_ (#264)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if e.g.
:was remapped, Telescope would be unclosable with its mappings (<Esc>).