-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor builtin into smaller modules #287
Conversation
Oh btw @tjdevries I made sure that the sorter is always loaded with We also don't have to remember to do Also also do we wanna check in |
006630b
to
e15840a
Compare
e15840a
to
d1041a4
Compare
@tjdevries Need your help for a sec with one change. Because we do |
Ah, I hadn't thought of that part of it. One thing we could do is we could just save that as some metadata with the functions. But I think that's a bit hacky and perhaps error prone.
For example, something cool would be we could write some documentation for the functions or something and then show the corresponding help.... I should really work on my doc generator :) |
I hadn't thought of that either. I would like to merge this today, so that we can keep the number of people who need to rebase as small as possible. Oh and yeah i have seen some of that doc generator based on treesitter, looks very promising and really helpful. So i am exited about that one. |
@tjdevries Fixed the @tami5 Could you test it for a second. Thanks. |
b44d794
to
c8c16e2
Compare
If it works, then you can merge. Don't have time to test today really. We can always poke around the previewer later. I agree should not keep this branch open for long. |
Oh wow, it works really well. You've also fixed a lot of issues we had previously with number of pickers. LGTM, let me know if there some final touches you need to get done before I merge. Thanks |
…o builtin_runner_insert_issue * 'master' of github.com:nvim-telescope/telescope.nvim: Refactor builtin (#287) fix: Use noremap when mapping. (#286) Fix the bug report template to suggest -u Add gitter tag feat: highlighter only Filter the completion of the command (#279) feat: Buffers rework (indicators and sorting) (#208) feat: v0.1 of extensions (#278) Register finder (#275) Various previewer fixes (#260) docs: fix builtin table formatting (#272) feat: Add highlights builtin (#267) Fixed minor typos (#271) Feat: Add filetypes builtin (#263) Fix: cwd detection of builtin.git_ (#264)
Should be good but someone should take a look at this so i don't wake up with a lot of angry messages. New structure: