Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing process names from "nwjs" and "nwjs Helper" to [Insert Name Here] and [Insert Name Here] Helper #4293

Closed
imjoshdean opened this issue Jan 21, 2016 · 18 comments
Milestone

Comments

@imjoshdean
Copy link

So I have this project I've been working on for a while, but I've been having trouble trying to figure out how to brand name the process without having to recompile nw.js outright (which is what we currently do).

Is there an easy way to do this that I am just somehow missing? How does, say, Spotify do it?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@imjoshdean
Copy link
Author

Bump.

@rogerwang? Anyone?

@baconbrad
Copy link

Spotify doesn't use nw.js. They created their own shell using the Chromium Embedded Framework.

@rogerwang
Copy link
Member

@imjoshdean changing 'product_name' in chrome/chrome_dll.gypi and chrome/chrome_exe.gypi, 'mac_product_name' in build/common.gypi should be good enough.

Please try it and then we'll put it into docs.

@imjoshdean
Copy link
Author

@baconface - thanks for the clarification @rogerwang I'll give that a shot.

@rishu-kumar-88
Copy link

@rogerwang We are working to change product name from nw.exe to [app name].exe by updating the 'product_name' in chrome/chrome_dll.gypi and chrome/chrome_exe.gypi, but it create nw.exe and executable is not displaying any window. Please let us know any possible solution.

@rogerwang
Copy link
Member

@rishu-kumar-88 you'll also search for 'chrome.exe' and 'chrome.dll' in those files and replace them with the name with nw. Also check the file:
chrome/installer/util/util_constants.cc

@Rishu
Copy link

Rishu commented May 24, 2016

@rogerwang We are able to build the executable, but we are unable to launch it. Here is the debug log below:

[0523/202130:ERROR:process_info.cc(608)] range at 0xfe796000, size 0x230 fully unreadable
[0523/202130:ERROR:process_info.cc(608)] range at 0xfe79f000, size 0xf84 fully unreadable
[0523/202130:ERROR:process_info.cc(608)] range at 0xfe79b000, size 0xf84 fully unreadable
[0523/202130:ERROR:process_info.cc(608)] range at 0xfe795000, size 0xf84 fully unreadable
[0523/202130:ERROR:process_info.cc(608)] range at 0xfe66f000, size 0xf84 fully unreadable
[0523/202130:ERROR:process_info.cc(608)] range at 0xfe66c000, size 0xf84 fully unreadable
[0523/202130:ERROR:process_info.cc(608)] range at 0xfe669000, size 0xf84 fully unreadable
[0523/202130:ERROR:process_info.cc(608)] range at 0xfe666000, size 0xf84 fully unreadable
[0523/202130:ERROR:process_info.cc(608)] range at 0xfe663000, size 0xf84 fully unreadable
[0523/202130:ERROR:process_info.cc(608)] range at 0xfe660000, size 0xf84 fully unreadable

Please let me know any workaround to fix this issue.

@RohitSharma27
Copy link

@rogerwang any update on this issue...

@rogerwang
Copy link
Member

There should be something missing on @rish's side. We'll put an official document on how to rename the executable. Thanks.

@rogerwang rogerwang added this to the 0.14.x milestone May 30, 2016
@rish
Copy link

rish commented May 30, 2016

@rogerwang I guess you mean @Rishu not me. 😄

@Rishu
Copy link

Rishu commented May 30, 2016

@rish Yes, this is for me. @rogerwang Thanks for your update about documentation of rename the executable. Are there any expected timeline for this documentation availability?

@AndryBray
Copy link

AndryBray commented May 31, 2016

@rogerwang any way to allow us to setup this with a properties file? or even inside package.json?
are we constrained to build / compile a custom build to get a custom process name?

@Sytten
Copy link

Sytten commented Jun 4, 2016

I agree, it should be easy to change the process name as it was before...

@tlacaelelrl
Copy link

for windows use resource hacker and edit the version info

@AndryBray
Copy link

@rogerwang any plan about this feature on 0.15 roadmap?

@gpetrov
Copy link

gpetrov commented Nov 28, 2016

@rogerwang any news on this? Rename of the main nwjs process is easily done, but renaming of the nwjs Helper process seems impossible as everything crashes on OSX afterwards.

MadLittleMods added a commit to gitterHQ/nw-builder that referenced this issue Jul 17, 2017
Fix nwutils#196
Fix nwutils#315

See

 - nwjs/nw.js#5809
 - nwjs/nw.js#5807
 - nwjs/nw.js#4293
 - nwjs/nw.js#2160
 - nwjs/nw.js#5829

Allows you to edit the version string of the resultant Windows executable.
These can be easily viewed in Properties -> Details, http://i.imgur.com/oqyRwaa.png

Fix issue where the process showed up as `nwjs` in Windows.
Now defaults to the `options.appName`
adam-lynch pushed a commit to nwutils/nw-builder that referenced this issue Oct 19, 2017
Fix #196
Fix #315

See

 - nwjs/nw.js#5809
 - nwjs/nw.js#5807
 - nwjs/nw.js#4293
 - nwjs/nw.js#2160
 - nwjs/nw.js#5829

Allows you to edit the version string of the resultant Windows executable.
These can be easily viewed in Properties -> Details, http://i.imgur.com/oqyRwaa.png

Fix issue where the process showed up as `nwjs` in Windows.
Now defaults to the `options.appName`
@kierans
Copy link
Contributor

kierans commented May 1, 2018

I also find it interesting that the documentation tells me to rename nwjs Helper but not nwjs? Oversight?

kierans added a commit to kierans/nw.js that referenced this issue May 1, 2018
If we're going to update the Helper app binary, why not the main app binary?

This relates to nwjs#4293
@IssueHuntBot
Copy link

@BoostIO funded this issue with $30. Visit this issue on Issuehunt

rogerwang pushed a commit that referenced this issue Jan 10, 2019
If we're going to update the Helper app binary, why not the main app binary?

This relates to #4293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests