Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option.winVersionString for accurate process name (always nwjs previously) #459

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Jul 17, 2017

Fixes #196
Fixes #315

Add option.winVersionString for accurate process name

The main goal was to fix the issue where the process showed up as nwjs in the Windows 10 Task Manager (now defaults to the options.appName). When trying to change FileDescription via rcedit as a post-process to the nw-builder build, I would always get a blank/default-shimmer NW.js page when starting up the app instead of the specified main file.

Allows you to edit the version string of the resultant Windows executable. These can be easily viewed in Properties -> Details,

winVersionString: {
  'CompanyName': 'Some Company',
  'FileDescription': 'Process Name',
  'ProductName': 'Some Product',
  'LegalCopyright': 'Copyright 2017',
}
Before After

Instead of just version-string, we could generalize this more to allow more of the rcedit options like file-version, perhaps as options.winRc.

version-string covers these properties, https://msdn.microsoft.com/en-us/library/windows/desktop/aa381058.aspx#string-name


Also see

Fix nwutils#196
Fix nwutils#315

See

 - nwjs/nw.js#5809
 - nwjs/nw.js#5807
 - nwjs/nw.js#4293
 - nwjs/nw.js#2160
 - nwjs/nw.js#5829

Allows you to edit the version string of the resultant Windows executable.
These can be easily viewed in Properties -> Details, http://i.imgur.com/oqyRwaa.png

Fix issue where the process showed up as `nwjs` in Windows.
Now defaults to the `options.appName`
@mscreenie
Copy link

Great. Is this fix available in npm? +1

@jnoring
Copy link

jnoring commented Oct 19, 2017

Why hasn't this been merged?

@rogerwang
Copy link

@adam-lynch are you still maintaining this project?

@adam-lynch
Copy link
Contributor

@rogerwang got a lot on my plate right now but can look at this tonight 👍

@adam-lynch adam-lynch merged commit 748ff18 into nwutils:develop Oct 19, 2017
@adam-lynch
Copy link
Contributor

💥 nice pull-request @MadLittleMods, thanks! Would you help this project more? We're always looking for maintainers/contributors. That could be improving documentation, replying to / closing issues, merging pull-requests, fixing bugs, etc... whatever you like 😄

@MadLittleMods
Copy link
Contributor Author

Thanks for the merge and npm release @adam-lynch 🚀 😀

Sorry, I can't commit myself to keeping up with this project. We're using nw-builder in an upcoming version of the Gitter app and I don't have the chance to dive in often. Feel free to assign me status to triage issues when I stop by though.

@adam-lynch
Copy link
Contributor

@MadLittleMods no problem. I've given you access so you can close issues so. You should be able to accept it here: https://github.com/nwjs-community/nw-builder/invitations. P.S. Gitter is cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants