-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Executable properties are needed for enterprise deploy #196
Comments
We use Anolis Resourcer via winresourcer for the icon so maybe these properties could be edited with that too? |
@felicienfrancois, any idea? |
it should be possible to to it with Anolis resourcer / winresourcer but it is not documented enough to make it trivial. Something like that should do the job: require("winresourcer")({
operation: "Add",
exeFile: "path/to/the/file.exe",
resourceType: "Version",
resourceName: "1",
lang: 1033,
resourceFile: "path/to/a/file.bin" // ???
}, function(error) {
// callback
}); But I can't figure out what should be the content of the resourceFile. |
Well, I get it working with a file exported from the GUI. What I made:
require("winresourcer")({
operation: "Add",
exeFile: "target.exe",
resourceType: "Version",
resourceName: "1",
lang: 1033,
resourceFile: "test.bin"
}, function(error) {
// callback
}); And the target exe get the infos from the source exe. Then, we now need to be able to creates this binary file programmatically. I'll search for a way to generate such a stringtable with nodejs |
Thanks for looking into this! Regards, On 7 March 2015 at 20:05, Félicien FRANCOIS [email protected]
|
@felicienfrancois Did you ever manage to get this working? I did a little digging around and it looks we need to create a VERSIONINFO From there I believe it needs to be compiled into a binary
Finally the |
@karldd I switched to electron (known as atom shell) so I no longer have thoose issues When I tried rcedit on NW.JS binaries, quite a long time ago, there was several issues (especially with the icon) but it may have changes as both NW.JS and rcedit have been updated. In the case there are still issues with rcedit setting icon of nw.js, you may use winresourcer for the icon and rcedit for version info |
this will be really handy feature to be able to change the version info automatically. the icon can be changed now - but still not the file info any progress? |
@gpetrov What about using |
thanks @evshiron - wasn't aware of it - will check it out! |
@gpetrov I am afraid not. I have never used things like |
Not sure why someone hasn't posted this yet. Here's how to do it (from a gulp pleb) using rcedit. This would be really nice to be able to do in nw-builder.
|
Fix nwutils#196 Fix nwutils#315 See - nwjs/nw.js#5809 - nwjs/nw.js#5807 - nwjs/nw.js#4293 - nwjs/nw.js#2160 - nwjs/nw.js#5829 Allows you to edit the version string of the resultant Windows executable. These can be easily viewed in Properties -> Details, http://i.imgur.com/oqyRwaa.png Fix issue where the process showed up as `nwjs` in Windows. Now defaults to the `options.appName`
@cdobbyn When trying to change I made a PR to add it directly into the |
Cool, when I did this I discovered that the appended bundle was stripped by |
Thanks @evshiron . I decided to use nw-builder as it works pretty well with my automated building process. I'll look to see if I can fit nwjs-builder instead. I simply need to ship quickly, if not I may rcedit myself. |
When building for windows, the executable is missing some informations which are usually vital for enterprise deploy of the apps.
Those infos are the ones that can be accessed right-clicking the .exe, then choosing Properties > Details.
There are workarounds using resource editors, but they are not very maintainable and they can very easily corrupt the executable.
The text was updated successfully, but these errors were encountered: