Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"unknown flag -safe-string" on OCaml 5.0 #1518

Closed
kit-ty-kate opened this issue Oct 28, 2022 · 0 comments · Fixed by ocaml/opam-repository#22655
Closed

"unknown flag -safe-string" on OCaml 5.0 #1518

kit-ty-kate opened this issue Oct 28, 2022 · 0 comments · Fixed by ocaml/opam-repository#22655
Assignees
@voodoos
Labels
Kind/Bug
Milestone
Support OCaml 5

Comments

@kit-ty-kate
Copy link
Member

Using this project at this particular commit: kit-ty-kate/mastodon-archive-viewer@bd94f22 using OCaml 5.0.0~beta1
Then opening src/main.ml using emacs and reloading merlin will show the following error:

unknown flag -safe-string (0 pending errors, use C-c C-x to jump)

However the command is still around and works perfectly fine (it's no noop)
@voodoos voodoos added this to the Support OCaml 5 milestone Nov 2, 2022
voodoos added a commit to voodoos/merlin that referenced this issue Dec 7, 2022
@voodoos
Add test for issue ocaml#1518
1c438dc
@voodoos voodoos mentioned this issue Dec 7, 2022
Merged
@voodoos voodoos self-assigned this Dec 12, 2022
@voodoos voodoos mentioned this issue Dec 13, 2022
Merged
voodoos added a commit to voodoos/opam-repository that referenced this issue Dec 13, 2022
@voodoos
[new release] merlin, merlin-lib and dot-merlin-reader (4.7.1-500)
c9120a6 
CHANGES:

Thu Dec 13 11:49:42 CEST 2022

  + merlin binary
    - Restore compatibility with the compiler's command line by accepting
      the `-safe-string` flag as a no-op instead of rejecting it. (ocaml/merlin#1544,
      fixes ocaml/merlin#1518)
    - Mark some C variables as unused to remove warnings (ocaml/merlin#1541, @antalsz)
voodoos added a commit to voodoos/opam-repository that referenced this issue Feb 24, 2023
@voodoos
[new release] merlin, merlin-lib and dot-merlin-reader (4.8-500)
7714029 
CHANGES:

Fri Feb 24 16:55:42 CEST 2023

  + merlin binary
    - Recognize OCaml 5.0 cmi magic number in compiler version mismatch message
      (ocaml/merlin#1554, fixes ocaml/merlin#1553)
    - Upgrade Merlin from the RC2 to the stable 5.0.0 compiler release (ocaml/merlin#1559,
      fixes ocaml/merlin#1558)
    - Improve type-enclosing behaviour when used on records' labels (ocaml/merlin#1565,
      fixes ocaml/merlin#1564)
    - Restore compatibility with the compiler's command line by accepting the
      `-safe-string` flag as a no-op instead of rejecting it (ocaml/merlin#1544, fixes
      ocaml/merlin#1518)
    - Traverse aliases when jumping to declaration. This matches
      jump-to-definition's behavior (ocaml/merlin#1563)
    - Improve locate's behavior in various ill-typed expressions (ocaml/merlin#1546, fixes
      ocaml/merlin#1567 and partially ocaml/merlin#1543)
    - Correctly traverse patterns when looking for docs in the typedtree (ocaml/merlin#1572)
    - Get documentation when the declaration or definition is selected (ocaml/merlin#1542,
      fixes ocaml/merlin#1540)
    - On Windows, change to a harmless directory when launching server to avoid
      locking down current directory (ocaml/merlin#1569, fixes ocaml/merlin#1474)
  + editor modes
    - emacs: Fix misuse of `eq` comparison (ocaml/merlin#1549, @mattiase)
    - emacs: xref works from context menus; better highlighting of xref matches;
      xref recognises operators and binding operators at the cursor position;
      bad locations are filtered out (ocaml/merlin#1385, fixes ocaml/merlin#1410, @mattiase)
  + test suite
    - Add a test for incorrect alert defaults (ocaml/merlin#1559)
    - Add multiple tests for locate over ill-typed expressions (ocaml/merlin#1546)
    - Add non-regression tests for other fixes in this release
voodoos added a commit to voodoos/opam-repository that referenced this issue Feb 24, 2023
@voodoos
[new release] merlin and merlin-lib (4.8-500)
86ebee5 
CHANGES:

Fri Feb 24 16:55:42 CEST 2023

  + merlin binary
    - Recognize OCaml 5.0 cmi magic number in compiler version mismatch message
      (ocaml/merlin#1554, fixes ocaml/merlin#1553)
    - Upgrade Merlin from the RC2 to the stable 5.0.0 compiler release (ocaml/merlin#1559,
      fixes ocaml/merlin#1558)
    - Improve type-enclosing behaviour when used on records' labels (ocaml/merlin#1565,
      fixes ocaml/merlin#1564)
    - Restore compatibility with the compiler's command line by accepting the
      `-safe-string` flag as a no-op instead of rejecting it (ocaml/merlin#1544, fixes
      ocaml/merlin#1518)
    - Traverse aliases when jumping to declaration. This matches
      jump-to-definition's behavior (ocaml/merlin#1563)
    - Improve locate's behavior in various ill-typed expressions (ocaml/merlin#1546, fixes
      ocaml/merlin#1567 and partially ocaml/merlin#1543)
    - Correctly traverse patterns when looking for docs in the typedtree (ocaml/merlin#1572)
    - Get documentation when the declaration or definition is selected (ocaml/merlin#1542,
      fixes ocaml/merlin#1540)
    - On Windows, change to a harmless directory when launching server to avoid
      locking down current directory (ocaml/merlin#1569, fixes ocaml/merlin#1474)
  + editor modes
    - emacs: Fix misuse of `eq` comparison (ocaml/merlin#1549, @mattiase)
    - emacs: xref works from context menus; better highlighting of xref matches;
      xref recognises operators and binding operators at the cursor position;
      bad locations are filtered out (ocaml/merlin#1385, fixes ocaml/merlin#1410, @mattiase)
  + test suite
    - Add a test for incorrect alert defaults (ocaml/merlin#1559)
    - Add multiple tests for locate over ill-typed expressions (ocaml/merlin#1546)
    - Add non-regression tests for other fixes in this release
voodoos added a commit to voodoos/merlin that referenced this issue May 2, 2024
@voodoos
Add test for issue ocaml#1518
750cc67
voodoos added a commit to voodoos/merlin that referenced this issue May 2, 2024
@voodoos
Add test for issue ocaml#1518
a3a0562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voodoos voodoos

Labels
Kind/Bug
Projects
None yet
Milestone
Support OCaml 5
Development

Successfully merging a pull request may close this issue.

[new release] merlin and merlin-lib (4.7.1-500) voodoos/opam-repository
2 participants
@kit-ty-kate @voodoos