-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc for identifier in let definition is not found - regression #1540
Labels
Comments
Thanks for the report and especially the bisection, I will have a look ! |
ulugbekna
added a commit
to ocaml/ocaml-lsp
that referenced
this issue
Dec 6, 2022
ulugbekna
added a commit
to ocaml/ocaml-lsp
that referenced
this issue
Dec 8, 2022
ulugbekna
added a commit
to ocaml/ocaml-lsp
that referenced
this issue
Dec 9, 2022
voodoos
added a commit
to voodoos/opam-repository
that referenced
this issue
Feb 24, 2023
CHANGES: Fri Feb 24 16:55:42 CEST 2023 + merlin binary - Recognize OCaml 5.0 cmi magic number in compiler version mismatch message (ocaml/merlin#1554, fixes ocaml/merlin#1553) - Upgrade Merlin from the RC2 to the stable 5.0.0 compiler release (ocaml/merlin#1559, fixes ocaml/merlin#1558) - Improve type-enclosing behaviour when used on records' labels (ocaml/merlin#1565, fixes ocaml/merlin#1564) - Restore compatibility with the compiler's command line by accepting the `-safe-string` flag as a no-op instead of rejecting it (ocaml/merlin#1544, fixes ocaml/merlin#1518) - Traverse aliases when jumping to declaration. This matches jump-to-definition's behavior (ocaml/merlin#1563) - Improve locate's behavior in various ill-typed expressions (ocaml/merlin#1546, fixes ocaml/merlin#1567 and partially ocaml/merlin#1543) - Correctly traverse patterns when looking for docs in the typedtree (ocaml/merlin#1572) - Get documentation when the declaration or definition is selected (ocaml/merlin#1542, fixes ocaml/merlin#1540) - On Windows, change to a harmless directory when launching server to avoid locking down current directory (ocaml/merlin#1569, fixes ocaml/merlin#1474) + editor modes - emacs: Fix misuse of `eq` comparison (ocaml/merlin#1549, @mattiase) - emacs: xref works from context menus; better highlighting of xref matches; xref recognises operators and binding operators at the cursor position; bad locations are filtered out (ocaml/merlin#1385, fixes ocaml/merlin#1410, @mattiase) + test suite - Add a test for incorrect alert defaults (ocaml/merlin#1559) - Add multiple tests for locate over ill-typed expressions (ocaml/merlin#1546) - Add non-regression tests for other fixes in this release
voodoos
added a commit
to voodoos/opam-repository
that referenced
this issue
Feb 24, 2023
CHANGES: Fri Feb 24 16:55:42 CEST 2023 + merlin binary - Update internal typer to match OCaml 4.14.1 release (ocaml/merlin#1557) - Improve type-enclosing behaviour when used on records' labels (ocaml/merlin#1565, fixes ocaml/merlin#1564) - Restore compatibility with some OCaml compiler's debug flags that were incorrectly rejected by Merlin (ocaml/merlin#1556) - Traverse aliases when jumping to declaration. This matches jump-to-definition's behavior (ocaml/merlin#1563) - Improve locate's behavior in various ill-typed expressions (ocaml/merlin#1546, fixes ocaml/merlin#1567 and partially ocaml/merlin#1543) - Correctly traverse patterns when looking for docs in the typedtree (ocaml/merlin#1572) - Get documentation when the declaration or definition is selected (ocaml/merlin#1542, fixes ocaml/merlin#1540) - On Windows, change to a harmless directory when launching server to avoid locking down current directory (ocaml/merlin#1569, fixes ocaml/merlin#1474) + test suite - Add multiple tests for locate over ill-typed expressions (ocaml/merlin#1546) - Add non-regression tests for other fixes in this release
voodoos
added a commit
to voodoos/opam-repository
that referenced
this issue
Feb 24, 2023
CHANGES: Fri Feb 24 16:55:42 CEST 2023 + merlin binary - Recognize OCaml 5.0 cmi magic number in compiler version mismatch message (ocaml/merlin#1554, fixes ocaml/merlin#1553) - Upgrade Merlin from the RC2 to the stable 5.0.0 compiler release (ocaml/merlin#1559, fixes ocaml/merlin#1558) - Improve type-enclosing behaviour when used on records' labels (ocaml/merlin#1565, fixes ocaml/merlin#1564) - Restore compatibility with the compiler's command line by accepting the `-safe-string` flag as a no-op instead of rejecting it (ocaml/merlin#1544, fixes ocaml/merlin#1518) - Traverse aliases when jumping to declaration. This matches jump-to-definition's behavior (ocaml/merlin#1563) - Improve locate's behavior in various ill-typed expressions (ocaml/merlin#1546, fixes ocaml/merlin#1567 and partially ocaml/merlin#1543) - Correctly traverse patterns when looking for docs in the typedtree (ocaml/merlin#1572) - Get documentation when the declaration or definition is selected (ocaml/merlin#1542, fixes ocaml/merlin#1540) - On Windows, change to a harmless directory when launching server to avoid locking down current directory (ocaml/merlin#1569, fixes ocaml/merlin#1474) + editor modes - emacs: Fix misuse of `eq` comparison (ocaml/merlin#1549, @mattiase) - emacs: xref works from context menus; better highlighting of xref matches; xref recognises operators and binding operators at the cursor position; bad locations are filtered out (ocaml/merlin#1385, fixes ocaml/merlin#1410, @mattiase) + test suite - Add a test for incorrect alert defaults (ocaml/merlin#1559) - Add multiple tests for locate over ill-typed expressions (ocaml/merlin#1546) - Add non-regression tests for other fixes in this release
voodoos
added a commit
to voodoos/opam-repository
that referenced
this issue
Feb 24, 2023
CHANGES: Fri Feb 24 16:55:42 CEST 2023 + merlin binary - Update internal typer to match OCaml 4.14.1 release (ocaml/merlin#1557) - Improve type-enclosing behaviour when used on records' labels (ocaml/merlin#1565, fixes ocaml/merlin#1564) - Restore compatibility with some OCaml compiler's debug flags that were incorrectly rejected by Merlin (ocaml/merlin#1556) - Traverse aliases when jumping to declaration. This matches jump-to-definition's behavior (ocaml/merlin#1563) - Improve locate's behavior in various ill-typed expressions (ocaml/merlin#1546, fixes ocaml/merlin#1567 and partially ocaml/merlin#1543) - Correctly traverse patterns when looking for docs in the typedtree (ocaml/merlin#1572) - Get documentation when the declaration or definition is selected (ocaml/merlin#1542, fixes ocaml/merlin#1540) - On Windows, change to a harmless directory when launching server to avoid locking down current directory (ocaml/merlin#1569, fixes ocaml/merlin#1474) + test suite - Add multiple tests for locate over ill-typed expressions (ocaml/merlin#1546) - Add non-regression tests for other fixes in this release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Documentation for the identifier in a let definition is not found (but if the identifier is used later, the doc is still found.
Before:
After 762e8bf (according to git bisect)
The text was updated successfully, but these errors were encountered: