Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "unstable" alert in OCaml 5.0 is enabled by default in merlin #1558

Closed
kit-ty-kate opened this issue Jan 11, 2023 · 0 comments · Fixed by #1559
Closed

The "unstable" alert in OCaml 5.0 is enabled by default in merlin #1558

kit-ty-kate opened this issue Jan 11, 2023 · 0 comments · Fixed by #1559

Comments

@kit-ty-kate
Copy link
Member

The Warnings module in OCaml 5.0 doesn't correspond to what's in this module upstream:

merlin/src/ocaml/utils/warnings.ml

Line 507 in c447386

alerts = (Std.String.Set.empty, false); (* all enabled *)

Upstream, the unstable alert is disabled by default:

https://github.com/ocaml/ocaml/blob/34cf5aafcedc2f7895c7f5f0ac27c7e58e4f4adf/utils/warnings.ml#L861
voodoos added a commit to voodoos/merlin that referenced this issue Jan 12, 2023
@voodoos
Add a test illustrating issue ocaml#1558
ead3586
voodoos added a commit to voodoos/merlin that referenced this issue Jan 12, 2023
@voodoos
Upgrade Merlin to 5.0.0 release and fix ocaml#1558
2f7e5e0
@voodoos voodoos mentioned this issue Jan 12, 2023
Merged
@voodoos voodoos linked a pull request Jan 12, 2023 that will close this issue
Upgrade Merlin to stable release 5.0 #1559
Merged
voodoos added a commit to voodoos/opam-repository that referenced this issue Feb 24, 2023
@voodoos
[new release] merlin, merlin-lib and dot-merlin-reader (4.8-500)
7714029 
CHANGES:

Fri Feb 24 16:55:42 CEST 2023

  + merlin binary
    - Recognize OCaml 5.0 cmi magic number in compiler version mismatch message
      (ocaml/merlin#1554, fixes ocaml/merlin#1553)
    - Upgrade Merlin from the RC2 to the stable 5.0.0 compiler release (ocaml/merlin#1559,
      fixes ocaml/merlin#1558)
    - Improve type-enclosing behaviour when used on records' labels (ocaml/merlin#1565,
      fixes ocaml/merlin#1564)
    - Restore compatibility with the compiler's command line by accepting the
      `-safe-string` flag as a no-op instead of rejecting it (ocaml/merlin#1544, fixes
      ocaml/merlin#1518)
    - Traverse aliases when jumping to declaration. This matches
      jump-to-definition's behavior (ocaml/merlin#1563)
    - Improve locate's behavior in various ill-typed expressions (ocaml/merlin#1546, fixes
      ocaml/merlin#1567 and partially ocaml/merlin#1543)
    - Correctly traverse patterns when looking for docs in the typedtree (ocaml/merlin#1572)
    - Get documentation when the declaration or definition is selected (ocaml/merlin#1542,
      fixes ocaml/merlin#1540)
    - On Windows, change to a harmless directory when launching server to avoid
      locking down current directory (ocaml/merlin#1569, fixes ocaml/merlin#1474)
  + editor modes
    - emacs: Fix misuse of `eq` comparison (ocaml/merlin#1549, @mattiase)
    - emacs: xref works from context menus; better highlighting of xref matches;
      xref recognises operators and binding operators at the cursor position;
      bad locations are filtered out (ocaml/merlin#1385, fixes ocaml/merlin#1410, @mattiase)
  + test suite
    - Add a test for incorrect alert defaults (ocaml/merlin#1559)
    - Add multiple tests for locate over ill-typed expressions (ocaml/merlin#1546)
    - Add non-regression tests for other fixes in this release
voodoos added a commit to voodoos/opam-repository that referenced this issue Feb 24, 2023
@voodoos
[new release] merlin and merlin-lib (4.8-500)
86ebee5 
CHANGES:

Fri Feb 24 16:55:42 CEST 2023

  + merlin binary
    - Recognize OCaml 5.0 cmi magic number in compiler version mismatch message
      (ocaml/merlin#1554, fixes ocaml/merlin#1553)
    - Upgrade Merlin from the RC2 to the stable 5.0.0 compiler release (ocaml/merlin#1559,
      fixes ocaml/merlin#1558)
    - Improve type-enclosing behaviour when used on records' labels (ocaml/merlin#1565,
      fixes ocaml/merlin#1564)
    - Restore compatibility with the compiler's command line by accepting the
      `-safe-string` flag as a no-op instead of rejecting it (ocaml/merlin#1544, fixes
      ocaml/merlin#1518)
    - Traverse aliases when jumping to declaration. This matches
      jump-to-definition's behavior (ocaml/merlin#1563)
    - Improve locate's behavior in various ill-typed expressions (ocaml/merlin#1546, fixes
      ocaml/merlin#1567 and partially ocaml/merlin#1543)
    - Correctly traverse patterns when looking for docs in the typedtree (ocaml/merlin#1572)
    - Get documentation when the declaration or definition is selected (ocaml/merlin#1542,
      fixes ocaml/merlin#1540)
    - On Windows, change to a harmless directory when launching server to avoid
      locking down current directory (ocaml/merlin#1569, fixes ocaml/merlin#1474)
  + editor modes
    - emacs: Fix misuse of `eq` comparison (ocaml/merlin#1549, @mattiase)
    - emacs: xref works from context menus; better highlighting of xref matches;
      xref recognises operators and binding operators at the cursor position;
      bad locations are filtered out (ocaml/merlin#1385, fixes ocaml/merlin#1410, @mattiase)
  + test suite
    - Add a test for incorrect alert defaults (ocaml/merlin#1559)
    - Add multiple tests for locate over ill-typed expressions (ocaml/merlin#1546)
    - Add non-regression tests for other fixes in this release
voodoos added a commit to voodoos/merlin that referenced this issue May 2, 2024
@voodoos
Add a test illustrating issue ocaml#1558
8c2ac8d
voodoos added a commit to voodoos/merlin that referenced this issue May 2, 2024
@voodoos
Upgrade Merlin to 5.0.0 release and fix ocaml#1558
b3abc75
voodoos added a commit to voodoos/merlin that referenced this issue May 2, 2024
@voodoos
Add a test illustrating issue ocaml#1558
4b2d533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Merlin to stable release 5.0 voodoos/merlin
1 participant
@kit-ty-kate