-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Header to obstacles message #55
Conversation
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde each Obstacle has its own header. Can this information be used for your application? Originally this message was meant to be published over Let me know your thoughts. Happy to iterate. |
The |
|
Anyone have any updates on this? Any downside to merging this? |
I think the original intention of the I see two options moving forward:
What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this in for now. GSoC 24 participants can help to improve things.
Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Yadunund <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
After ensuring that I pulled the latest rmf_internal_msgs and even after rechecking if I have done it correctly or not . I am getting the same build error for rmf_obstacle_detectors as given in open-rmf/rmf_obstacle#18. |
|
Our ci which builds from source is passing with latest Please make sure you're not using binaries of Open-RMF to compile |
@Yadunund I have ensured that all the files are upto date and i'm not using binaries for installation for rmf_obstacle_ros. I am getting the same build error . |
I am not able to reproduce the issue with a clean build. Infact, I ran your own PR through our CI and it builds successfully: See (iron, jammy) run. |
Signed-off-by: Alejandro Hernández Cordero [email protected]
In this PR, I used
tf2_ros::MessageFilter
as one of the TODOs that @Yadunund left in the code. This field is required in order to use this feature