-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LifeCycle_Preview created #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the effort to improve the documentation but there's no need to create a new markdown page summarizing lifecycle nodes. You may add a line to the existing readme that highlights that the nodes are lifecycle node and link to the lifecycle design document. Copy pasting text from existing documentation into a separate file here is not favorable practice.
It's best to add the commands to configure and activate the node right after the existing command to run the node
Also please rebase this PR with the latest main
and ensure there are no unnecessary commits from other contributors.
Thanks @Yadunund for reviewing and giving me suggestions . I was firstly thinking to provide a different markdown page for this with a brief description . |
No need to include a screenshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase your PR with main
and ensure you don't include commits from other authors.
@Avisheet do you still plan on addressing the comments in the PR? |
Yes @Yadunund . Due to some issues, I wast able to focus here . But I ensure you that I will be working on this . |
Hey @Yadunund, I have rebased my PR with the main. I request you to review my PR and tell me the desired changes. |
The first commit still has changes from a different author. |
Signed-off-by: Avisheet <[email protected]>
Signed-off-by: Avisheet <[email protected]>
Signed-off-by: Avisheet <[email protected]>
Signed-off-by: Avisheet <[email protected]>
Hey @Yadunund, should I also remove commits 5,6 and 7? |
Signed-off-by: Avisheet <[email protected]>
Signed-off-by: Avisheet <[email protected]>
Hey @Yadunund , the last two commits appeard while resolving the merge errors after removing commits from other authors , can you once review it and tell me the desired changes I need to do now. |
Please resolve conflicts with main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating and sorry for the delay in getting this merged.
rmf_obstacle_detector_laserscan waiting to configure
While running ros2 run rmf_obstacle_detector_laserscan laserscan_detector , I encountered waiting to configure .
The Lifecycle_preview provides a detailed description about how to configure and activate the node.