LifeCycle_Preview created

[Avisheet]

rmf_obstacle_detector_laserscan waiting to configure

While running ros2 run rmf_obstacle_detector_laserscan laserscan_detector , I encountered waiting to configure .
The Lifecycle_preview provides a detailed description about how to configure and activate the node.

[Yadunund]

Appreciate the effort to improve the documentation but there's no need to create a new markdown page summarizing lifecycle nodes. You may add a line to the existing readme that highlights that the nodes are lifecycle node and link to the lifecycle design document. Copy pasting text from existing documentation into a separate file here is not favorable practice.

It's best to add the commands to configure and activate the node right after the existing command to run the node

Also please rebase this PR with the latest main and ensure there are no unnecessary commits from other contributors.

[Avisheet]

Thanks @Yadunund for reviewing and giving me suggestions . I was firstly thinking to provide a different markdown page for this with a brief description .
I will ensure to make the changes as suggested . Can you tell me should I add the picture of this "waiting to configure..." point or should I just add the commands .

[Yadunund]

No need to include a screenshot.

[Yadunund]

Please rebase your PR with main and ensure you don't include commits from other authors.

[Yadunund]

@Avisheet do you still plan on addressing the comments in the PR?

[Avisheet]

Yes @Yadunund . Due to some issues, I wast able to focus here . But I ensure you that I will be working on this .

[Avisheet]

Hey @Yadunund, I have rebased my PR with the main. I request you to review my PR and tell me the desired changes.

[Yadunund]

The first commit still has changes from a different author.

[Avisheet]

Hey @Yadunund, should I also remove commits 5,6 and 7?

[Avisheet]

Hey @Yadunund , the last two commits appeard while resolving the merge errors after removing commits from other authors , can you once review it and tell me the desired changes I need to do now.

[Yadunund]

Please resolve conflicts with main

[Yadunund]

Thanks for iterating and sorry for the delay in getting this merged.