Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS SDK common and dynamodb conventions #1422
AWS SDK common and dynamodb conventions #1422
Changes from 13 commits
7f8fe28
b124776
1410a31
aa3b3b3
efcea38
e3e93a2
83b378c
faaad26
499a123
f801d4c
08bdd8e
81dc236
3a4e092
5f5fcbf
5e8db59
1777f83
28a9dc0
89446e9
9639b24
fe38bb2
c65b660
1cfae0a
4875126
bf88561
cce890b
edbab95
01a9f62
0a1860d
9896037
bdae745
dcae457
193755f
1b5cb8a
582e065
2b10583
4c78487
c38800c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are supposed to be
double
, but the generator only supportsnumber
I think, and the examples have to be integer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @thisthat I somehow thought this was already fixed, but open-telemetry/build-tools#13 is still open, so I may be mistaken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created open-telemetry/build-tools#30 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1550 bumps the semconvgen reference to v0.3.0 which includes this change.