-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configuration for xpert unit summaries #540
Conversation
Adds setting modal for Xpert unit summaries
715bbb7
to
04d2312
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need to fix spacing issues on the one file, otherwise, lgtm
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #540 +/- ##
==========================================
+ Coverage 78.20% 78.54% +0.34%
==========================================
Files 145 151 +6
Lines 2698 2820 +122
Branches 632 661 +29
==========================================
+ Hits 2110 2215 +105
- Misses 558 574 +16
- Partials 30 31 +1
☔ View full report in Codecov by Sentry. |
Is your plan to write unit test together in this PR? That make sense. This early view makes reviewing much easier than with all those spec files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just left a comment for the use of awaits on state setters.
It would be awesome if PRs with UI changes get also some screenshots for context.
src/pages-and-resources/xpert-unit-summary/settings-modal/SettingsModal.jsx
Outdated
Show resolved
Hide resolved
src/pages-and-resources/xpert-unit-summary/settings-modal/SettingsModal.jsx
Show resolved
Hide resolved
yep, that's the plan |
This is done based on a flag from edx/ai-aside@3d113d2
bcc8f7b
to
ed4ba40
Compare
6613314
to
a43ed0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
things I wanted are all set :)
Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2
* feat: configuration for xpert unit summaries (openedx#540) Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2 * fix: load up-to-date config on studio fetch (openedx#548) * refactor: added PropTypes declarations * feat: add files and uploads page (openedx#541) * fix: remove env variable for files and uploads (openedx#549) * Update verbiage for Xpert Settings (openedx#550) * chore: Update verbiage for Xpert configuration screen * fix: Change "generate" to "display" in xpert modal text * fix: Updated learn more link * fix: Change link and add targets * test: added test cases for hide discussion tab (openedx#552) Co-authored-by: SundasNoreen <[email protected]> * feat: upgrade frontend-lib-content-components (openedx#554) * feat: bump frontend-lib-content-components (openedx#559) * fix: Change wording to not crowd xpert tile in preferences page (openedx#560) * fix: width and height of asset preview (openedx#558) * feat: flcc to 1.168.0 (openedx#561) * feat: bump frontend-lib-content-components (openedx#562) * fix: overflow-y scroll behavior (openedx#565) * test: added test cases of discussion restriction (openedx#556) * test: added test cases of discussion restriction * refactor: added null default value for dataTestId --------- Co-authored-by: SundasNoreen <[email protected]> * fix: Add enabled badge to xpert settings tile (openedx#566) * feat: Add "Enabled" badge to xpert settings tile * fix: Update model with state instead of non-existent prop from response * feat: bump frontend-lib-content-components (openedx#569) * feat: Added Schedule and Details MFE page (openedx#547) * refactor: some refactoring --------- Co-authored-by: David Nuon <[email protected]> Co-authored-by: Zachary Hancock <[email protected]> Co-authored-by: Kristin Aoki <[email protected]> Co-authored-by: sundasnoreen12 <[email protected]> Co-authored-by: SundasNoreen <[email protected]> Co-authored-by: Raymond Zhou <[email protected]> Co-authored-by: ruzniaievdm <[email protected]>
* feat: moving new commits from upstream repository (#62) * feat: configuration for xpert unit summaries (openedx#540) Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2 * fix: load up-to-date config on studio fetch (openedx#548) * refactor: added PropTypes declarations * feat: add files and uploads page (openedx#541) * fix: remove env variable for files and uploads (openedx#549) * Update verbiage for Xpert Settings (openedx#550) * chore: Update verbiage for Xpert configuration screen * fix: Change "generate" to "display" in xpert modal text * fix: Updated learn more link * fix: Change link and add targets * test: added test cases for hide discussion tab (openedx#552) Co-authored-by: SundasNoreen <[email protected]> * feat: upgrade frontend-lib-content-components (openedx#554) * feat: bump frontend-lib-content-components (openedx#559) * fix: Change wording to not crowd xpert tile in preferences page (openedx#560) * fix: width and height of asset preview (openedx#558) * feat: flcc to 1.168.0 (openedx#561) * feat: bump frontend-lib-content-components (openedx#562) * fix: overflow-y scroll behavior (openedx#565) * test: added test cases of discussion restriction (openedx#556) * test: added test cases of discussion restriction * refactor: added null default value for dataTestId --------- Co-authored-by: SundasNoreen <[email protected]> * fix: Add enabled badge to xpert settings tile (openedx#566) * feat: Add "Enabled" badge to xpert settings tile * fix: Update model with state instead of non-existent prop from response * feat: bump frontend-lib-content-components (openedx#569) * feat: Added Schedule and Details MFE page (openedx#547) * refactor: some refactoring --------- Co-authored-by: David Nuon <[email protected]> Co-authored-by: Zachary Hancock <[email protected]> Co-authored-by: Kristin Aoki <[email protected]> Co-authored-by: sundasnoreen12 <[email protected]> Co-authored-by: SundasNoreen <[email protected]> Co-authored-by: Raymond Zhou <[email protected]> Co-authored-by: ruzniaievdm <[email protected]> * fix: Course updates - wrong datepicker value (#65) * fix: [2u-631] fixed date checking * fix: [2u-631] fixed validation schema * fix: [2u-631] fixed indents * feat: Course outline - Section highlights (#60) * feat: [2u-336] add tests * feat: [2u-271] fix button * feat: [2u-336] add component, refactor header * feat: [2u-342] add modal * fix: [2u-342] fix translates and indents * feat: [2u-342] add modal * feat: [2u-342] add api * feat: [2u-342] add tests and translates * feat: [2u-342] fix indents * fix: [2u-342] fix indents, variant and utils * feat: [2u-342] fixed slice, thunks, hooks * fix: [2u-342] fix translates * fix: [2u-342] fix api --------- Co-authored-by: Vladislav Keblysh <[email protected]> * feat: create organization filter on home page --------- Co-authored-by: Peter Kulko <[email protected]> Co-authored-by: David Nuon <[email protected]> Co-authored-by: Zachary Hancock <[email protected]> Co-authored-by: Kristin Aoki <[email protected]> Co-authored-by: sundasnoreen12 <[email protected]> Co-authored-by: SundasNoreen <[email protected]> Co-authored-by: Raymond Zhou <[email protected]> Co-authored-by: vladislavkeblysh <[email protected]> Co-authored-by: Vladislav Keblysh <[email protected]>
Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2
Add new section and configuration for Xpert Unit Summaries
Used to configure: edx/ai-aside#38
Screencasts
The dialog option
Screen.Recording.2023-07-25.at.10.06.27.AM.mov
Toggling showing the config option in the Pages and Resources screen
Screen.Recording.2023-07-31.at.10.19.18.AM.mov