Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configuration for xpert unit summaries #540

Merged
merged 12 commits into from
Aug 1, 2023

Conversation

davidnuon
Copy link
Member

@davidnuon davidnuon commented Jul 25, 2023

Add new section and configuration for Xpert Unit Summaries

Used to configure: edx/ai-aside#38

Screencasts

The dialog option

Screen.Recording.2023-07-25.at.10.06.27.AM.mov

Toggling showing the config option in the Pages and Resources screen

Screen.Recording.2023-07-31.at.10.19.18.AM.mov

@davidnuon davidnuon changed the title [wip] feat: configuration for xpert unit summaries [wip] [don't merge] feat: configuration for xpert unit summaries Jul 25, 2023
@davidnuon davidnuon changed the title [wip] [don't merge] feat: configuration for xpert unit summaries feat: configuration for xpert unit summaries Jul 25, 2023
Adds setting modal for Xpert unit summaries
@davidnuon davidnuon force-pushed the davidnuon/configuration-for-xpert-summaries branch from 715bbb7 to 04d2312 Compare July 25, 2023 17:10
Copy link

@aethant aethant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to fix spacing issues on the one file, otherwise, lgtm

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 85.24% and project coverage change: +0.34% 🎉

Comparison is base (8bfc3f2) 78.20% compared to head (d478ead) 78.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
+ Coverage   78.20%   78.54%   +0.34%     
==========================================
  Files         145      151       +6     
  Lines        2698     2820     +122     
  Branches      632      661      +29     
==========================================
+ Hits         2110     2215     +105     
- Misses        558      574      +16     
- Partials       30       31       +1     
Files Changed Coverage Δ
src/pages-and-resources/messages.js 100.00% <ø> (ø)
src/pages-and-resources/PagesAndResources.jsx 61.29% <66.66%> (-2.71%) ⬇️
...pert-unit-summary/settings-modal/SettingsModal.jsx 79.66% <79.66%> (ø)
...es-and-resources/xpert-unit-summary/data/thunks.js 87.87% <87.87%> (ø)
...es/xpert-unit-summary/XpertUnitSummarySettings.jsx 100.00% <100.00%> (ø)
...pages-and-resources/xpert-unit-summary/data/api.js 100.00% <100.00%> (ø)
...pages-and-resources/xpert-unit-summary/messages.js 100.00% <100.00%> (ø)
...rces/xpert-unit-summary/settings-modal/messages.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schenedx
Copy link
Contributor

Is your plan to write unit test together in this PR? That make sense. This early view makes reviewing much easier than with all those spec files.

Copy link
Member

@rijuma rijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just left a comment for the use of awaits on state setters.
It would be awesome if PRs with UI changes get also some screenshots for context.

@davidnuon
Copy link
Member Author

Is your plan to write unit test together in this PR? That make sense. This early view makes reviewing much easier than with all those spec files.

yep, that's the plan

@davidnuon davidnuon changed the title feat: configuration for xpert unit summaries [wip] [do no merge] feat: configuration for xpert unit summaries Jul 25, 2023
@davidnuon davidnuon force-pushed the davidnuon/configuration-for-xpert-summaries branch from bcc8f7b to ed4ba40 Compare July 31, 2023 17:06
@davidnuon davidnuon force-pushed the davidnuon/configuration-for-xpert-summaries branch from 6613314 to a43ed0b Compare July 31, 2023 19:45
@davidnuon davidnuon changed the title [wip] [do no merge] feat: configuration for xpert unit summaries feat: configuration for xpert unit summaries Jul 31, 2023
Copy link

@ashultz0 ashultz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

things I wanted are all set :)

@ashultz0 ashultz0 merged commit 1dba620 into master Aug 1, 2023
5 checks passed
@ashultz0 ashultz0 deleted the davidnuon/configuration-for-xpert-summaries branch August 1, 2023 13:07
PKulkoRaccoonGang pushed a commit to raccoongang/frontend-app-course-authoring that referenced this pull request Aug 21, 2023
Adds setting modal for Xpert unit summaries

Includes hiding the config section for xpert summary - 
this is done based on a flag from edx/ai-aside@3d113d2
wowkalucky pushed a commit to raccoongang/frontend-app-course-authoring that referenced this pull request Aug 22, 2023
* feat: configuration for xpert unit summaries (openedx#540)

Adds setting modal for Xpert unit summaries

Includes hiding the config section for xpert summary - 
this is done based on a flag from edx/ai-aside@3d113d2

* fix: load up-to-date config on studio fetch (openedx#548)

* refactor: added PropTypes declarations

* feat: add files and uploads page (openedx#541)

* fix: remove env variable for files and uploads (openedx#549)

* Update verbiage for Xpert Settings (openedx#550)

* chore: Update verbiage for Xpert configuration screen

* fix: Change "generate" to "display" in xpert modal text

* fix: Updated learn more link

* fix: Change link and add targets

* test: added test cases for hide discussion tab (openedx#552)

Co-authored-by: SundasNoreen <[email protected]>

* feat: upgrade frontend-lib-content-components (openedx#554)

* feat: bump frontend-lib-content-components (openedx#559)

* fix: Change wording to not crowd xpert tile in preferences page (openedx#560)

* fix: width and height of asset preview (openedx#558)

* feat: flcc to 1.168.0 (openedx#561)

* feat: bump frontend-lib-content-components (openedx#562)

* fix: overflow-y scroll behavior (openedx#565)

* test: added test cases of discussion restriction (openedx#556)

* test: added test cases of discussion restriction

* refactor: added null default value for dataTestId

---------

Co-authored-by: SundasNoreen <[email protected]>

* fix: Add enabled badge to xpert settings tile  (openedx#566)

* feat: Add "Enabled" badge to xpert settings tile

* fix: Update model with state instead of non-existent prop from response

* feat: bump frontend-lib-content-components (openedx#569)

* feat: Added Schedule and Details MFE page (openedx#547)

* refactor: some refactoring

---------

Co-authored-by: David Nuon <[email protected]>
Co-authored-by: Zachary Hancock <[email protected]>
Co-authored-by: Kristin Aoki <[email protected]>
Co-authored-by: sundasnoreen12 <[email protected]>
Co-authored-by: SundasNoreen <[email protected]>
Co-authored-by: Raymond Zhou <[email protected]>
Co-authored-by: ruzniaievdm <[email protected]>
wowkalucky pushed a commit to raccoongang/frontend-app-course-authoring that referenced this pull request Aug 23, 2023
* feat: moving new commits from upstream repository (#62)

* feat: configuration for xpert unit summaries (openedx#540)

Adds setting modal for Xpert unit summaries

Includes hiding the config section for xpert summary - 
this is done based on a flag from edx/ai-aside@3d113d2

* fix: load up-to-date config on studio fetch (openedx#548)

* refactor: added PropTypes declarations

* feat: add files and uploads page (openedx#541)

* fix: remove env variable for files and uploads (openedx#549)

* Update verbiage for Xpert Settings (openedx#550)

* chore: Update verbiage for Xpert configuration screen

* fix: Change "generate" to "display" in xpert modal text

* fix: Updated learn more link

* fix: Change link and add targets

* test: added test cases for hide discussion tab (openedx#552)

Co-authored-by: SundasNoreen <[email protected]>

* feat: upgrade frontend-lib-content-components (openedx#554)

* feat: bump frontend-lib-content-components (openedx#559)

* fix: Change wording to not crowd xpert tile in preferences page (openedx#560)

* fix: width and height of asset preview (openedx#558)

* feat: flcc to 1.168.0 (openedx#561)

* feat: bump frontend-lib-content-components (openedx#562)

* fix: overflow-y scroll behavior (openedx#565)

* test: added test cases of discussion restriction (openedx#556)

* test: added test cases of discussion restriction

* refactor: added null default value for dataTestId

---------

Co-authored-by: SundasNoreen <[email protected]>

* fix: Add enabled badge to xpert settings tile  (openedx#566)

* feat: Add "Enabled" badge to xpert settings tile

* fix: Update model with state instead of non-existent prop from response

* feat: bump frontend-lib-content-components (openedx#569)

* feat: Added Schedule and Details MFE page (openedx#547)

* refactor: some refactoring

---------

Co-authored-by: David Nuon <[email protected]>
Co-authored-by: Zachary Hancock <[email protected]>
Co-authored-by: Kristin Aoki <[email protected]>
Co-authored-by: sundasnoreen12 <[email protected]>
Co-authored-by: SundasNoreen <[email protected]>
Co-authored-by: Raymond Zhou <[email protected]>
Co-authored-by: ruzniaievdm <[email protected]>

* fix: Course updates - wrong datepicker value (#65)

* fix: [2u-631] fixed date checking

* fix: [2u-631] fixed validation schema

* fix: [2u-631] fixed indents

* feat: Course outline - Section highlights (#60)

* feat: [2u-336] add tests

* feat: [2u-271] fix button

* feat: [2u-336] add component, refactor header

* feat: [2u-342] add modal

* fix: [2u-342] fix translates and indents

* feat: [2u-342] add modal

* feat: [2u-342] add api

* feat: [2u-342] add tests and translates

* feat: [2u-342] fix indents

* fix: [2u-342] fix indents, variant and utils

* feat: [2u-342] fixed slice, thunks, hooks

* fix: [2u-342] fix translates

* fix: [2u-342] fix api

---------

Co-authored-by: Vladislav Keblysh <[email protected]>

* feat: create organization filter on home page

---------

Co-authored-by: Peter Kulko <[email protected]>
Co-authored-by: David Nuon <[email protected]>
Co-authored-by: Zachary Hancock <[email protected]>
Co-authored-by: Kristin Aoki <[email protected]>
Co-authored-by: sundasnoreen12 <[email protected]>
Co-authored-by: SundasNoreen <[email protected]>
Co-authored-by: Raymond Zhou <[email protected]>
Co-authored-by: vladislavkeblysh <[email protected]>
Co-authored-by: Vladislav Keblysh <[email protected]>
snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
Adds setting modal for Xpert unit summaries

Includes hiding the config section for xpert summary - 
this is done based on a flag from edx/ai-aside@3d113d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants