fix: width and height of asset preview #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #558 +/- ##
==========================================
+ Coverage 81.32% 81.42% +0.10%
==========================================
Files 234 234
Lines 3812 3811 -1
Branches 873 870 -3
==========================================
+ Hits 3100 3103 +3
+ Misses 675 671 -4
Partials 37 37
☔ View full report in Codecov by Sentry. |
|
Can you include a screenshot so I don't have to manually test this? |
connorhaugh
approved these changes
Aug 10, 2023
PKulkoRaccoonGang
pushed a commit
to raccoongang/frontend-app-course-authoring
that referenced
this pull request
Aug 21, 2023
wowkalucky
pushed a commit
to raccoongang/frontend-app-course-authoring
that referenced
this pull request
Aug 22, 2023
* feat: configuration for xpert unit summaries (openedx#540) Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2 * fix: load up-to-date config on studio fetch (openedx#548) * refactor: added PropTypes declarations * feat: add files and uploads page (openedx#541) * fix: remove env variable for files and uploads (openedx#549) * Update verbiage for Xpert Settings (openedx#550) * chore: Update verbiage for Xpert configuration screen * fix: Change "generate" to "display" in xpert modal text * fix: Updated learn more link * fix: Change link and add targets * test: added test cases for hide discussion tab (openedx#552) Co-authored-by: SundasNoreen <[email protected]> * feat: upgrade frontend-lib-content-components (openedx#554) * feat: bump frontend-lib-content-components (openedx#559) * fix: Change wording to not crowd xpert tile in preferences page (openedx#560) * fix: width and height of asset preview (openedx#558) * feat: flcc to 1.168.0 (openedx#561) * feat: bump frontend-lib-content-components (openedx#562) * fix: overflow-y scroll behavior (openedx#565) * test: added test cases of discussion restriction (openedx#556) * test: added test cases of discussion restriction * refactor: added null default value for dataTestId --------- Co-authored-by: SundasNoreen <[email protected]> * fix: Add enabled badge to xpert settings tile (openedx#566) * feat: Add "Enabled" badge to xpert settings tile * fix: Update model with state instead of non-existent prop from response * feat: bump frontend-lib-content-components (openedx#569) * feat: Added Schedule and Details MFE page (openedx#547) * refactor: some refactoring --------- Co-authored-by: David Nuon <[email protected]> Co-authored-by: Zachary Hancock <[email protected]> Co-authored-by: Kristin Aoki <[email protected]> Co-authored-by: sundasnoreen12 <[email protected]> Co-authored-by: SundasNoreen <[email protected]> Co-authored-by: Raymond Zhou <[email protected]> Co-authored-by: ruzniaievdm <[email protected]>
wowkalucky
pushed a commit
to raccoongang/frontend-app-course-authoring
that referenced
this pull request
Aug 23, 2023
* feat: moving new commits from upstream repository (#62) * feat: configuration for xpert unit summaries (openedx#540) Adds setting modal for Xpert unit summaries Includes hiding the config section for xpert summary - this is done based on a flag from edx/ai-aside@3d113d2 * fix: load up-to-date config on studio fetch (openedx#548) * refactor: added PropTypes declarations * feat: add files and uploads page (openedx#541) * fix: remove env variable for files and uploads (openedx#549) * Update verbiage for Xpert Settings (openedx#550) * chore: Update verbiage for Xpert configuration screen * fix: Change "generate" to "display" in xpert modal text * fix: Updated learn more link * fix: Change link and add targets * test: added test cases for hide discussion tab (openedx#552) Co-authored-by: SundasNoreen <[email protected]> * feat: upgrade frontend-lib-content-components (openedx#554) * feat: bump frontend-lib-content-components (openedx#559) * fix: Change wording to not crowd xpert tile in preferences page (openedx#560) * fix: width and height of asset preview (openedx#558) * feat: flcc to 1.168.0 (openedx#561) * feat: bump frontend-lib-content-components (openedx#562) * fix: overflow-y scroll behavior (openedx#565) * test: added test cases of discussion restriction (openedx#556) * test: added test cases of discussion restriction * refactor: added null default value for dataTestId --------- Co-authored-by: SundasNoreen <[email protected]> * fix: Add enabled badge to xpert settings tile (openedx#566) * feat: Add "Enabled" badge to xpert settings tile * fix: Update model with state instead of non-existent prop from response * feat: bump frontend-lib-content-components (openedx#569) * feat: Added Schedule and Details MFE page (openedx#547) * refactor: some refactoring --------- Co-authored-by: David Nuon <[email protected]> Co-authored-by: Zachary Hancock <[email protected]> Co-authored-by: Kristin Aoki <[email protected]> Co-authored-by: sundasnoreen12 <[email protected]> Co-authored-by: SundasNoreen <[email protected]> Co-authored-by: Raymond Zhou <[email protected]> Co-authored-by: ruzniaievdm <[email protected]> * fix: Course updates - wrong datepicker value (#65) * fix: [2u-631] fixed date checking * fix: [2u-631] fixed validation schema * fix: [2u-631] fixed indents * feat: Course outline - Section highlights (#60) * feat: [2u-336] add tests * feat: [2u-271] fix button * feat: [2u-336] add component, refactor header * feat: [2u-342] add modal * fix: [2u-342] fix translates and indents * feat: [2u-342] add modal * feat: [2u-342] add api * feat: [2u-342] add tests and translates * feat: [2u-342] fix indents * fix: [2u-342] fix indents, variant and utils * feat: [2u-342] fixed slice, thunks, hooks * fix: [2u-342] fix translates * fix: [2u-342] fix api --------- Co-authored-by: Vladislav Keblysh <[email protected]> * feat: create organization filter on home page --------- Co-authored-by: Peter Kulko <[email protected]> Co-authored-by: David Nuon <[email protected]> Co-authored-by: Zachary Hancock <[email protected]> Co-authored-by: Kristin Aoki <[email protected]> Co-authored-by: sundasnoreen12 <[email protected]> Co-authored-by: SundasNoreen <[email protected]> Co-authored-by: Raymond Zhou <[email protected]> Co-authored-by: vladislavkeblysh <[email protected]> Co-authored-by: Vladislav Keblysh <[email protected]>
snglth
pushed a commit
to Abstract-Tech/community-theme-course-authoring
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: TNL-10951
expected:
Test