Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overflow-y scroll behavior #565

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: overflow-y scroll behavior #565

merged 1 commit into from
Aug 14, 2023

Conversation

KristinAoki
Copy link
Member

JIRA Ticket: TNL-10981

Test:

  1. Create a custom page
  2. Edit the custom page
  3. Add a lot of text to the editor
  4. Editor should scroll as content is add an expands past the viewport
  5. Save content
  6. Reopen edit view of page
  7. Should be able to scroll and see all of content

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dc07623) 81.42% compared to head (4cd3596) 81.42%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #565   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files         234      234           
  Lines        3811     3811           
  Branches      870      870           
=======================================
  Hits         3103     3103           
  Misses        671      671           
  Partials       37       37
Files Changed Coverage Δ
src/custom-pages/EditModal.jsx 66.66% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rayzhou-bit
rayzhou-bit approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@rayzhou-bit rayzhou-bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test but I don't expect this to be breaking anything.

lgtm!

@KristinAoki KristinAoki merged commit 484b141 into master Aug 14, 2023
6 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-custom-pages-scroll-bar branch August 14, 2023 16:10
PKulkoRaccoonGang pushed a commit to raccoongang/frontend-app-course-authoring that referenced this pull request Aug 21, 2023
@KristinAoki @PKulkoRaccoonGang
fix: overflow-y scroll behavior (openedx#565)
ef82355
wowkalucky pushed a commit to raccoongang/frontend-app-course-authoring that referenced this pull request Aug 22, 2023
@PKulkoRaccoonGang @davidnuon
@Zacharis278 @KristinAoki @sundasnoreen12 @rayzhou-bit @ruzniaievdm
feat: moving new commits from upstream repository (#62)
506cda9 
* feat: configuration for xpert unit summaries (openedx#540)

Adds setting modal for Xpert unit summaries

Includes hiding the config section for xpert summary - 
this is done based on a flag from edx/ai-aside@3d113d2

* fix: load up-to-date config on studio fetch (openedx#548)

* refactor: added PropTypes declarations

* feat: add files and uploads page (openedx#541)

* fix: remove env variable for files and uploads (openedx#549)

* Update verbiage for Xpert Settings (openedx#550)

* chore: Update verbiage for Xpert configuration screen

* fix: Change "generate" to "display" in xpert modal text

* fix: Updated learn more link

* fix: Change link and add targets

* test: added test cases for hide discussion tab (openedx#552)

Co-authored-by: SundasNoreen <[email protected]>

* feat: upgrade frontend-lib-content-components (openedx#554)

* feat: bump frontend-lib-content-components (openedx#559)

* fix: Change wording to not crowd xpert tile in preferences page (openedx#560)

* fix: width and height of asset preview (openedx#558)

* feat: flcc to 1.168.0 (openedx#561)

* feat: bump frontend-lib-content-components (openedx#562)

* fix: overflow-y scroll behavior (openedx#565)

* test: added test cases of discussion restriction (openedx#556)

* test: added test cases of discussion restriction

* refactor: added null default value for dataTestId

---------

Co-authored-by: SundasNoreen <[email protected]>

* fix: Add enabled badge to xpert settings tile  (openedx#566)

* feat: Add "Enabled" badge to xpert settings tile

* fix: Update model with state instead of non-existent prop from response

* feat: bump frontend-lib-content-components (openedx#569)

* feat: Added Schedule and Details MFE page (openedx#547)

* refactor: some refactoring

---------

Co-authored-by: David Nuon <[email protected]>
Co-authored-by: Zachary Hancock <[email protected]>
Co-authored-by: Kristin Aoki <[email protected]>
Co-authored-by: sundasnoreen12 <[email protected]>
Co-authored-by: SundasNoreen <[email protected]>
Co-authored-by: Raymond Zhou <[email protected]>
Co-authored-by: ruzniaievdm <[email protected]>
wowkalucky pushed a commit to raccoongang/frontend-app-course-authoring that referenced this pull request Aug 23, 2023
@ruzniaievdm @PKulkoRaccoonGang
@davidnuon @Zacharis278 @KristinAoki @sundasnoreen12 @rayzhou-bit @vladislavkeblysh
feat: create organization filter on home page (#54)
2ebfa73 
* feat: moving new commits from upstream repository (#62)

* feat: configuration for xpert unit summaries (openedx#540)

Adds setting modal for Xpert unit summaries

Includes hiding the config section for xpert summary - 
this is done based on a flag from edx/ai-aside@3d113d2

* fix: load up-to-date config on studio fetch (openedx#548)

* refactor: added PropTypes declarations

* feat: add files and uploads page (openedx#541)

* fix: remove env variable for files and uploads (openedx#549)

* Update verbiage for Xpert Settings (openedx#550)

* chore: Update verbiage for Xpert configuration screen

* fix: Change "generate" to "display" in xpert modal text

* fix: Updated learn more link

* fix: Change link and add targets

* test: added test cases for hide discussion tab (openedx#552)

Co-authored-by: SundasNoreen <[email protected]>

* feat: upgrade frontend-lib-content-components (openedx#554)

* feat: bump frontend-lib-content-components (openedx#559)

* fix: Change wording to not crowd xpert tile in preferences page (openedx#560)

* fix: width and height of asset preview (openedx#558)

* feat: flcc to 1.168.0 (openedx#561)

* feat: bump frontend-lib-content-components (openedx#562)

* fix: overflow-y scroll behavior (openedx#565)

* test: added test cases of discussion restriction (openedx#556)

* test: added test cases of discussion restriction

* refactor: added null default value for dataTestId

---------

Co-authored-by: SundasNoreen <[email protected]>

* fix: Add enabled badge to xpert settings tile  (openedx#566)

* feat: Add "Enabled" badge to xpert settings tile

* fix: Update model with state instead of non-existent prop from response

* feat: bump frontend-lib-content-components (openedx#569)

* feat: Added Schedule and Details MFE page (openedx#547)

* refactor: some refactoring

---------

Co-authored-by: David Nuon <[email protected]>
Co-authored-by: Zachary Hancock <[email protected]>
Co-authored-by: Kristin Aoki <[email protected]>
Co-authored-by: sundasnoreen12 <[email protected]>
Co-authored-by: SundasNoreen <[email protected]>
Co-authored-by: Raymond Zhou <[email protected]>
Co-authored-by: ruzniaievdm <[email protected]>

* fix: Course updates - wrong datepicker value (#65)

* fix: [2u-631] fixed date checking

* fix: [2u-631] fixed validation schema

* fix: [2u-631] fixed indents

* feat: Course outline - Section highlights (#60)

* feat: [2u-336] add tests

* feat: [2u-271] fix button

* feat: [2u-336] add component, refactor header

* feat: [2u-342] add modal

* fix: [2u-342] fix translates and indents

* feat: [2u-342] add modal

* feat: [2u-342] add api

* feat: [2u-342] add tests and translates

* feat: [2u-342] fix indents

* fix: [2u-342] fix indents, variant and utils

* feat: [2u-342] fixed slice, thunks, hooks

* fix: [2u-342] fix translates

* fix: [2u-342] fix api

---------

Co-authored-by: Vladislav Keblysh <[email protected]>

* feat: create organization filter on home page

---------

Co-authored-by: Peter Kulko <[email protected]>
Co-authored-by: David Nuon <[email protected]>
Co-authored-by: Zachary Hancock <[email protected]>
Co-authored-by: Kristin Aoki <[email protected]>
Co-authored-by: sundasnoreen12 <[email protected]>
Co-authored-by: SundasNoreen <[email protected]>
Co-authored-by: Raymond Zhou <[email protected]>
Co-authored-by: vladislavkeblysh <[email protected]>
Co-authored-by: Vladislav Keblysh <[email protected]>
snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
@KristinAoki @snglth
fix: overflow-y scroll behavior (openedx#565)
a536cc9
@kenclary kenclary mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayzhou-bit rayzhou-bit rayzhou-bit approved these changes

@kenclary kenclary Awaiting requested review from kenclary

@connorhaugh connorhaugh Awaiting requested review from connorhaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KristinAoki @rayzhou-bit