-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve generated data #10532
fix: improve generated data #10532
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10532 +/- ##
==========================================
- Coverage 49.54% 49.26% -0.29%
==========================================
Files 67 76 +9
Lines 20650 21867 +1217
Branches 4980 5236 +256
==========================================
+ Hits 10231 10772 +541
- Misses 9131 9773 +642
- Partials 1288 1322 +34 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (although I looked at it without knowing the script well).
if (defined $crm_opportunity_id) { | ||
if (exists $opportunities{$crm_opportunity_id}) { | ||
$opportunity_url = $ENV{ODOO_CRM_URL} | ||
. "/web#id=$crm_opportunity_id&cids=1&menu_id=133&action=191&model=crm.lead&view_type=form"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we have a function for that in CRM.pm ?
🤖 I have created a release *beep* *boop* --- ## [2.38.0](v2.37.0...v2.38.0) (2024-07-23) ### Features * add new product event types for redis queue ([#10530](#10530)) ([339dbc4](339dbc4)) * add product data to org table ([#10534](#10534)) ([dce0518](dce0518)) * added a drag and drop zone in pro platform ([#10569](#10569)) ([ce60b8f](ce60b8f)) * allow orgs to not have a main contact if imported from an aggregator ([#10531](#10531)) ([ead1b0c](ead1b0c)) * launch the exports for all organizations that have the checkbox… ([#10561](#10561)) ([c3aa2d1](c3aa2d1)) * Lint spaces in taxonomies ([#10563](#10563)) ([c01cf91](c01cf91)) * make valid org filter field a dropdown ([#10524](#10524)) ([b38e62c](b38e62c)) * measure and log duration of request and mongodb / off-query que… ([#10557](#10557)) ([2cb1b1e](2cb1b1e)) * packaging add Ireland ([#10533](#10533)) ([3f3196e](3f3196e)), closes [#1572](#1572) ### Bug Fixes * add product_type to redis events ([#10550](#10550)) ([6bd1c0e](6bd1c0e)) * added barcode-svg ([#10242](#10242)) ([8da89da](8da89da)) * broken user space on pro platform ([#10541](#10541)) ([b6e3017](b6e3017)) * change_main_contact.pl ([#10548](#10548)) ([b2f90ea](b2f90ea)) * disable caching on pro platform ([#10516](#10516)) ([4ccd714](4ccd714)) * GDSN import from Alnatura ([#10556](#10556)) ([6e2673a](6e2673a)) * improve generated data for a .pl script ([#10532](#10532)) ([1cab04c](1cab04c)) * pro_moderator_owner not stored for the admin/moderator user through org/[orgid] facet ([#10560](#10560)) ([e0441c6](e0441c6)) * rate limiter log config ([#10535](#10535)) ([9a5168d](9a5168d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
What
Overall improvement of the information provided by the csv file generated by the script
scripts/check_if_orgs_can_be_safely_synced_with_crm.pl
We need to run this script in prod