-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: launch the exports for all organizations that have the checkbox… #10561
feat: launch the exports for all organizations that have the checkbox… #10561
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10561 +/- ##
==========================================
- Coverage 49.54% 49.22% -0.33%
==========================================
Files 67 77 +10
Lines 20650 21960 +1310
Branches 4980 5245 +265
==========================================
+ Hits 10231 10809 +578
- Misses 9131 9826 +695
- Partials 1288 1325 +37 ☔ View full report in Codecov by Sentry. |
org-auchan-apaw | ||
org-les-mousquetaires | ||
) | ||
filter_organizations_that_have_automated_export() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shan't we leverage having orgs in MongoDB now and just make a mongoDB request (you can even user mongo client) to get all orgs with activate_automated_daily_export_to_public_platform on ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes I forgot, sure we can do that.
openfoodfacts-server/scripts/export_producers_platform_data_to_public_database.sh
Lines 36 to 39 in b2d3f18
my @res = get_orgs_collection() | |
->find({ activate_automated_daily_export_to_public_platform => "on" }) | |
->fields({ org_id => 1 }) | |
->all; |
use ProductOpener::Data qw/get_orgs_collection/; | ||
|
||
my %producers = map { $_,1 } qw( | ||
org-barilla-france-sa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should remove the hardcoded values, and ensure all those orgs have the checkbox checked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. But I'm not an admin so I can't see the checkbox in the platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Quality Gate passedIssues Measures |
🤖 I have created a release *beep* *boop* --- ## [2.38.0](v2.37.0...v2.38.0) (2024-07-23) ### Features * add new product event types for redis queue ([#10530](#10530)) ([339dbc4](339dbc4)) * add product data to org table ([#10534](#10534)) ([dce0518](dce0518)) * added a drag and drop zone in pro platform ([#10569](#10569)) ([ce60b8f](ce60b8f)) * allow orgs to not have a main contact if imported from an aggregator ([#10531](#10531)) ([ead1b0c](ead1b0c)) * launch the exports for all organizations that have the checkbox… ([#10561](#10561)) ([c3aa2d1](c3aa2d1)) * Lint spaces in taxonomies ([#10563](#10563)) ([c01cf91](c01cf91)) * make valid org filter field a dropdown ([#10524](#10524)) ([b38e62c](b38e62c)) * measure and log duration of request and mongodb / off-query que… ([#10557](#10557)) ([2cb1b1e](2cb1b1e)) * packaging add Ireland ([#10533](#10533)) ([3f3196e](3f3196e)), closes [#1572](#1572) ### Bug Fixes * add product_type to redis events ([#10550](#10550)) ([6bd1c0e](6bd1c0e)) * added barcode-svg ([#10242](#10242)) ([8da89da](8da89da)) * broken user space on pro platform ([#10541](#10541)) ([b6e3017](b6e3017)) * change_main_contact.pl ([#10548](#10548)) ([b2f90ea](b2f90ea)) * disable caching on pro platform ([#10516](#10516)) ([4ccd714](4ccd714)) * GDSN import from Alnatura ([#10556](#10556)) ([6e2673a](6e2673a)) * improve generated data for a .pl script ([#10532](#10532)) ([1cab04c](1cab04c)) * pro_moderator_owner not stored for the admin/moderator user through org/[orgid] facet ([#10560](#10560)) ([e0441c6](e0441c6)) * rate limiter log config ([#10535](#10535)) ([9a5168d](9a5168d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
… checked
What
Instead of listing each organization in scripts/export_producers_platform_data_to_public_database.sh , launch the exports for all organizations that have the checkbox checked.
Related issue(s) and discussion