Fix newlib versions #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Turns out in newlib older than v2.5 they didn't use underscore prefixed names for the to-be-implemented functions which goes against newlibs recommendation. Unfortunately pulp-riscv-gcc uses such an old version and. * Add -lgcc in case we use some software emulation routines
pascalgouedo
pushed a commit
to pascalgouedo/cv32e40p
that referenced
this pull request
Aug 30, 2023
- Fix Underflow flag for MUL and DIV/SQRT operations (openhwgroup#94 openhwgroup#726 openhwgroup#729) - Fix for Float to Int conversion (openhwgroup#97 openhwgroup#83 openhwgroup#727) - Fixed unnecessary trailing semicolon (openhwgroup#99) Signed-off-by: Pascal Gouedo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PULP RISC-V compiler uses an older version of newlib which uses different (not underscored) syscalls stubs (relevant for
tb/core/custom). We add an appropriate version ifdef .