-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: PyAutoGalaxy: Open-Source Multiwavelength Galaxy Structure & Morphology #4475
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@Jammy2211, @alexandergagliano, @sloneil – This is the review thread for the Please read the "Reviewer instructions & questions" in the first comment above to get started. If you get lost, you can also see the reviewer guidelines. You will have to generate your review "checklist" by adding the comment @editorialbot generate my checklist to this thread. To review for JOSS ,@alexandergagliano and @sloneil will step through that checklist for The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention this issue (#4475) so that a link is created to this thread (and I can keep an eye on what is happening). We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. When you're finished with your checklist, leave a comment and @ me to let everyone know your review is complete. |
@alexandergagliano, @sloneil just checking in, please let me know if you have any issues with starting the review! |
@alexandergagliano, @sloneil it seems like you haven't been able to start the review yet, and we kicked off the review close to 4 weeks ago. Can you check in and let us know how you're getting on? |
Review checklist for @sloneilConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@christinahedges thanks for the check-in -- it's taken a little time to get this wrapped up but I'll be sure to finalize the checklist by the end of this week at the latest. |
Review checklist for @alexandergaglianoConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@christinahedges My review is complete. There are some outstanding remaining comments about updating references and a statement on the state of the field, but none are major and it looks like the software comments have all been addressed. |
👋 @Jammy2211 – how are you getting along making your updates based on the reviewer feedback? |
Got overwhemed with deadlines this month, things finally clear up this week so will get them sorted! |
I have respond to all comments and fixed them on the project A |
@alexandergagliano, @sloneil, @Jammy2211 — Hi folks, I wanted to check in here because we're recently switched to a "tracks" model here at JOSS and I'm now the managing editor of the track where this submission has been assigned. It looks like there hasn't been much activity on this review in a while - can you update me on what the status is and if there are any blockers in place that I can help with? Thanks! |
@dfm @Jammy2211 has addressed all my comments, I'm totally on board with this moving forward! |
It's fine with me as well! |
@Jammy2211 — It looks like the only one that is actually used is the ISBN for the "Python Reference Manual" (a citation that I'd probably just remove…). While you're at it, can you also take a look at the Sersic (1968) reference too? It looks like it got mangled somewhere. Otherwise, yes - I think it's fine to remove any other ISBN entries! |
Pushed fixes which I hope sorts everything now. |
@editorialbot recommend-accept |
|
The paper's PDF and metadata files generation produced some warnings that could prevent the final paper to be published. Please fix them before the end of the review process:
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3904, then you can now move forward with accepting the submission by compiling again with the command |
|
PR merged and proofs look good to me! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3912, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Many thanks to @alexandergagliano and @sloneil for reviewing and to @christinahedges for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!! @Jammy2211 — Your paper is now accepted and published in JOSS! ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @Jammy2211 (James Nightingale)
Repository: https://github.com/Jammy2211/PyAutoGalaxy
Branch with paper.md (empty if default branch):
Version: 2023.1.15.1
Editor: @christinahedges
Reviewers: @alexandergagliano, @sloneil
Archive: 10.5281/zenodo.7546915
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@alexandergagliano & @sloneil, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @christinahedges know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @sloneil
📝 Checklist for @alexandergagliano
The text was updated successfully, but these errors were encountered: