[Feature Anywhere] add category option for context menus #4146
Conversation
Signed-off-by: David Sinclair <[email protected]>
sikhote
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu and
manasvinibs
as code owners
|
FYI @lezzago |
Codecov Report
@@ Coverage Diff @@
## feature/feature-anywhere #4146 +/- ##
============================================================
+ Coverage 66.44% 66.53% +0.08%
============================================================
Files 3247 3247
Lines 62553 62571 +18
Branches 9659 9667 +8
============================================================
+ Hits 41563 41630 +67
+ Misses 18676 18625 -51
- Partials 2314 2316 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * The OpenSearch Contributors require contributions made to | ||
| * this file be licensed under the Apache-2.0 license or a | ||
| * compatible open source license. | ||
| * | ||
| * Any modifications Copyright OpenSearch Contributors. See | ||
| * GitHub history for details. | ||
| */ | ||
|
|
||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ |
There was a problem hiding this comment.
For new files we can use the shortened header:
/*
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*/
Signed-off-by: David Sinclair <[email protected]>
|
This branch is now updated with changes from #4144, mostly incase we are not ready to pull |
|
@sikhote This PR still has conflicts to resolve. The unit tests are also failing: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/5141644713/jobs/9254367815?pr=4146 |
Now that #4144 has merged to main, I think a merge of main -> feature branch should be sufficient. |
|
Just a heads up, this was always more of a convenience branch until |
…ion-for-context-menus-feature-anywhere
|
Closing as no longer need (no diff with feature branch) |
This includes these changes #4144 and the changes already merged here #3924
Description
This allows a group within a context menu to be categorized and presented adjacent to other groups. Typically, a group is divided by a separator from other groups, but sometimes we want to present groups related to the same feature next to each other. By adding a
categoryoption to a group, we can accomplish this.Issues Resolved
#4073
Screenshot
Testing the changes
These changes can be tested using the regular testing suite, or by visiting the example page locally at http://localhost:5601/app/uiActionsExplorer
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr