Enhance grouping for context menu options #3991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes header change * Update src/core/public/chrome/ui/header/header_help_menu.tsx * fixes snapshots --------- (cherry picked from commit 3cca088) Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
…ion (opensearch-project#3912) Signed-off-by: Kristen Tian <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
…ods (opensearch-project#3733)" (opensearch-project#3929) This reverts commit ffe4556.
…pensearch-project#3922) History push will just to the current route. However, dashboardsProvider was implemented with the expectation that it was a different app. So when a plugin registered it was attempting to navigate to `app/dashboard#/app/{url}` Add tests and extra data test subject. Signed-off-by: Kawika Avilla <[email protected]>
…opensearch-project#3930) Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]>
* Update js-yaml to 4.0.5 (opensearch-project#3659) * Update CHANGELOG.md (opensearch-project#3659) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Josh Romero <[email protected]>
* Update README.md Signed-off-by: Melissa Vagi <[email protected]> * Update README.md Co-authored-by: Miki <[email protected]> --------- Signed-off-by: Melissa Vagi <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Miki <[email protected]>
Signed-off-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Sean Neumann <[email protected]>
…a nested dependency (opensearch-project#3952) Signed-off-by: Miki <[email protected]>
* docs(COMMUNICATION): Add communication guide with info on slack, forum, and developer office hours link from README, CONTRIBUTING, DEVELOPER_GUIDE Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]>
…pensearch-project#3976) The latest version of chromedriver is 112.0.1 which does not support node 14. This PR hardcodes chromedriver to 112.0.0 temporarily. Pls revert it once we bump to node 18. Issue Resolved opensearch-project#3975 Signed-off-by: ananzh <[email protected]>
…ch-project#3911) * Fix wording and duplicate code in embeddable example plugin Signed-off-by: abbyhu2000 <[email protected]> * Fix some wording in the embeddable readme Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]>
sikhote
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu and
manasvinibs
as code owners
lezzago
approved these changes
May 9, 2023
Within the CI, the virtual runner that we are utilizing has Chrome installed already. The version of Chrome is installed periodically. The most recent version of Chrome requires updates to dependencies that drop support for Node 14. This downloads chrome in the CI and then checks the chromedriver from the environment variable `TEST_BROWSER_BINARY_PATH`. Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
…m:sikhote/OpenSearch-Dashboards into enhance-grouping-for-context-menu-options Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
…m:sikhote/OpenSearch-Dashboards into enhance-grouping-for-context-menu-options Signed-off-by: David Sinclair <[email protected]>
|
Updated slightly, see #3924 for details. |
Initial page size was passed to the search function instead of the listing limit causing the max amount received to be significantly less than the previously implementation. Saved objects per page is `20` by default and the listing limit per page is `1000` by default. Issue: opensearch-project#4017 Signed-off-by: Kawika Avilla <[email protected]>
Codecov Report
@@ Coverage Diff @@
## feature/feature-anywhere #3991 +/- ##
============================================================
+ Coverage 66.44% 66.48% +0.04%
============================================================
Files 3208 3246 +38
Lines 61744 63075 +1331
Branches 9537 9815 +278
============================================================
+ Hits 41023 41938 +915
- Misses 18431 18784 +353
- Partials 2290 2353 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* Update find_test_subject imports for tests Signed-off-by: Alexei Karikov <[email protected]> * Update to available imports for findTestSubject Signed-off-by: Alexei Karikov <[email protected]> * Fix available import for Query and custom icon Signed-off-by: Alexei Karikov <[email protected]> * Add changelog entry Signed-off-by: Alexei Karikov <[email protected]> * Add ts-ignore Signed-off-by: Alexei Karikov <[email protected]> --------- Signed-off-by: Alexei Karikov <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]>
… (opensearch-project#3978) Signed-off-by: Sergey Myssak <[email protected]> Co-authored-by: Andrey Myssak <[email protected]>
…ct#4040) * Fixes code coverage workflow failures for the project test due to inderect flakey changes Signed-off-by: Ashwin P Chandran <[email protected]> * Adds changelog Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]>
…-project#4042) Signed-off-by: Ashwin P Chandran <[email protected]>
…oject#3908) Remove re2 usage and replace it with JavaScript built-in RegExp object. Also add more unit tests to make sure that using RegExp has same expressions as using re2 library. Issue Resolve opensearch-project#3901 Signed-off-by: Anan Zhuang <[email protected]>
…nsearch-project#3993) * remove unused ul element Signed-off-by: Sirazh Gabdullin <[email protected]> * Update CHANGELOG.md Signed-off-by: Sirazh Gabdullin <[email protected]> --------- Signed-off-by: Sirazh Gabdullin <[email protected]>
…#4063) * Add release note for 1.3.10 * Address comments and add one CVE PR --------- (cherry picked from commit 4371587) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…h-project#3957) * [Multiple Datasource]Support Amazon OpenSearch Serverless in SigV4 * remove experimental text in yml * Refactor create data source form for authentication Signed-off-by: Su <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
…m:sikhote/OpenSearch-Dashboards into enhance-grouping-for-context-menu-options Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
* Remove Sass from tile_map plugin Signed-off-by: Matt Provost <[email protected]> * Update changelog Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]>
…pensearch-project#3954) * Adds design document for new saved object service interface for custom repository Signed-off-by: Bandini Bhopi <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
|
Closing in favor of #4146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the same request as #3924 , but looking to merge here as well for getting the content menu changes into our feature branch.
Issues Resolved
#3171
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr