-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NMO & FAR upgrade installation test in OCP-e2e #51516
NMO & FAR upgrade installation test in OCP-e2e #51516
Conversation
… 4.12-4.15 Make the OCP-e2e cluster test a three-step test- installing the old version, updating to the latest, and testing the E2E test
Make the OCP-e2e cluster test a three-step test- installing the old version, updating to the latest, and testing the E2E test
/pj-rehearse max |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse auto-ack |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.13-openshift-e2e |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.14-openshift-e2e |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.15-openshift-e2e |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-medik8s-fence-agents-remediation-main-4.12-openshift-e2e |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.15-openshift-e2e |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.14-openshift-e2e |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.13-openshift-e2e |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
E2E test of FAR 4.12 was expecting to run the out-of-service tests but it isn't supported on OCP 4.12
/pj-rehearse max |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
[REHEARSALNOTIFIER]
A total of 36 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.12-openshift-e2e |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.13-openshift-e2e |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.14-openshift-e2e |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/retest |
/pj-rehearse pull-ci-medik8s-fence-agents-remediation-main-4.15-openshift-e2e |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-medik8s-fence-agents-remediation-main-4.14-openshift-e2e |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@razo7: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/pj-rehearse ack |
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mshitrit, razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
oc label --overwrite ns "$OPERATOR_NAMESPACE" pod-security.kubernetes.io/enforce=privileged | ||
|
||
# OPERATOR_NAMESPACE variable is used by bundle-run and bundle-run-update | ||
BUNDLE_IMG=quay.io/medik8s/node-maintenance-operator-bundle:v0.17.0 make bundle-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
I think it might be easy to forget to update the last released version tag (here 0.17.0) and so only test the update from "some version in the past".
We might make this version stand up a bit more, either with some Env variable to be set, or just with a comment (or both :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, next time we add OCP 4.17 or release branch we should use this value as an env variable for better visibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not this time? :)
/unhold |
openshift#51516) * Include NMO upgrade installation test in OCP-e2e cluster test for OCP 4.12-4.15 Make the OCP-e2e cluster test a three-step test- installing the old version, updating to the latest, and testing the E2E test * Include FAR upgrade installation test in OCP-e2e cluster test Make the OCP-e2e cluster test a three-step test- installing the old version, updating to the latest, and testing the E2E test * Skip out-of-service test on OCP 4.12 and FAR E2E test of FAR 4.12 was expecting to run the out-of-service tests but it isn't supported on OCP 4.12
Make the OCP-e2e cluster test a three-step test- installing the old version, updating to the latest, and testing the E2E test.
ECOPROJECT-1082