Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMO & FAR upgrade installation test in OCP-e2e #51516

Merged
merged 3 commits into from
May 6, 2024

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Apr 30, 2024

Make the OCP-e2e cluster test a three-step test- installing the old version, updating to the latest, and testing the E2E test.

  1. Do it for NMO 4.12-4.15 OCP as a follow-up to Test NMO operator upgrade from v0.17.0 to latest #50559
  2. Do it for FAR as a follow-up to Update bundle image medik8s/fence-agents-remediation#139

ECOPROJECT-1082

… 4.12-4.15

Make the OCP-e2e cluster test a three-step test- installing the old version, updating to the latest, and testing the E2E test
Make the OCP-e2e cluster test a three-step test- installing the old version, updating to the latest, and testing the E2E test
@razo7
Copy link
Member Author

razo7 commented Apr 30, 2024

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented Apr 30, 2024

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot requested review from beekhof and clobrano April 30, 2024 12:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
@razo7
Copy link
Member Author

razo7 commented Apr 30, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.13-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented Apr 30, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.14-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented Apr 30, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.15-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented Apr 30, 2024

/pj-rehearse pull-ci-medik8s-fence-agents-remediation-main-4.12-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented Apr 30, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.15-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented Apr 30, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.14-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented Apr 30, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.13-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

E2E test of FAR 4.12 was expecting to run the out-of-service tests but it isn't supported on OCP 4.12
@razo7
Copy link
Member Author

razo7 commented May 1, 2024

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@razo7: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-medik8s-node-maintenance-operator-main-4.14-ci-bundle-my-bundle medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.14-images medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.14-openshift-e2e medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.14-test medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.13-ci-bundle-my-bundle medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.13-images medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.13-openshift-e2e medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.13-test medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.12-ci-bundle-my-bundle medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.12-images medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.12-openshift-e2e medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.12-test medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.15-ci-bundle-my-bundle medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.15-images medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.15-openshift-e2e medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-node-maintenance-operator-main-4.15-test medik8s/node-maintenance-operator presubmit Ci-operator config changed
pull-ci-medik8s-fence-agents-remediation-main-4.15-ci-bundle-my-bundle medik8s/fence-agents-remediation presubmit Ci-operator config changed
pull-ci-medik8s-fence-agents-remediation-main-4.15-images medik8s/fence-agents-remediation presubmit Ci-operator config changed
pull-ci-medik8s-fence-agents-remediation-main-4.15-openshift-e2e medik8s/fence-agents-remediation presubmit Ci-operator config changed
pull-ci-medik8s-fence-agents-remediation-main-4.15-test medik8s/fence-agents-remediation presubmit Ci-operator config changed
pull-ci-medik8s-fence-agents-remediation-main-4.12-ci-bundle-my-bundle medik8s/fence-agents-remediation presubmit Ci-operator config changed
pull-ci-medik8s-fence-agents-remediation-main-4.12-images medik8s/fence-agents-remediation presubmit Ci-operator config changed
pull-ci-medik8s-fence-agents-remediation-main-4.12-openshift-e2e medik8s/fence-agents-remediation presubmit Ci-operator config changed
pull-ci-medik8s-fence-agents-remediation-main-4.12-test medik8s/fence-agents-remediation presubmit Ci-operator config changed
pull-ci-medik8s-fence-agents-remediation-main-4.16-ci-bundle-my-bundle medik8s/fence-agents-remediation presubmit Ci-operator config changed

A total of 36 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@razo7
Copy link
Member Author

razo7 commented May 1, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.12-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented May 1, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.13-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented May 1, 2024

/pj-rehearse pull-ci-medik8s-node-maintenance-operator-main-4.14-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented May 1, 2024

/retest

@razo7
Copy link
Member Author

razo7 commented May 1, 2024

/pj-rehearse pull-ci-medik8s-fence-agents-remediation-main-4.15-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@razo7
Copy link
Member Author

razo7 commented May 1, 2024

/pj-rehearse pull-ci-medik8s-fence-agents-remediation-main-4.14-openshift-e2e

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented May 1, 2024

@razo7: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@razo7
Copy link
Member Author

razo7 commented May 1, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 1, 2024
@mshitrit
Copy link
Contributor

mshitrit commented May 1, 2024

/lgtm
/hold
giving others chance to review as well

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2024
Copy link
Contributor

openshift-ci bot commented May 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

oc label --overwrite ns "$OPERATOR_NAMESPACE" pod-security.kubernetes.io/enforce=privileged

# OPERATOR_NAMESPACE variable is used by bundle-run and bundle-run-update
BUNDLE_IMG=quay.io/medik8s/node-maintenance-operator-bundle:v0.17.0 make bundle-run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit
I think it might be easy to forget to update the last released version tag (here 0.17.0) and so only test the update from "some version in the past".

We might make this version stand up a bit more, either with some Env variable to be set, or just with a comment (or both :) )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, next time we add OCP 4.17 or release branch we should use this value as an env variable for better visibility.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not this time? :)

@razo7
Copy link
Member Author

razo7 commented May 6, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 10e1a03 into openshift:master May 6, 2024
43 checks passed
@razo7 razo7 changed the title Include NMO upgrade installation test in OCP-e2e cluster test for OCP… NMO & FAR upgrade installation test in OCP-e2e May 27, 2024
jbpratt pushed a commit to jbpratt/release that referenced this pull request May 30, 2024
openshift#51516)

* Include NMO upgrade installation test in OCP-e2e cluster test for OCP 4.12-4.15

Make the OCP-e2e cluster test a three-step test- installing the old version, updating to the latest, and testing the E2E test

* Include FAR upgrade installation test in OCP-e2e cluster test

Make the OCP-e2e cluster test a three-step test- installing the old version, updating to the latest, and testing the E2E test

* Skip out-of-service test on OCP 4.12 and FAR

E2E test of FAR 4.12 was expecting to run the out-of-service tests but it isn't supported on OCP 4.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants