Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for MultiBroadcastTag and MultiArchiveTag #226

Merged
merged 6 commits into from
Sep 12, 2022
Merged

Added support for MultiBroadcastTag and MultiArchiveTag #226

merged 6 commits into from
Sep 12, 2022

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Sep 5, 2022 •
edited
Loading

See this presentation for context

@codecov
Copy link

codecov bot commented Sep 5, 2022 •
edited
Loading

Codecov Report

Merging #226 (44c0bd8) into dev (6178270) will increase coverage by 0.20986%.
The diff coverage is 95.83333%.

Impacted Files Coverage Δ
src/main/java/com/opentok/ArchiveProperties.java 86.48649% <88.88889%> (+0.33264%) ⬆️
src/main/java/com/opentok/Archive.java 95.74468% <100.00000%> (+0.09252%) ⬆️
src/main/java/com/opentok/ArchiveMode.java 100.00000% <100.00000%> (ø)
src/main/java/com/opentok/Broadcast.java 94.28571% <100.00000%> (+0.16806%) ⬆️
src/main/java/com/opentok/BroadcastProperties.java 93.33333% <100.00000%> (+0.65041%) ⬆️
src/main/java/com/opentok/util/HttpClient.java 59.85401% <100.00000%> (+0.23581%) ⬆️

jeffswartz
jeffswartz requested changes Sep 5, 2022
View reviewed changes
src/main/java/com/opentok/Archive.java Outdated Show resolved Hide resolved
src/main/java/com/opentok/ArchiveProperties.java Outdated Show resolved Hide resolved
src/main/java/com/opentok/BroadcastProperties.java Outdated Show resolved Hide resolved
src/main/java/com/opentok/Broadcast.java Outdated Show resolved Hide resolved
jeffswartz
jeffswartz requested changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also bump the version to 4.8.0 (in build.gradle, .bumpversion.cfg, and Version.java).

@SMadani SMadani changed the base branch from main to dev September 8, 2022 15:57
@SMadani SMadani merged commit 7bbe6b6 into dev Sep 12, 2022
@SMadani SMadani deleted the multi branch September 12, 2022 07:47
SMadani added a commit that referenced this pull request Sep 28, 2022
@SMadani @jeffswartz
Added support for MultiBroadcastTag and MultiArchiveTag (#226)
edf766f 
* Added multiArchiveTag

* Added multiBroadcastTag

* Updated docs

* Removed getMulti*Tag from responses

* Revert "Removed getMulti*Tag from responses"

This reverts commit 6e7f123.

* Docs edits re multiArchive/BroadcastTag.

Co-authored-by: Jeff Swartz <[email protected]>
SMadani added a commit that referenced this pull request Mar 9, 2023
@SMadani @jeffswartz
v4.9.0 Release (#235)
74abd63 
* Minor fixes in build.gradle

* Added support for MultiBroadcastTag and MultiArchiveTag (#226)

* Added multiArchiveTag

* Added multiBroadcastTag

* Updated docs

* Removed getMulti*Tag from responses

* Revert "Removed getMulti*Tag from responses"

This reverts commit 6e7f123.

* Docs edits re multiArchive/BroadcastTag.

Co-authored-by: Jeff Swartz <[email protected]>

* Add Experience Composer API (#227)

* Added startRender

* Added listRenders

* Deserialize listRenders response to native List

* Added stopRender & getRender

* Use enum for Render status

* Improved RenderProperties

* Experience composer docs edits ...

And other docs corrections

Co-authored-by: Jeff Swartz <[email protected]>

* Bump dependency versions

* Improved release process.

bump2version is now manual, but release to Nexus is fully automated.

* Ensure version is passed in bumpversion.sh

* Bumped dependencies (including WireMock)

* Bump version: v4.8.0 → v4.8.1

* Update copyright year

* Use wiremock-jre8

* Boost coverage

* Boost coverage

* Disable codecov temporarily

* Revert "Disable codecov temporarily"

This reverts commit 613bff0.

* Add Audio Streamer (lite) API endpoint (#215)

* Added Audio Streamer (lite) endpoint

* Don't include headers or streams if empty in connect request

* Renamed Connect for clarity

* Addressed PR comments

* Fixed failing test

* URI in AudioStreamerConnectionProperties constructor

* Docs edits

* Bumped dependencies (notably WireMock to 2.x)

* Bumped dependencies

* Bump dependency versions (#233)

Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1.

* Renamed to Audio Connector

* Bumped dependencies

* Added audio connector to README

* Minor docs edits

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump version: v4.8.1 → v4.9.0

---------

Co-authored-by: Jeff Swartz <[email protected]>
SMadani added a commit that referenced this pull request May 9, 2023
@SMadani @jeffswartz
Prepare v4.10.0 release (#240)
9e897d1 
* Minor fixes in build.gradle

* Added support for MultiBroadcastTag and MultiArchiveTag (#226)

* Added multiArchiveTag

* Added multiBroadcastTag

* Updated docs

* Removed getMulti*Tag from responses

* Revert "Removed getMulti*Tag from responses"

This reverts commit 6e7f123.

* Docs edits re multiArchive/BroadcastTag.

Co-authored-by: Jeff Swartz <[email protected]>

* Add Experience Composer API (#227)

* Added startRender

* Added listRenders

* Deserialize listRenders response to native List

* Added stopRender & getRender

* Use enum for Render status

* Improved RenderProperties

* Experience composer docs edits ...

And other docs corrections

Co-authored-by: Jeff Swartz <[email protected]>

* Bump dependency versions

* Improved release process.

bump2version is now manual, but release to Nexus is fully automated.

* Ensure version is passed in bumpversion.sh

* Bumped dependencies (including WireMock)

* Bump version: v4.8.0 → v4.8.1

* Update copyright year

* Use wiremock-jre8

* Boost coverage

* Boost coverage

* Disable codecov temporarily

* Revert "Disable codecov temporarily"

This reverts commit 613bff0.

* Add Audio Streamer (lite) API endpoint (#215)

* Added Audio Streamer (lite) endpoint

* Don't include headers or streams if empty in connect request

* Renamed Connect for clarity

* Addressed PR comments

* Fixed failing test

* URI in AudioStreamerConnectionProperties constructor

* Docs edits

* Bumped dependencies (notably WireMock to 2.x)

* Bumped dependencies

* Bump dependency versions (#233)

Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1.

* Renamed to Audio Connector

* Bumped dependencies

* Added audio connector to README

* Minor docs edits

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump version: v4.8.1 → v4.9.0

* Minor docs edit

* Enable custom User-Agent (#238)

* Add end-to-end encryption support (#237)

* Added e2ee support

* Added validation for SessionProperties

* Only include e2ee if true

* Update SessionProperties javadoc

Co-authored-by: Jeff Swartz <[email protected]>

* Minor docs edit

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump jackson version

* Bump version: v4.9.0 → v4.10.0

---------

Co-authored-by: Jeff Swartz <[email protected]>
SMadani added a commit that referenced this pull request Jun 6, 2023
@SMadani @jeffswartz
Auto archive resolution & name (#241)
102dbe7 
* Prepare v4.10.0 release (#240)

* Minor fixes in build.gradle

* Added support for MultiBroadcastTag and MultiArchiveTag (#226)

* Added multiArchiveTag

* Added multiBroadcastTag

* Updated docs

* Removed getMulti*Tag from responses

* Revert "Removed getMulti*Tag from responses"

This reverts commit 6e7f123.

* Docs edits re multiArchive/BroadcastTag.

Co-authored-by: Jeff Swartz <[email protected]>

* Add Experience Composer API (#227)

* Added startRender

* Added listRenders

* Deserialize listRenders response to native List

* Added stopRender & getRender

* Use enum for Render status

* Improved RenderProperties

* Experience composer docs edits ...

And other docs corrections

Co-authored-by: Jeff Swartz <[email protected]>

* Bump dependency versions

* Improved release process.

bump2version is now manual, but release to Nexus is fully automated.

* Ensure version is passed in bumpversion.sh

* Bumped dependencies (including WireMock)

* Bump version: v4.8.0 → v4.8.1

* Update copyright year

* Use wiremock-jre8

* Boost coverage

* Boost coverage

* Disable codecov temporarily

* Revert "Disable codecov temporarily"

This reverts commit 613bff0.

* Add Audio Streamer (lite) API endpoint (#215)

* Added Audio Streamer (lite) endpoint

* Don't include headers or streams if empty in connect request

* Renamed Connect for clarity

* Addressed PR comments

* Fixed failing test

* URI in AudioStreamerConnectionProperties constructor

* Docs edits

* Bumped dependencies (notably WireMock to 2.x)

* Bumped dependencies

* Bump dependency versions (#233)

Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1.

* Renamed to Audio Connector

* Bumped dependencies

* Added audio connector to README

* Minor docs edits

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump version: v4.8.1 → v4.9.0

* Minor docs edit

* Enable custom User-Agent (#238)

* Add end-to-end encryption support (#237)

* Added e2ee support

* Added validation for SessionProperties

* Only include e2ee if true

* Update SessionProperties javadoc

Co-authored-by: Jeff Swartz <[email protected]>

* Minor docs edit

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump jackson version

* Bump version: v4.9.0 → v4.10.0

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Added auto archive properties to session

* Updated resolution names

---------

Co-authored-by: Jeff Swartz <[email protected]>
SMadani added a commit that referenced this pull request Jun 6, 2023
@SMadani @jeffswartz
Merge dev into main (#242)
d7801ac 
* Minor fixes in build.gradle

* Added support for MultiBroadcastTag and MultiArchiveTag (#226)

* Added multiArchiveTag

* Added multiBroadcastTag

* Updated docs

* Removed getMulti*Tag from responses

* Revert "Removed getMulti*Tag from responses"

This reverts commit 6e7f123.

* Docs edits re multiArchive/BroadcastTag.

Co-authored-by: Jeff Swartz <[email protected]>

* Add Experience Composer API (#227)

* Added startRender

* Added listRenders

* Deserialize listRenders response to native List

* Added stopRender & getRender

* Use enum for Render status

* Improved RenderProperties

* Experience composer docs edits ...

And other docs corrections

Co-authored-by: Jeff Swartz <[email protected]>

* Bump dependency versions

* Improved release process.

bump2version is now manual, but release to Nexus is fully automated.

* Ensure version is passed in bumpversion.sh

* Bumped dependencies (including WireMock)

* Bump version: v4.8.0 → v4.8.1

* Update copyright year

* Use wiremock-jre8

* Boost coverage

* Boost coverage

* Disable codecov temporarily

* Revert "Disable codecov temporarily"

This reverts commit 613bff0.

* Add Audio Streamer (lite) API endpoint (#215)

* Added Audio Streamer (lite) endpoint

* Don't include headers or streams if empty in connect request

* Renamed Connect for clarity

* Addressed PR comments

* Fixed failing test

* URI in AudioStreamerConnectionProperties constructor

* Docs edits

* Bumped dependencies (notably WireMock to 2.x)

* Bumped dependencies

* Bump dependency versions (#233)

Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1.

* Renamed to Audio Connector

* Bumped dependencies

* Added audio connector to README

* Minor docs edits

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump version: v4.8.1 → v4.9.0

* Minor docs edit

* Enable custom User-Agent (#238)

* Add end-to-end encryption support (#237)

* Added e2ee support

* Added validation for SessionProperties

* Only include e2ee if true

* Update SessionProperties javadoc

Co-authored-by: Jeff Swartz <[email protected]>

* Minor docs edit

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump jackson version

* Bump version: v4.9.0 → v4.10.0

* Auto archive resolution & name (#241)

* Prepare v4.10.0 release (#240)

* Minor fixes in build.gradle

* Added support for MultiBroadcastTag and MultiArchiveTag (#226)

* Added multiArchiveTag

* Added multiBroadcastTag

* Updated docs

* Removed getMulti*Tag from responses

* Revert "Removed getMulti*Tag from responses"

This reverts commit 6e7f123.

* Docs edits re multiArchive/BroadcastTag.

Co-authored-by: Jeff Swartz <[email protected]>

* Add Experience Composer API (#227)

* Added startRender

* Added listRenders

* Deserialize listRenders response to native List

* Added stopRender & getRender

* Use enum for Render status

* Improved RenderProperties

* Experience composer docs edits ...

And other docs corrections

Co-authored-by: Jeff Swartz <[email protected]>

* Bump dependency versions

* Improved release process.

bump2version is now manual, but release to Nexus is fully automated.

* Ensure version is passed in bumpversion.sh

* Bumped dependencies (including WireMock)

* Bump version: v4.8.0 → v4.8.1

* Update copyright year

* Use wiremock-jre8

* Boost coverage

* Boost coverage

* Disable codecov temporarily

* Revert "Disable codecov temporarily"

This reverts commit 613bff0.

* Add Audio Streamer (lite) API endpoint (#215)

* Added Audio Streamer (lite) endpoint

* Don't include headers or streams if empty in connect request

* Renamed Connect for clarity

* Addressed PR comments

* Fixed failing test

* URI in AudioStreamerConnectionProperties constructor

* Docs edits

* Bumped dependencies (notably WireMock to 2.x)

* Bumped dependencies

* Bump dependency versions (#233)

Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1.

* Renamed to Audio Connector

* Bumped dependencies

* Added audio connector to README

* Minor docs edits

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump version: v4.8.1 → v4.9.0

* Minor docs edit

* Enable custom User-Agent (#238)

* Add end-to-end encryption support (#237)

* Added e2ee support

* Added validation for SessionProperties

* Only include e2ee if true

* Update SessionProperties javadoc

Co-authored-by: Jeff Swartz <[email protected]>

* Minor docs edit

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump jackson version

* Bump version: v4.9.0 → v4.10.0

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Added auto archive properties to session

* Updated resolution names

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Add hasAudio and hasVideo to Broadcast (#239)

* Bump version: v4.10.0 → v4.11.0

* Remove dev from DEVELOPING.MD

---------

Co-authored-by: Jeff Swartz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffswartz jeffswartz jeffswartz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SMadani @jeffswartz