Bump dependency versions #233

SMadani · 2023-01-13T16:31:59Z

This is a security patch release which updates the dependency versions, including WireMock to v2.35.0 (which only affects tests). Functionality and documentation is unchanged. The copyright year has also been updated to make license check pass.

* Added multiArchiveTag * Added multiBroadcastTag * Updated docs * Removed getMulti*Tag from responses * Revert "Removed getMulti*Tag from responses" This reverts commit 6e7f123. * Docs edits re multiArchive/BroadcastTag. Co-authored-by: Jeff Swartz <[email protected]>

* Added startRender * Added listRenders * Deserialize listRenders response to native List * Added stopRender & getRender * Use enum for Render status * Improved RenderProperties * Experience composer docs edits ... And other docs corrections Co-authored-by: Jeff Swartz <[email protected]>

bump2version is now manual, but release to Nexus is fully automated.

codecov · 2023-01-13T16:49:54Z

Codecov Report

Merging #233 (b7d9216) into main (242ef4d) will decrease coverage by 0.12253%.
The diff coverage is 70.76923%.

Impacted Files	Coverage Δ
src/main/java/com/opentok/ArchiveLayout.java	`100.00000% <ø> (ø)`
src/main/java/com/opentok/ArchiveList.java	`100.00000% <ø> (ø)`
src/main/java/com/opentok/BroadcastLayout.java	`100.00000% <ø> (ø)`
src/main/java/com/opentok/CreatedSession.java	`75.00000% <ø> (+33.33333%)`	⬆️
src/main/java/com/opentok/Hls.java	`100.00000% <ø> (ø)`
src/main/java/com/opentok/MediaMode.java	`100.00000% <ø> (ø)`
src/main/java/com/opentok/MuteAllProperties.java	`100.00000% <ø> (ø)`
src/main/java/com/opentok/Role.java	`100.00000% <ø> (ø)`
src/main/java/com/opentok/Rtmp.java	`100.00000% <ø> (ø)`
src/main/java/com/opentok/RtmpProperties.java	`100.00000% <ø> (ø)`
... and 31 more

dragonmantank

SHoot, I clicked "view file" too many times and lost which one it was, but one of the classes changed the properties to final. Since that's a restrictive change, it would be a BC change (as opposed to being final and moving to something more open). So technically this cannot be a patch release.

If that part is reverted then it's all good for the patched version assigned

SMadani · 2023-01-14T22:45:15Z

SHoot, I clicked "view file" too many times and lost which one it was, but one of the classes changed the properties to final. Since that's a restrictive change, it would be a BC change (as opposed to being final and moving to something more open). So technically this cannot be a patch release.

If that part is reverted then it's all good for the patched version assigned

Thanks for looking this over. In Java, if something is private, it is not exposed outside of the class (at least not without reflection, which is harder in more recent versions anyway). Thus any changes to a private memeber are not breaking changes as they are invisible to a user. I'm guessing you're referring to API key & secret in OpenTok.java, which is only ever set in the constructor anyway. Furthermore, final in Java is a compiler only construct, the bytecode of the compiled class will be identical. Even someone extending the SDK would not see this change.

dragonmantank · 2023-01-14T22:51:17Z

That's what I get for not re-finding it. I thought I had read it as public final, but you are right, since it's private already not much is actually changing.

SMadani · 2023-01-14T22:52:38Z

Thanks :) Now just got to deal with the codecov target

This reverts commit 613bff0.

* Added Audio Streamer (lite) endpoint * Don't include headers or streams if empty in connect request * Renamed Connect for clarity * Addressed PR comments * Fixed failing test * URI in AudioStreamerConnectionProperties constructor * Docs edits * Bumped dependencies (notably WireMock to 2.x) * Bumped dependencies * Bump dependency versions (#233) Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1. * Renamed to Audio Connector * Bumped dependencies * Added audio connector to README * Minor docs edits --------- Co-authored-by: Jeff Swartz <[email protected]>

* Minor fixes in build.gradle * Added support for MultiBroadcastTag and MultiArchiveTag (#226) * Added multiArchiveTag * Added multiBroadcastTag * Updated docs * Removed getMulti*Tag from responses * Revert "Removed getMulti*Tag from responses" This reverts commit 6e7f123. * Docs edits re multiArchive/BroadcastTag. Co-authored-by: Jeff Swartz <[email protected]> * Add Experience Composer API (#227) * Added startRender * Added listRenders * Deserialize listRenders response to native List * Added stopRender & getRender * Use enum for Render status * Improved RenderProperties * Experience composer docs edits ... And other docs corrections Co-authored-by: Jeff Swartz <[email protected]> * Bump dependency versions * Improved release process. bump2version is now manual, but release to Nexus is fully automated. * Ensure version is passed in bumpversion.sh * Bumped dependencies (including WireMock) * Bump version: v4.8.0 → v4.8.1 * Update copyright year * Use wiremock-jre8 * Boost coverage * Boost coverage * Disable codecov temporarily * Revert "Disable codecov temporarily" This reverts commit 613bff0. * Add Audio Streamer (lite) API endpoint (#215) * Added Audio Streamer (lite) endpoint * Don't include headers or streams if empty in connect request * Renamed Connect for clarity * Addressed PR comments * Fixed failing test * URI in AudioStreamerConnectionProperties constructor * Docs edits * Bumped dependencies (notably WireMock to 2.x) * Bumped dependencies * Bump dependency versions (#233) Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1. * Renamed to Audio Connector * Bumped dependencies * Added audio connector to README * Minor docs edits --------- Co-authored-by: Jeff Swartz <[email protected]> * Bump version: v4.8.1 → v4.9.0 --------- Co-authored-by: Jeff Swartz <[email protected]>

* Minor fixes in build.gradle * Added support for MultiBroadcastTag and MultiArchiveTag (#226) * Added multiArchiveTag * Added multiBroadcastTag * Updated docs * Removed getMulti*Tag from responses * Revert "Removed getMulti*Tag from responses" This reverts commit 6e7f123. * Docs edits re multiArchive/BroadcastTag. Co-authored-by: Jeff Swartz <[email protected]> * Add Experience Composer API (#227) * Added startRender * Added listRenders * Deserialize listRenders response to native List * Added stopRender & getRender * Use enum for Render status * Improved RenderProperties * Experience composer docs edits ... And other docs corrections Co-authored-by: Jeff Swartz <[email protected]> * Bump dependency versions * Improved release process. bump2version is now manual, but release to Nexus is fully automated. * Ensure version is passed in bumpversion.sh * Bumped dependencies (including WireMock) * Bump version: v4.8.0 → v4.8.1 * Update copyright year * Use wiremock-jre8 * Boost coverage * Boost coverage * Disable codecov temporarily * Revert "Disable codecov temporarily" This reverts commit 613bff0. * Add Audio Streamer (lite) API endpoint (#215) * Added Audio Streamer (lite) endpoint * Don't include headers or streams if empty in connect request * Renamed Connect for clarity * Addressed PR comments * Fixed failing test * URI in AudioStreamerConnectionProperties constructor * Docs edits * Bumped dependencies (notably WireMock to 2.x) * Bumped dependencies * Bump dependency versions (#233) Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1. * Renamed to Audio Connector * Bumped dependencies * Added audio connector to README * Minor docs edits --------- Co-authored-by: Jeff Swartz <[email protected]> * Bump version: v4.8.1 → v4.9.0 * Minor docs edit * Enable custom User-Agent (#238) * Add end-to-end encryption support (#237) * Added e2ee support * Added validation for SessionProperties * Only include e2ee if true * Update SessionProperties javadoc Co-authored-by: Jeff Swartz <[email protected]> * Minor docs edit --------- Co-authored-by: Jeff Swartz <[email protected]> * Bump jackson version * Bump version: v4.9.0 → v4.10.0 --------- Co-authored-by: Jeff Swartz <[email protected]>

* Prepare v4.10.0 release (#240) * Minor fixes in build.gradle * Added support for MultiBroadcastTag and MultiArchiveTag (#226) * Added multiArchiveTag * Added multiBroadcastTag * Updated docs * Removed getMulti*Tag from responses * Revert "Removed getMulti*Tag from responses" This reverts commit 6e7f123. * Docs edits re multiArchive/BroadcastTag. Co-authored-by: Jeff Swartz <[email protected]> * Add Experience Composer API (#227) * Added startRender * Added listRenders * Deserialize listRenders response to native List * Added stopRender & getRender * Use enum for Render status * Improved RenderProperties * Experience composer docs edits ... And other docs corrections Co-authored-by: Jeff Swartz <[email protected]> * Bump dependency versions * Improved release process. bump2version is now manual, but release to Nexus is fully automated. * Ensure version is passed in bumpversion.sh * Bumped dependencies (including WireMock) * Bump version: v4.8.0 → v4.8.1 * Update copyright year * Use wiremock-jre8 * Boost coverage * Boost coverage * Disable codecov temporarily * Revert "Disable codecov temporarily" This reverts commit 613bff0. * Add Audio Streamer (lite) API endpoint (#215) * Added Audio Streamer (lite) endpoint * Don't include headers or streams if empty in connect request * Renamed Connect for clarity * Addressed PR comments * Fixed failing test * URI in AudioStreamerConnectionProperties constructor * Docs edits * Bumped dependencies (notably WireMock to 2.x) * Bumped dependencies * Bump dependency versions (#233) Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1. * Renamed to Audio Connector * Bumped dependencies * Added audio connector to README * Minor docs edits --------- Co-authored-by: Jeff Swartz <[email protected]> * Bump version: v4.8.1 → v4.9.0 * Minor docs edit * Enable custom User-Agent (#238) * Add end-to-end encryption support (#237) * Added e2ee support * Added validation for SessionProperties * Only include e2ee if true * Update SessionProperties javadoc Co-authored-by: Jeff Swartz <[email protected]> * Minor docs edit --------- Co-authored-by: Jeff Swartz <[email protected]> * Bump jackson version * Bump version: v4.9.0 → v4.10.0 --------- Co-authored-by: Jeff Swartz <[email protected]> * Added auto archive properties to session * Updated resolution names --------- Co-authored-by: Jeff Swartz <[email protected]>

* Minor fixes in build.gradle * Added support for MultiBroadcastTag and MultiArchiveTag (#226) * Added multiArchiveTag * Added multiBroadcastTag * Updated docs * Removed getMulti*Tag from responses * Revert "Removed getMulti*Tag from responses" This reverts commit 6e7f123. * Docs edits re multiArchive/BroadcastTag. Co-authored-by: Jeff Swartz <[email protected]> * Add Experience Composer API (#227) * Added startRender * Added listRenders * Deserialize listRenders response to native List * Added stopRender & getRender * Use enum for Render status * Improved RenderProperties * Experience composer docs edits ... And other docs corrections Co-authored-by: Jeff Swartz <[email protected]> * Bump dependency versions * Improved release process. bump2version is now manual, but release to Nexus is fully automated. * Ensure version is passed in bumpversion.sh * Bumped dependencies (including WireMock) * Bump version: v4.8.0 → v4.8.1 * Update copyright year * Use wiremock-jre8 * Boost coverage * Boost coverage * Disable codecov temporarily * Revert "Disable codecov temporarily" This reverts commit 613bff0. * Add Audio Streamer (lite) API endpoint (#215) * Added Audio Streamer (lite) endpoint * Don't include headers or streams if empty in connect request * Renamed Connect for clarity * Addressed PR comments * Fixed failing test * URI in AudioStreamerConnectionProperties constructor * Docs edits * Bumped dependencies (notably WireMock to 2.x) * Bumped dependencies * Bump dependency versions (#233) Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1. * Renamed to Audio Connector * Bumped dependencies * Added audio connector to README * Minor docs edits --------- Co-authored-by: Jeff Swartz <[email protected]> * Bump version: v4.8.1 → v4.9.0 * Minor docs edit * Enable custom User-Agent (#238) * Add end-to-end encryption support (#237) * Added e2ee support * Added validation for SessionProperties * Only include e2ee if true * Update SessionProperties javadoc Co-authored-by: Jeff Swartz <[email protected]> * Minor docs edit --------- Co-authored-by: Jeff Swartz <[email protected]> * Bump jackson version * Bump version: v4.9.0 → v4.10.0 * Auto archive resolution & name (#241) * Prepare v4.10.0 release (#240) * Minor fixes in build.gradle * Added support for MultiBroadcastTag and MultiArchiveTag (#226) * Added multiArchiveTag * Added multiBroadcastTag * Updated docs * Removed getMulti*Tag from responses * Revert "Removed getMulti*Tag from responses" This reverts commit 6e7f123. * Docs edits re multiArchive/BroadcastTag. Co-authored-by: Jeff Swartz <[email protected]> * Add Experience Composer API (#227) * Added startRender * Added listRenders * Deserialize listRenders response to native List * Added stopRender & getRender * Use enum for Render status * Improved RenderProperties * Experience composer docs edits ... And other docs corrections Co-authored-by: Jeff Swartz <[email protected]> * Bump dependency versions * Improved release process. bump2version is now manual, but release to Nexus is fully automated. * Ensure version is passed in bumpversion.sh * Bumped dependencies (including WireMock) * Bump version: v4.8.0 → v4.8.1 * Update copyright year * Use wiremock-jre8 * Boost coverage * Boost coverage * Disable codecov temporarily * Revert "Disable codecov temporarily" This reverts commit 613bff0. * Add Audio Streamer (lite) API endpoint (#215) * Added Audio Streamer (lite) endpoint * Don't include headers or streams if empty in connect request * Renamed Connect for clarity * Addressed PR comments * Fixed failing test * URI in AudioStreamerConnectionProperties constructor * Docs edits * Bumped dependencies (notably WireMock to 2.x) * Bumped dependencies * Bump dependency versions (#233) Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1. * Renamed to Audio Connector * Bumped dependencies * Added audio connector to README * Minor docs edits --------- Co-authored-by: Jeff Swartz <[email protected]> * Bump version: v4.8.1 → v4.9.0 * Minor docs edit * Enable custom User-Agent (#238) * Add end-to-end encryption support (#237) * Added e2ee support * Added validation for SessionProperties * Only include e2ee if true * Update SessionProperties javadoc Co-authored-by: Jeff Swartz <[email protected]> * Minor docs edit --------- Co-authored-by: Jeff Swartz <[email protected]> * Bump jackson version * Bump version: v4.9.0 → v4.10.0 --------- Co-authored-by: Jeff Swartz <[email protected]> * Added auto archive properties to session * Updated resolution names --------- Co-authored-by: Jeff Swartz <[email protected]> * Add hasAudio and hasVideo to Broadcast (#239) * Bump version: v4.10.0 → v4.11.0 * Remove dev from DEVELOPING.MD --------- Co-authored-by: Jeff Swartz <[email protected]>

SMadani and others added 12 commits May 16, 2022 10:57

Minor fixes in build.gradle

1531b97

Merge branch 'main' into dev

6178270

Bump dependency versions

3f9bfe6

Merge branch 'main' into dev

ad9c298

Merge branch 'main' into dev

8d2d5c3

Improved release process.

6ae9b3d

bump2version is now manual, but release to Nexus is fully automated.

Ensure version is passed in bumpversion.sh

2c88f17

Bumped dependencies (including WireMock)

cd7fd6b

Bump version: v4.8.0 → v4.8.1

aff251f

Update copyright year

517287d

Use wiremock-jre8

15c6d71

dragonmantank requested changes Jan 13, 2023

View reviewed changes

dragonmantank approved these changes Jan 14, 2023

View reviewed changes

SMadani added 4 commits January 14, 2023 23:05

Boost coverage

c9e516b

Boost coverage

85de498

Disable codecov temporarily

613bff0

Revert "Disable codecov temporarily"

b7d9216

This reverts commit 613bff0.

SMadani merged commit ed5cbc4 into main Jan 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump dependency versions #233

Bump dependency versions #233

SMadani commented Jan 13, 2023 •

edited

Loading

codecov bot commented Jan 13, 2023 •

edited

Loading

dragonmantank left a comment

SMadani commented Jan 14, 2023 •

edited

Loading

dragonmantank commented Jan 14, 2023

SMadani commented Jan 14, 2023

Bump dependency versions #233

Bump dependency versions #233

Conversation

SMadani commented Jan 13, 2023 • edited Loading

codecov bot commented Jan 13, 2023 • edited Loading

Codecov Report

dragonmantank left a comment

Choose a reason for hiding this comment

SMadani commented Jan 14, 2023 • edited Loading

dragonmantank commented Jan 14, 2023

SMadani commented Jan 14, 2023

SMadani commented Jan 13, 2023 •

edited

Loading

codecov bot commented Jan 13, 2023 •

edited

Loading

SMadani commented Jan 14, 2023 •

edited

Loading