Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto archive resolution & name #241

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Auto archive resolution & name #241

merged 4 commits into from
Jun 6, 2023

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented May 23, 2023

This PR adds the name and resolution settings to session creation options, as was recently added to the spec.

SMadani and others added 3 commits May 9, 2023 14:38
* Minor fixes in build.gradle

* Added support for MultiBroadcastTag and MultiArchiveTag (#226)

* Added multiArchiveTag

* Added multiBroadcastTag

* Updated docs

* Removed getMulti*Tag from responses

* Revert "Removed getMulti*Tag from responses"

This reverts commit 6e7f123.

* Docs edits re multiArchive/BroadcastTag.

Co-authored-by: Jeff Swartz <[email protected]>

* Add Experience Composer API (#227)

* Added startRender

* Added listRenders

* Deserialize listRenders response to native List

* Added stopRender & getRender

* Use enum for Render status

* Improved RenderProperties

* Experience composer docs edits ...

And other docs corrections

Co-authored-by: Jeff Swartz <[email protected]>

* Bump dependency versions

* Improved release process.

bump2version is now manual, but release to Nexus is fully automated.

* Ensure version is passed in bumpversion.sh

* Bumped dependencies (including WireMock)

* Bump version: v4.8.0 → v4.8.1

* Update copyright year

* Use wiremock-jre8

* Boost coverage

* Boost coverage

* Disable codecov temporarily

* Revert "Disable codecov temporarily"

This reverts commit 613bff0.

* Add Audio Streamer (lite) API endpoint (#215)

* Added Audio Streamer (lite) endpoint

* Don't include headers or streams if empty in connect request

* Renamed Connect for clarity

* Addressed PR comments

* Fixed failing test

* URI in AudioStreamerConnectionProperties constructor

* Docs edits

* Bumped dependencies (notably WireMock to 2.x)

* Bumped dependencies

* Bump dependency versions (#233)

Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1.

* Renamed to Audio Connector

* Bumped dependencies

* Added audio connector to README

* Minor docs edits

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump version: v4.8.1 → v4.9.0

* Minor docs edit

* Enable custom User-Agent (#238)

* Add end-to-end encryption support (#237)

* Added e2ee support

* Added validation for SessionProperties

* Only include e2ee if true

* Update SessionProperties javadoc

Co-authored-by: Jeff Swartz <[email protected]>

* Minor docs edit

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump jackson version

* Bump version: v4.9.0 → v4.10.0

---------

Co-authored-by: Jeff Swartz <[email protected]>
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #241 (abbfdf7) into dev (3834194) will increase coverage by 0.39954%.
The diff coverage is 94.33962%.

❗ Current head abbfdf7 differs from pull request most recent head edf0591. Consider uploading reports for the commit edf0591 to get more accurate results

Impacted Files Coverage Δ
src/main/java/com/opentok/Resolution.java 93.33333% <93.33333%> (ø)
src/main/java/com/opentok/SessionProperties.java 97.22222% <94.73684%> (-2.77778%) ⬇️

@SMadani SMadani requested a review from jeffswartz May 23, 2023 14:29
@maxkahan maxkahan self-requested a review June 6, 2023 15:58
Copy link

@maxkahan maxkahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on call, LGTM.

@SMadani SMadani merged commit 102dbe7 into dev Jun 6, 2023
@SMadani SMadani deleted the auto-archive branch June 6, 2023 16:07
SMadani added a commit that referenced this pull request Jun 6, 2023
* Minor fixes in build.gradle

* Added support for MultiBroadcastTag and MultiArchiveTag (#226)

* Added multiArchiveTag

* Added multiBroadcastTag

* Updated docs

* Removed getMulti*Tag from responses

* Revert "Removed getMulti*Tag from responses"

This reverts commit 6e7f123.

* Docs edits re multiArchive/BroadcastTag.

Co-authored-by: Jeff Swartz <[email protected]>

* Add Experience Composer API (#227)

* Added startRender

* Added listRenders

* Deserialize listRenders response to native List

* Added stopRender & getRender

* Use enum for Render status

* Improved RenderProperties

* Experience composer docs edits ...

And other docs corrections

Co-authored-by: Jeff Swartz <[email protected]>

* Bump dependency versions

* Improved release process.

bump2version is now manual, but release to Nexus is fully automated.

* Ensure version is passed in bumpversion.sh

* Bumped dependencies (including WireMock)

* Bump version: v4.8.0 → v4.8.1

* Update copyright year

* Use wiremock-jre8

* Boost coverage

* Boost coverage

* Disable codecov temporarily

* Revert "Disable codecov temporarily"

This reverts commit 613bff0.

* Add Audio Streamer (lite) API endpoint (#215)

* Added Audio Streamer (lite) endpoint

* Don't include headers or streams if empty in connect request

* Renamed Connect for clarity

* Addressed PR comments

* Fixed failing test

* URI in AudioStreamerConnectionProperties constructor

* Docs edits

* Bumped dependencies (notably WireMock to 2.x)

* Bumped dependencies

* Bump dependency versions (#233)

Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1.

* Renamed to Audio Connector

* Bumped dependencies

* Added audio connector to README

* Minor docs edits

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump version: v4.8.1 → v4.9.0

* Minor docs edit

* Enable custom User-Agent (#238)

* Add end-to-end encryption support (#237)

* Added e2ee support

* Added validation for SessionProperties

* Only include e2ee if true

* Update SessionProperties javadoc

Co-authored-by: Jeff Swartz <[email protected]>

* Minor docs edit

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump jackson version

* Bump version: v4.9.0 → v4.10.0

* Auto archive resolution & name (#241)

* Prepare v4.10.0 release (#240)

* Minor fixes in build.gradle

* Added support for MultiBroadcastTag and MultiArchiveTag (#226)

* Added multiArchiveTag

* Added multiBroadcastTag

* Updated docs

* Removed getMulti*Tag from responses

* Revert "Removed getMulti*Tag from responses"

This reverts commit 6e7f123.

* Docs edits re multiArchive/BroadcastTag.

Co-authored-by: Jeff Swartz <[email protected]>

* Add Experience Composer API (#227)

* Added startRender

* Added listRenders

* Deserialize listRenders response to native List

* Added stopRender & getRender

* Use enum for Render status

* Improved RenderProperties

* Experience composer docs edits ...

And other docs corrections

Co-authored-by: Jeff Swartz <[email protected]>

* Bump dependency versions

* Improved release process.

bump2version is now manual, but release to Nexus is fully automated.

* Ensure version is passed in bumpversion.sh

* Bumped dependencies (including WireMock)

* Bump version: v4.8.0 → v4.8.1

* Update copyright year

* Use wiremock-jre8

* Boost coverage

* Boost coverage

* Disable codecov temporarily

* Revert "Disable codecov temporarily"

This reverts commit 613bff0.

* Add Audio Streamer (lite) API endpoint (#215)

* Added Audio Streamer (lite) endpoint

* Don't include headers or streams if empty in connect request

* Renamed Connect for clarity

* Addressed PR comments

* Fixed failing test

* URI in AudioStreamerConnectionProperties constructor

* Docs edits

* Bumped dependencies (notably WireMock to 2.x)

* Bumped dependencies

* Bump dependency versions (#233)

Improved release process, bumped dependency versions (including WireMock), slightly improved test coverage, updated copyright year, merged main, ready for release v4.8.1.

* Renamed to Audio Connector

* Bumped dependencies

* Added audio connector to README

* Minor docs edits

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump version: v4.8.1 → v4.9.0

* Minor docs edit

* Enable custom User-Agent (#238)

* Add end-to-end encryption support (#237)

* Added e2ee support

* Added validation for SessionProperties

* Only include e2ee if true

* Update SessionProperties javadoc

Co-authored-by: Jeff Swartz <[email protected]>

* Minor docs edit

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Bump jackson version

* Bump version: v4.9.0 → v4.10.0

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Added auto archive properties to session

* Updated resolution names

---------

Co-authored-by: Jeff Swartz <[email protected]>

* Add hasAudio and hasVideo to Broadcast (#239)

* Bump version: v4.10.0 → v4.11.0

* Remove dev from DEVELOPING.MD

---------

Co-authored-by: Jeff Swartz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants