refactor: update apple and microsoft config key names #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The following OpenID Connect configuration keys have been renamed to better explain their purpose: ```patch - private_key_id + apple_private_key_id - private_key + apple_private_key - team_id + apple_team_id - tenant + microsoft_tenant ``` Closes #1979
Codecov Report
@@ Coverage Diff @@
## master #2261 +/- ##
==========================================
- Coverage 75.85% 75.82% -0.04%
==========================================
Files 308 308
Lines 16117 16117
==========================================
- Hits 12225 12220 -5
- Misses 3013 3019 +6
+ Partials 879 878 -1
Continue to review full report at Codecov.
|
aeneasr
added a commit
to ory/docs
that referenced
this pull request
Mar 3, 2022
This was referenced Mar 9, 2022
Merged
aeneasr
added a commit
to ory/docs
that referenced
this pull request
Mar 21, 2022
7 tasks
peturgeorgievv
pushed a commit
to senteca/kratos-fork
that referenced
this pull request
Jun 30, 2023
BREAKING CHANGE: The following OpenID Connect configuration keys have been renamed to better explain their purpose: ```patch - private_key_id + apple_private_key_id - private_key + apple_private_key - team_id + apple_team_id - tenant + microsoft_tenant ``` Closes ory#1979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The following OpenID Connect configuration keys have been renamed to better explain their purpose:
Closes #1979
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments