Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(login): Error handling when failed to prepare for an expired flow #2120

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

sawadashota
Copy link
Contributor

@sawadashota sawadashota commented Jan 7, 2022

Related issue(s)

Fix error handling when failed to prepare for an expired flow.
This may not be happened normally so I don't know how to reproduce this.
But if this error occurs once, kratos logs same error endlessly and resources will be exhaust.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Signed-off-by: sawadashota <[email protected]>
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #2120 (b65a67b) into master (4339cbb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2120      +/-   ##
==========================================
- Coverage   75.15%   75.14%   -0.02%     
==========================================
  Files         293      293              
  Lines       15600    15600              
==========================================
- Hits        11724    11722       -2     
- Misses       3040     3041       +1     
- Partials      836      837       +1     
Impacted Files Coverage Δ
selfservice/flow/login/error.go 72.88% <0.00%> (ø)
persistence/sql/persister_courier.go 85.00% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4339cbb...b65a67b. Read the comment docs.

@aeneasr aeneasr merged commit fdad834 into ory:master Jan 10, 2022
@sawadashota sawadashota deleted the fix_expired_login branch January 11, 2022 01:04
@vinckr vinckr mentioned this pull request Mar 18, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants