Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: URL with hash sign in after_verification_return_to stays encoded #2173

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

martinboehm
Copy link
Contributor

Fixes a problem that when after_verification_return_to parameter containing hashtag # is specified, the server redirects to URL containing hashtag in URLEncoded form %23.

For example, specify after_verification_return_to=/foo/kratos#abcd

Incorrect behavior (before the fix):
The verification flow redirects to /foo/kratos%23abcd

Correct behavior (after the fix):
The verification flow redirects to /foo/kratos#abcd

Related issue(s)

Fixes #2068

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@LukasRada
Copy link

LukasRada commented Jan 26, 2022

The fix works in real usage of after_verification_return_to🎉

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2022

CLA assistant check
All committers have signed the CLA.

@aeneasr aeneasr merged commit fb1cb8a into ory:master Jan 31, 2022
@aeneasr
Copy link
Member

aeneasr commented Jan 31, 2022

Thank you!

@vinckr
Copy link
Member

vinckr commented Feb 4, 2022

Hello @martinboehm
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL with hash sign in after_verification_return_to stays encoded when redirect user in browser
6 participants