fix(selfservice): Login self service flow with TOTP does not pass on return_to URL #2175
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2175 +/- ##
==========================================
+ Coverage 75.27% 75.30% +0.03%
==========================================
Files 294 294
Lines 15629 15648 +19
==========================================
+ Hits 11764 11784 +20
+ Misses 3033 3031 -2
- Partials 832 833 +1
Continue to review full report at Codecov.
|
selfservice/flow/login/hook.go
Outdated
| } | ||
|
|
||
| if err := aalErr.PassReturnToParameter(a.RequestURL); err != nil { | ||
| return aalErr, true |
There was a problem hiding this comment.
Wasn't this supposed to be:
| return aalErr, true | |
| return err, true |
?
There was a problem hiding this comment.
Thanks! I fixed.
| @@ -41,6 +42,28 @@ func (e *ErrAALNotSatisfied) EnhanceJSONError() interface{} { | |||
| return e | |||
| } | |||
|
|
|||
| func (e *ErrAALNotSatisfied) PassReturnToParameter(requestURL string) error { | |||
There was a problem hiding this comment.
Could you please add a dedicated, small test for this? :)
…_to URL Signed-off-by: sawadashota <[email protected]>
Signed-off-by: sawadashota <[email protected]>
Signed-off-by: sawadashota <[email protected]>
Signed-off-by: sawadashota <[email protected]>
There was a problem hiding this comment.
Thank you for your great contributions, as always! /cc @vinckr not sure if we've sent out some swag to @sawadashota already? :)
|
Hello @sawadashota As Aeneas mentioned we should have sent you some swag ages ago! As a small token of appreciation we would love to send you a gift package. |
Related issue(s)
#2172
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments