Move ERC1155 Rewards into this repo #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oveddan
commented
Aug 1, 2023
| _depositFreeMintRewards(totalReward, numTokens, creator, mintReferral, createReferral); | ||
|
|
||
| return 0; | ||
| } else { |
There was a problem hiding this comment.
what happens if this is actually a paid mint, but they still send the same amount of eth as the totalReward? i.e. where is the token price enforced?
iainnash
added a commit
that referenced
this pull request
Mar 11, 2024
* feat: Boosted Minter factory and implementation * remove rpc endpoints (#203) * feat: Deploy Scripts (#128) * feat: Withdraw Gas for frame minter (#132) * multichain deploy scripts (#143) * feat: upgradeable factory (#144) feat: upgradeable factory [fix] fees multichain deploy * update fee and upgrade (#145) * fix: upgrade script (#147) * Update upgrades to standard pattern (#154) Update deployment scripts to use standard multichain patterns. --------- Co-authored-by: Dan Oved <[email protected]> Co-authored-by: Iain Nash <[email protected]> Co-authored-by: Rohan Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves ERC1155 rewards into this repo, along with its tests.
If/when this is merged, we can delete the file from the ProtocolRewards repo