Premint V2 - Creator Attribution #128

oveddan · 2023-08-03T23:10:14Z

Premint V2 - follow creator attribution standard and move signature validation logic into erc1155 contract.

New features/capabilities:

Follows creator attribution standard; signature validation has been moved from the premint contract to the erc1155 contract, and the erc1155 contract now emits the CreatorAttribution event which can be used to verify that a creator was the one that signaled intent to create the token
Multiple creators can sign a premint on a contract, as long as they have mint new token permissions on it.
Creators can sign a signature against a 1155 contract before it's been created, since the contract's address is known ahead of time, deterministically.
Signature is now created using the erc1155 contract's address as the verifying contract address (before it was the premint contract's address); this can be known before the contract is created, since it is determinstic.

Underlying changes:

Signature validation logic now happens in erc1155 contract
Created library with signature validation logic, which is consumed externally from the erc1155 to reduce contract size.
New Erc1155 needs to be deployed for this to work.
New js jsdk is updated in a separate pr - and updated way to create signatures is defined there.
Signature changes:
- Full contract creation config is no longer included in the signature; since we can derive the contract address from the contract creation parameters (using the deterministic address) we can treat the erc1155 contract address as an already hashed derivation of that; and given that the signature is now created against that address, we don't need to include that superluisly in the contract.
- deterministic erc1155 address is now the verifying contract address
- we need to include the fixed priced minter address in the premint config

oveddan · 2023-08-03T23:10:24Z

Current dependencies on/for this PR:

main
- PR Fix fork tests, update to use real rpcs, and then fix owner for optimism #142
  - PR contract size ci task #133
    - PR Premint #149
      - PR feat: first minter #159
        
        PR refactor: remove legacy mint fee manager #160
      - PR fix: factory tests #158
      - PR Premint/Gasless #98
        
        PR Premint V2 - deployed contracts #155
        
        PR Premint V2 - npm tag #156
        
        PR creator attribution - fix js tests #145
        
        PR Creator attribution - added status rpc read methods #157
        
        PR Creator attribution - reduce optimizer runs to get contracts to build #144
        
        PR Creator Attribution - Deployment Scripts, Fork Tests, & Deployment #152
        
        PR Creator Attribution - Release Package #154
        
        PR Premint V2 - Creator Attribution #128 👈
        
        PR Creator Attribution Deployment #151
        
        PR Expose a get token id method from the contract. Secure with non-reentrant #150
        
        PR only include contract address in signature #138
        
        PR Premint V1 - Release #135
        
        PR Premint deploy #134
    - PR removed a setup action initializer #147
      - PR no funds recipient #148
    - PR Contract size optimization - remove unused royalty fetcher to reduce contract size #140
    - PR Contract size optimization - remove unneeded permission fetcher #139
    - PR Remove mint fee manager & always mintWithRewards (#130) #132
      - PR Contract size reduction - move royalties calculation to external lib #143
      - PR Contract size reduction - move rewards calculations to library with external call #137

This comment was auto-generated by Graphite.

iainnash · 2023-08-10T21:26:41Z

src/nft/ZoraCreator1155Impl.sol

+        _requireAdminOrRole(recoveredSigner, CONTRACT_BASE_ID, PERMISSION_BIT_MINTER);
+
+        // temporarily grant msg sender admin permission to create new tokens
+        _addPermission(CONTRACT_BASE_ID, msg.sender, PERMISSION_BIT_MINTER);


Why can't you just call _setupNewToken directly that skips the admin check passing in the user as the signer?

oveddan · 2023-08-18T02:41:33Z

src/nft/ZoraCreator1155Impl.sol

@@ -722,4 +723,46 @@ contract ZoraCreator1155Impl is
            revert();
        }
    }
+
+    /* start eip712 functionality */


move these into their own contracts to be consistent

This reverts commit 4deabf5.

…atures, useful for the backend

…#144) * reduce optimizer runs to get contracts to build * Premint V2 - Creator Attribution (#128) * wip on move premint to creator attribution style * updated readme to reflect new contracts * Revert "undo changes to js sdk" This reverts commit 4deabf5. * better comments * Added methods to get status of creator attribution, and validate signatures, useful for the backend * better comments * fixed back fork test * slightly more comments

* feat: Boosted Minter factory and implementation * remove rpc endpoints (#203) * feat: Deploy Scripts (#128) * feat: Withdraw Gas for frame minter (#132) * multichain deploy scripts (#143) * feat: upgradeable factory (#144) feat: upgradeable factory [fix] fees multichain deploy * update fee and upgrade (#145) * fix: upgrade script (#147) * Update upgrades to standard pattern (#154) Update deployment scripts to use standard multichain patterns. --------- Co-authored-by: Dan Oved <[email protected]> Co-authored-by: Iain Nash <[email protected]> Co-authored-by: Rohan Kulkarni <[email protected]>

oveddan mentioned this pull request Aug 3, 2023

Premint/Gasless #98

Merged

oveddan force-pushed the gasless branch from 302ec51 to 99008b6 Compare August 9, 2023 22:10

oveddan force-pushed the creator-attribution branch from 9270d18 to 8ca8447 Compare August 9, 2023 22:10

oveddan changed the title ~~wip on move premint to creator attribution style~~ creator attribution Aug 9, 2023

oveddan force-pushed the creator-attribution branch from 8ca8447 to bc8f57c Compare August 9, 2023 22:15

iainnash reviewed Aug 10, 2023

View reviewed changes

oveddan force-pushed the gasless branch from fdf504a to 3197208 Compare August 11, 2023 03:36

oveddan force-pushed the creator-attribution branch 2 times, most recently from 6998c66 to ef23a6a Compare August 11, 2023 21:49

oveddan force-pushed the gasless branch from 6393d9f to 3b68c3e Compare August 11, 2023 22:04

oveddan mentioned this pull request Aug 11, 2023

Premint deploy #134

Closed

oveddan force-pushed the gasless branch from 3b68c3e to 67967d2 Compare August 11, 2023 22:52

oveddan changed the base branch from gasless to gasless_deployment August 11, 2023 22:52

oveddan force-pushed the creator-attribution branch from ef23a6a to 903868e Compare August 11, 2023 22:52

oveddan mentioned this pull request Aug 11, 2023

Premint V1 - Release #135

Closed

oveddan force-pushed the gasless_deployment branch from 4c88e0d to c86bc65 Compare August 11, 2023 23:17

oveddan force-pushed the creator-attribution branch from 903868e to 1840462 Compare August 11, 2023 23:17

oveddan mentioned this pull request Aug 11, 2023

contract size ci task #133

Merged

oveddan force-pushed the gasless_deployment branch from c86bc65 to 046daf9 Compare August 11, 2023 23:20

oveddan force-pushed the creator-attribution branch from 1840462 to dc82896 Compare August 11, 2023 23:20

oveddan force-pushed the gasless_deployment branch from 046daf9 to 0817f8b Compare August 11, 2023 23:31

oveddan force-pushed the creator-attribution branch from dc82896 to b857a69 Compare August 11, 2023 23:31

oveddan force-pushed the gasless_deployment branch from 0817f8b to 32ff648 Compare August 14, 2023 15:21

oveddan force-pushed the creator-attribution branch from b857a69 to 13185a7 Compare August 14, 2023 15:21

oveddan changed the title ~~Premint V2 with Creator Attribution~~ Premint V2 - Creator Attribution Aug 18, 2023

oveddan commented Aug 18, 2023

View reviewed changes

oveddan mentioned this pull request Aug 18, 2023

Creator attribution - added status rpc read methods #157

Closed

wip on move premint to creator attribution style

361cc48

oveddan force-pushed the creator-attribution branch from 4deabf5 to 361cc48 Compare August 21, 2023 16:46

oveddan added 7 commits August 21, 2023 11:13

updated readme to reflect new contracts

060c52d

Revert "undo changes to js sdk"

0d4c0c4

This reverts commit 4deabf5.

better comments

0cf6279

Added methods to get status of creator attribution, and validate sign…

96fbf4b

…atures, useful for the backend

better comments

7c9f6b4

fixed back fork test

04172ea

slightly more comments

575110b

oveddan merged commit 2f0c2d7 into creator-attribution-reduce-optimizer-runs Aug 22, 2023
2 of 6 checks passed

oveddan deleted the creator-attribution branch August 22, 2023 17:36

kulkarohan mentioned this pull request Aug 29, 2023

fix: factory tests #158

Merged

This was referenced Sep 6, 2023

feat: first minter #159

Merged

refactor: remove legacy mint fee manager #160

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Premint V2 - Creator Attribution #128

Premint V2 - Creator Attribution #128

oveddan commented Aug 3, 2023 •

edited

Loading

oveddan commented Aug 3, 2023 •

edited by kulkarohan

Loading

iainnash Aug 10, 2023

oveddan Aug 18, 2023

Premint V2 - Creator Attribution #128

Premint V2 - Creator Attribution #128

Conversation

oveddan commented Aug 3, 2023 • edited Loading

oveddan commented Aug 3, 2023 • edited by kulkarohan Loading

iainnash Aug 10, 2023

Choose a reason for hiding this comment

oveddan Aug 18, 2023

Choose a reason for hiding this comment

oveddan commented Aug 3, 2023 •

edited

Loading

oveddan commented Aug 3, 2023 •

edited by kulkarohan

Loading