Remove mint fee manager & always mintWithRewards (#130) #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
oveddan
force-pushed
the
remove-mint-fee-manager
branch
from
2e54764
to
04ddd94
Compare
This was referenced Aug 14, 2023
Merged
Merged
Closed
Closed
oveddan
changed the title
oveddan
changed the title
oveddan
changed the title
oveddan
force-pushed
the
contract-size-ci
branch
from
76141cd
to
34ea083
Compare
oveddan
force-pushed
the
contract-size-ci
branch
from
34ea083
to
03750ae
Compare
oveddan
force-pushed
the
remove-mint-fee-manager
branch
from
d2ae765
to
cd65ce0
Compare
This was referenced Aug 15, 2023
oveddan
force-pushed
the
contract-size-ci
branch
from
03750ae
to
7d711db
Compare
oveddan
force-pushed
the
remove-mint-fee-manager
branch
from
cd65ce0
to
56b3fa7
Compare
This was referenced Aug 16, 2023
Closed
Closed
Unify the logic of mint fees: All mints now use protocol rewards; this removes some duplicate code, as well as unifies the logic around fees
fix missing imports
oveddan
force-pushed
the
remove-mint-fee-manager
branch
from
56b3fa7
to
f54d7ed
Compare
This was referenced Aug 17, 2023
Merged
Merged
This was referenced Sep 6, 2023
Merged
|
Should this be merged pre-premint release? |
|
already done in #159 |
iainnash
added a commit
that referenced
this pull request
Mar 11, 2024
* feat: Boosted Minter factory and implementation * remove rpc endpoints (#203) * feat: Deploy Scripts (#128) * feat: Withdraw Gas for frame minter (#132) * multichain deploy scripts (#143) * feat: upgradeable factory (#144) feat: upgradeable factory [fix] fees multichain deploy * update fee and upgrade (#145) * fix: upgrade script (#147) * Update upgrades to standard pattern (#154) Update deployment scripts to use standard multichain patterns. --------- Co-authored-by: Dan Oved <[email protected]> Co-authored-by: Iain Nash <[email protected]> Co-authored-by: Rohan Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #130 (graphite messed up the merge somehow before, it merged it into
fix-buildwhich was already merged and deleted